* [Bridge] [PATCH 0/7] net: make some structures const
@ 2017-08-25 14:22 ` Bhumika Goyal
0 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:22 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make these const as they are not modified.
Bhumika Goyal (7):
Bluetooth: 6lowpan: make header_ops const
bridge: make ebt_table const
ieee802154: 6lowpan: make header_ops const
ipv4: make net_protocol const
RDS: make rhashtable_params const
netfilter: nat: make rhashtable_params const
SUNRPC: make kvec const
net/bluetooth/6lowpan.c | 2 +-
net/bridge/netfilter/ebtable_nat.c | 2 +-
net/ieee802154/6lowpan/core.c | 2 +-
net/ipv4/af_inet.c | 4 ++--
net/netfilter/nf_nat_core.c | 2 +-
net/rds/bind.c | 2 +-
net/sunrpc/xdr.c | 2 +-
7 files changed, 8 insertions(+), 8 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 1/7] Bluetooth: 6lowpan: make header_ops const
2017-08-25 14:22 ` [Bridge] " Bhumika Goyal
@ 2017-08-25 14:22 ` Bhumika Goyal
-1 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:21 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is only stored as a reference in a const field of
a net_device structure.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/bluetooth/6lowpan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 4e2576f..50fcdd1 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -581,7 +581,7 @@ static int bt_dev_init(struct net_device *dev)
.ndo_start_xmit = bt_xmit,
};
-static struct header_ops header_ops = {
+static const struct header_ops header_ops = {
.create = header_create,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [Bridge] [PATCH 1/7] Bluetooth: 6lowpan: make header_ops const
@ 2017-08-25 14:22 ` Bhumika Goyal
0 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:22 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is only stored as a reference in a const field of
a net_device structure.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/bluetooth/6lowpan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 4e2576f..50fcdd1 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -581,7 +581,7 @@ static int bt_dev_init(struct net_device *dev)
.ndo_start_xmit = bt_xmit,
};
-static struct header_ops header_ops = {
+static const struct header_ops header_ops = {
.create = header_create,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH 2/7] bridge: make ebt_table const
2017-08-25 14:22 ` [Bridge] " Bhumika Goyal
@ 2017-08-25 14:23 ` Bhumika Goyal
-1 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:21 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is only passed to a const argument of the function
ebt_register_table.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/bridge/netfilter/ebtable_nat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/netfilter/ebtable_nat.c b/net/bridge/netfilter/ebtable_nat.c
index 4ecf506..57cd5bb 100644
--- a/net/bridge/netfilter/ebtable_nat.c
+++ b/net/bridge/netfilter/ebtable_nat.c
@@ -48,7 +48,7 @@ static int check(const struct ebt_table_info *info, unsigned int valid_hooks)
return 0;
}
-static struct ebt_table frame_nat = {
+static const struct ebt_table frame_nat = {
.name = "nat",
.table = &initial_table,
.valid_hooks = NAT_VALID_HOOKS,
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [Bridge] [PATCH 2/7] bridge: make ebt_table const
@ 2017-08-25 14:23 ` Bhumika Goyal
0 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:23 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is only passed to a const argument of the function
ebt_register_table.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/bridge/netfilter/ebtable_nat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/netfilter/ebtable_nat.c b/net/bridge/netfilter/ebtable_nat.c
index 4ecf506..57cd5bb 100644
--- a/net/bridge/netfilter/ebtable_nat.c
+++ b/net/bridge/netfilter/ebtable_nat.c
@@ -48,7 +48,7 @@ static int check(const struct ebt_table_info *info, unsigned int valid_hooks)
return 0;
}
-static struct ebt_table frame_nat = {
+static const struct ebt_table frame_nat = {
.name = "nat",
.table = &initial_table,
.valid_hooks = NAT_VALID_HOOKS,
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 2/7] bridge: make ebt_table const
2017-08-25 14:23 ` [Bridge] " Bhumika Goyal
@ 2017-08-28 18:30 ` David Miller
-1 siblings, 0 replies; 35+ messages in thread
From: David Miller @ 2017-08-28 18:30 UTC (permalink / raw)
To: bhumirks
Cc: julia.lawall, marcel, gustavo, johan.hedberg, pablo, kadlec, fw,
stephen, alex.aring, stefan, kuznet, yoshfuji, santosh.shilimkar,
trond.myklebust, anna.schumaker, bfields, jlayton,
linux-bluetooth, netdev, linux-kernel, netfilter-devel, coreteam,
bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 25 Aug 2017 19:51:42 +0530
> Make this const as it is only passed to a const argument of the function
> ebt_register_table.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [Bridge] [PATCH 2/7] bridge: make ebt_table const
@ 2017-08-28 18:30 ` David Miller
0 siblings, 0 replies; 35+ messages in thread
From: David Miller @ 2017-08-28 18:30 UTC (permalink / raw)
To: bhumirks
Cc: alex.aring, gustavo, trond.myklebust, bfields, jlayton,
rds-devel, linux-rdma, stefan, bridge, coreteam, kadlec, kuznet,
pablo, johan.hedberg, marcel, santosh.shilimkar, julia.lawall,
linux-nfs, yoshfuji, netdev, fw, linux-kernel, linux-bluetooth,
netfilter-devel, linux-wpan, anna.schumaker
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 25 Aug 2017 19:51:42 +0530
> Make this const as it is only passed to a const argument of the function
> ebt_register_table.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 3/7] ieee802154: 6lowpan: make header_ops const
2017-08-25 14:22 ` [Bridge] " Bhumika Goyal
@ 2017-08-25 14:23 ` Bhumika Goyal
-1 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:21 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is only stored as a reference in a const field of
a net_device structure.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/ieee802154/6lowpan/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index de2661c..974765b 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -54,7 +54,7 @@
static int open_count;
-static struct header_ops lowpan_header_ops = {
+static const struct header_ops lowpan_header_ops = {
.create = lowpan_header_create,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [Bridge] [PATCH 3/7] ieee802154: 6lowpan: make header_ops const
@ 2017-08-25 14:23 ` Bhumika Goyal
0 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:23 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is only stored as a reference in a const field of
a net_device structure.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/ieee802154/6lowpan/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index de2661c..974765b 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -54,7 +54,7 @@
static int open_count;
-static struct header_ops lowpan_header_ops = {
+static const struct header_ops lowpan_header_ops = {
.create = lowpan_header_create,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const
2017-08-25 14:23 ` [Bridge] " Bhumika Goyal
@ 2017-08-25 14:39 ` Stefan Schmidt
-1 siblings, 0 replies; 35+ messages in thread
From: Stefan Schmidt @ 2017-08-25 14:36 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, marcel, gustavo, johan.hedberg,
davem, pablo, kadlec, fw, stephen, alex.aring, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Hello.
On 08/25/2017 04:21 PM, Bhumika Goyal wrote:
> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> net/ieee802154/6lowpan/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> index de2661c..974765b 100644
> --- a/net/ieee802154/6lowpan/core.c
> +++ b/net/ieee802154/6lowpan/core.c
> @@ -54,7 +54,7 @@
>
> static int open_count;
>
> -static struct header_ops lowpan_header_ops = {
> +static const struct header_ops lowpan_header_ops = {
> .create = lowpan_header_create,
> };
>
>
Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [Bridge] [PATCH 3/7] ieee802154: 6lowpan: make header_ops const
@ 2017-08-25 14:39 ` Stefan Schmidt
0 siblings, 0 replies; 35+ messages in thread
From: Stefan Schmidt @ 2017-08-25 14:39 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, marcel, gustavo, johan.hedberg,
davem, pablo, kadlec, fw, stephen, alex.aring, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Hello.
On 08/25/2017 04:21 PM, Bhumika Goyal wrote:
> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> net/ieee802154/6lowpan/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> index de2661c..974765b 100644
> --- a/net/ieee802154/6lowpan/core.c
> +++ b/net/ieee802154/6lowpan/core.c
> @@ -54,7 +54,7 @@
>
> static int open_count;
>
> -static struct header_ops lowpan_header_ops = {
> +static const struct header_ops lowpan_header_ops = {
> .create = lowpan_header_create,
> };
>
>
Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const
2017-08-25 14:23 ` [Bridge] " Bhumika Goyal
(?)
@ 2017-08-25 16:17 ` Marcel Holtmann
-1 siblings, 0 replies; 35+ messages in thread
From: Marcel Holtmann @ 2017-08-25 16:17 UTC (permalink / raw)
To: Bhumika Goyal
Cc: julia.lawall, Gustavo F. Padovan, Johan Hedberg, David S. Miller,
Pablo Neira Ayuso, kadlec, Florian Westphal, Stephen Hemminger,
Alexander Aring, Stefan Schmidt, Alexey Kuznetsov,
Hideaki YOSHIFUJI, santosh.shilimkar, trond.myklebust,
anna.schumaker, bfields, jlayton, open list:BLUETOOTH DRIVERS,
Network Development, LKML, netfilter-devel
Hi Bhumika,
> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> net/ieee802154/6lowpan/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [Bridge] [PATCH 3/7] ieee802154: 6lowpan: make header_ops const
@ 2017-08-25 16:17 ` Marcel Holtmann
0 siblings, 0 replies; 35+ messages in thread
From: Marcel Holtmann @ 2017-08-25 16:17 UTC (permalink / raw)
To: Bhumika Goyal
Cc: Alexander Aring, Gustavo F. Padovan, trond.myklebust, bfields,
jlayton, rds-devel, linux-rdma, Stefan Schmidt, bridge, coreteam,
kadlec, Alexey Kuznetsov, Pablo Neira Ayuso, Johan Hedberg,
santosh.shilimkar, julia.lawall, linux-nfs, Hideaki YOSHIFUJI,
Network Development, Florian Westphal, LKML, David S. Miller,
open list:BLUETOOTH DRIVERS, netfilter-devel, linux-wpan,
anna.schumaker
Hi Bhumika,
> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> net/ieee802154/6lowpan/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const
@ 2017-08-25 16:17 ` Marcel Holtmann
0 siblings, 0 replies; 35+ messages in thread
From: Marcel Holtmann @ 2017-08-25 16:17 UTC (permalink / raw)
To: Bhumika Goyal
Cc: julia.lawall, Gustavo F. Padovan, Johan Hedberg, David S. Miller,
Pablo Neira Ayuso, kadlec, Florian Westphal, Stephen Hemminger,
Alexander Aring, Stefan Schmidt, Alexey Kuznetsov,
Hideaki YOSHIFUJI, santosh.shilimkar, trond.myklebust,
anna.schumaker, bfields, jlayton, open list:BLUETOOTH DRIVERS,
Network Development, LKML, netfilter-devel, coreteam, bridge,
linux-wpan, linux-rdma, rds-devel, linux-nfs
Hi Bhumika,
> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> net/ieee802154/6lowpan/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 4/7] ipv4: make net_protocol const
2017-08-25 14:22 ` [Bridge] " Bhumika Goyal
@ 2017-08-25 14:23 ` Bhumika Goyal
-1 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:21 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make these const as they are only passed to a const argument of the
function inet_add_protocol.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/ipv4/af_inet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index d678820..19aee07 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1596,7 +1596,7 @@ u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_offset)
};
#endif
-static struct net_protocol tcp_protocol = {
+static const struct net_protocol tcp_protocol = {
.early_demux = tcp_v4_early_demux,
.early_demux_handler = tcp_v4_early_demux,
.handler = tcp_v4_rcv,
@@ -1606,7 +1606,7 @@ u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_offset)
.icmp_strict_tag_validation = 1,
};
-static struct net_protocol udp_protocol = {
+static const struct net_protocol udp_protocol = {
.early_demux = udp_v4_early_demux,
.early_demux_handler = udp_v4_early_demux,
.handler = udp_rcv,
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [Bridge] [PATCH 4/7] ipv4: make net_protocol const
@ 2017-08-25 14:23 ` Bhumika Goyal
0 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:23 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make these const as they are only passed to a const argument of the
function inet_add_protocol.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/ipv4/af_inet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index d678820..19aee07 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1596,7 +1596,7 @@ u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_offset)
};
#endif
-static struct net_protocol tcp_protocol = {
+static const struct net_protocol tcp_protocol = {
.early_demux = tcp_v4_early_demux,
.early_demux_handler = tcp_v4_early_demux,
.handler = tcp_v4_rcv,
@@ -1606,7 +1606,7 @@ u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_offset)
.icmp_strict_tag_validation = 1,
};
-static struct net_protocol udp_protocol = {
+static const struct net_protocol udp_protocol = {
.early_demux = udp_v4_early_demux,
.early_demux_handler = udp_v4_early_demux,
.handler = udp_rcv,
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 4/7] ipv4: make net_protocol const
2017-08-25 14:23 ` [Bridge] " Bhumika Goyal
@ 2017-08-28 18:30 ` David Miller
-1 siblings, 0 replies; 35+ messages in thread
From: David Miller @ 2017-08-28 18:30 UTC (permalink / raw)
To: bhumirks
Cc: julia.lawall, marcel, gustavo, johan.hedberg, pablo, kadlec, fw,
stephen, alex.aring, stefan, kuznet, yoshfuji, santosh.shilimkar,
trond.myklebust, anna.schumaker, bfields, jlayton,
linux-bluetooth, netdev, linux-kernel, netfilter-devel, coreteam,
bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 25 Aug 2017 19:51:44 +0530
> Make these const as they are only passed to a const argument of the
> function inet_add_protocol.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [Bridge] [PATCH 4/7] ipv4: make net_protocol const
@ 2017-08-28 18:30 ` David Miller
0 siblings, 0 replies; 35+ messages in thread
From: David Miller @ 2017-08-28 18:30 UTC (permalink / raw)
To: bhumirks
Cc: alex.aring, gustavo, trond.myklebust, bfields, jlayton,
rds-devel, linux-rdma, stefan, bridge, coreteam, kadlec, kuznet,
pablo, johan.hedberg, marcel, santosh.shilimkar, julia.lawall,
linux-nfs, yoshfuji, netdev, fw, linux-kernel, linux-bluetooth,
netfilter-devel, linux-wpan, anna.schumaker
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 25 Aug 2017 19:51:44 +0530
> Make these const as they are only passed to a const argument of the
> function inet_add_protocol.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 5/7] RDS: make rhashtable_params const
2017-08-25 14:22 ` [Bridge] " Bhumika Goyal
@ 2017-08-25 14:24 ` Bhumika Goyal
-1 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:21 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is either used during a copy operation or passed
to a const argument of the function rhltable_init
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/rds/bind.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/bind.c b/net/rds/bind.c
index 3a915be..75d43dc 100644
--- a/net/rds/bind.c
+++ b/net/rds/bind.c
@@ -40,7 +40,7 @@
static struct rhashtable bind_hash_table;
-static struct rhashtable_params ht_parms = {
+static const struct rhashtable_params ht_parms = {
.nelem_hint = 768,
.key_len = sizeof(u64),
.key_offset = offsetof(struct rds_sock, rs_bound_key),
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [Bridge] [PATCH 5/7] RDS: make rhashtable_params const
@ 2017-08-25 14:24 ` Bhumika Goyal
0 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:24 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is either used during a copy operation or passed
to a const argument of the function rhltable_init
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/rds/bind.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/bind.c b/net/rds/bind.c
index 3a915be..75d43dc 100644
--- a/net/rds/bind.c
+++ b/net/rds/bind.c
@@ -40,7 +40,7 @@
static struct rhashtable bind_hash_table;
-static struct rhashtable_params ht_parms = {
+static const struct rhashtable_params ht_parms = {
.nelem_hint = 768,
.key_len = sizeof(u64),
.key_offset = offsetof(struct rds_sock, rs_bound_key),
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
[parent not found: <1503670907-23221-6-git-send-email-bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 5/7] RDS: make rhashtable_params const
2017-08-25 14:24 ` [Bridge] " Bhumika Goyal
(?)
@ 2017-08-25 15:31 ` Santosh Shilimkar
-1 siblings, 0 replies; 35+ messages in thread
From: Santosh Shilimkar @ 2017-08-25 15:31 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall-L2FTfq7BK8M,
marcel-kz+m5ild9QBg9hUCZPvPmw, gustavo-THi1TnShQwVAfugRpC6u6w,
johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w,
davem-fT/PcQaiUtIeIZ0/mPfg9Q, pablo-Cap9r6Oaw4JrovVCs/uTlw,
kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO,
fw-HFFVJYpyMKqzQB+pC5nmwQ,
stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ,
alex.aring-Re5JQEeQqe8AvxtiuMwx3w, stefan-JPH+aEBZ4P+UEJcrhfAQsw,
kuznet-v/Mj1YrvjDBInbfyfbPRSQ, yoshfuji-VfPWfsRibaP+Ru+s062T9g,
trond.myklebust-7I+n7zu2hftEKMMhf/gKZA,
anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA,
bfields-uC3wQj2KruNg9hUCZPvPmw, jlayton-vpEMnDpepFuMZCB2o+C8xQ,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA,
coreteam-Cap9r6Oaw4JrovVCs/uTlw,
bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-wpan-u79uwXL29TY76Z2rM5mHXA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
rds-devel-N0ozoZBvEnrZJqsBc5GL+g,
linux-nfs-u79uwXL29TY76Z2rM5mHXA
8/25/2017 7:21 AM, Bhumika Goyal wrote:
> Make this const as it is either used during a copy operation or passed
> to a const argument of the function rhltable_init
>
> Signed-off-by: Bhumika Goyal <bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [Bridge] [PATCH 5/7] RDS: make rhashtable_params const
@ 2017-08-25 15:31 ` Santosh Shilimkar
0 siblings, 0 replies; 35+ messages in thread
From: Santosh Shilimkar @ 2017-08-25 15:33 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, marcel, gustavo, johan.hedberg,
davem, pablo, kadlec, fw, stephen, alex.aring, stefan, kuznet,
yoshfuji, trond.myklebust, anna.schumaker, bfields, jlayton,
linux-bluetooth, netdev, linux-kernel, netfilter-devel, coreteam,
bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
8/25/2017 7:21 AM, Bhumika Goyal wrote:
> Make this const as it is either used during a copy operation or passed
> to a const argument of the function rhltable_init
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 5/7] RDS: make rhashtable_params const
@ 2017-08-25 15:31 ` Santosh Shilimkar
0 siblings, 0 replies; 35+ messages in thread
From: Santosh Shilimkar @ 2017-08-25 15:31 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, marcel, gustavo, johan.hedberg,
davem, pablo, kadlec, fw, stephen, alex.aring, stefan, kuznet,
yoshfuji, trond.myklebust, anna.schumaker, bfields, jlayton,
linux-bluetooth, netdev, linux-kernel, netfilter-devel, coreteam,
bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
8/25/2017 7:21 AM, Bhumika Goyal wrote:
> Make this const as it is either used during a copy operation or passed
> to a const argument of the function rhltable_init
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 5/7] RDS: make rhashtable_params const
2017-08-25 14:24 ` [Bridge] " Bhumika Goyal
@ 2017-08-28 18:30 ` David Miller
-1 siblings, 0 replies; 35+ messages in thread
From: David Miller @ 2017-08-28 18:30 UTC (permalink / raw)
To: bhumirks
Cc: julia.lawall, marcel, gustavo, johan.hedberg, pablo, kadlec, fw,
stephen, alex.aring, stefan, kuznet, yoshfuji, santosh.shilimkar,
trond.myklebust, anna.schumaker, bfields, jlayton,
linux-bluetooth, netdev, linux-kernel, netfilter-devel, coreteam,
bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 25 Aug 2017 19:51:45 +0530
> Make this const as it is either used during a copy operation or passed
> to a const argument of the function rhltable_init
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [Bridge] [PATCH 5/7] RDS: make rhashtable_params const
@ 2017-08-28 18:30 ` David Miller
0 siblings, 0 replies; 35+ messages in thread
From: David Miller @ 2017-08-28 18:30 UTC (permalink / raw)
To: bhumirks
Cc: alex.aring, gustavo, trond.myklebust, bfields, jlayton,
rds-devel, linux-rdma, stefan, bridge, coreteam, kadlec, kuznet,
pablo, johan.hedberg, marcel, santosh.shilimkar, julia.lawall,
linux-nfs, yoshfuji, netdev, fw, linux-kernel, linux-bluetooth,
netfilter-devel, linux-wpan, anna.schumaker
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Fri, 25 Aug 2017 19:51:45 +0530
> Make this const as it is either used during a copy operation or passed
> to a const argument of the function rhltable_init
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 6/7] netfilter: nat: make rhashtable_params const
2017-08-25 14:22 ` [Bridge] " Bhumika Goyal
@ 2017-08-25 14:24 ` Bhumika Goyal
-1 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:21 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is either used during a copy operation or passed
to a const argument of the function rhltable_init.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/netfilter/nf_nat_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c
index b1d3740..df983ea 100644
--- a/net/netfilter/nf_nat_core.c
+++ b/net/netfilter/nf_nat_core.c
@@ -198,7 +198,7 @@ static int nf_nat_bysource_cmp(struct rhashtable_compare_arg *arg,
return 0;
}
-static struct rhashtable_params nf_nat_bysource_params = {
+static const struct rhashtable_params nf_nat_bysource_params = {
.head_offset = offsetof(struct nf_conn, nat_bysource),
.obj_hashfn = nf_nat_bysource_hash,
.obj_cmpfn = nf_nat_bysource_cmp,
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [Bridge] [PATCH 6/7] netfilter: nat: make rhashtable_params const
@ 2017-08-25 14:24 ` Bhumika Goyal
0 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:24 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is either used during a copy operation or passed
to a const argument of the function rhltable_init.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/netfilter/nf_nat_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c
index b1d3740..df983ea 100644
--- a/net/netfilter/nf_nat_core.c
+++ b/net/netfilter/nf_nat_core.c
@@ -198,7 +198,7 @@ static int nf_nat_bysource_cmp(struct rhashtable_compare_arg *arg,
return 0;
}
-static struct rhashtable_params nf_nat_bysource_params = {
+static const struct rhashtable_params nf_nat_bysource_params = {
.head_offset = offsetof(struct nf_conn, nat_bysource),
.obj_hashfn = nf_nat_bysource_hash,
.obj_cmpfn = nf_nat_bysource_cmp,
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 6/7] netfilter: nat: make rhashtable_params const
2017-08-25 14:24 ` [Bridge] " Bhumika Goyal
(?)
@ 2017-08-25 14:50 ` Florian Westphal
-1 siblings, 0 replies; 35+ messages in thread
From: Florian Westphal @ 2017-08-25 14:50 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: netfilter-devel, netdev
Bhumika Goyal <bhumirks@gmail.com> wrote:
[..]
trimming CC list, also this should probably have been
sent to netfilter-devel@vger.kernel.org on its own, with [nf-next] in
subject line. That aside:
Acked-by: Florian Westphal <fw@strlen.de>
^ permalink raw reply [flat|nested] 35+ messages in thread
[parent not found: <1503670907-23221-1-git-send-email-bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCH 7/7] SUNRPC: make kvec const
2017-08-25 14:22 ` [Bridge] " Bhumika Goyal
(?)
@ 2017-08-25 14:21 ` Bhumika Goyal
-1 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:21 UTC (permalink / raw)
To: julia.lawall-L2FTfq7BK8M, marcel-kz+m5ild9QBg9hUCZPvPmw,
gustavo-THi1TnShQwVAfugRpC6u6w,
johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w,
davem-fT/PcQaiUtIeIZ0/mPfg9Q, pablo-Cap9r6Oaw4JrovVCs/uTlw,
kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO,
fw-HFFVJYpyMKqzQB+pC5nmwQ,
stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ,
alex.aring-Re5JQEeQqe8AvxtiuMwx3w, stefan-JPH+aEBZ4P+UEJcrhfAQsw,
kuznet-v/Mj1YrvjDBInbfyfbPRSQ, yoshfuji-VfPWfsRibaP+Ru+s062T9g,
santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA,
trond.myklebust-7I+n7zu2hftEKMMhf/gKZA,
anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA,
bfields-uC3wQj2KruNg9hUCZPvPmw, jlayton-vpEMnDpepFuMZCB2o+C8xQ,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA,
coreteam-Cap9r6Oaw4JrovVCs/uTlw,
bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-wpan-u79uwXL29TY76Z2rM5mHXA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
rds-devel-N0ozoZBvEnrZJqsBc5GL+g,
linux-nfs-u79uwXL29TY76Z2rM5mHXA
Cc: Bhumika Goyal
Make this const as it is only used during a copy operation.
Signed-off-by: Bhumika Goyal <bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
net/sunrpc/xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index e34f4ee..a096025 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
}
EXPORT_SYMBOL_GPL(xdr_enter_page);
-static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
+static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
void
xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [Bridge] [PATCH 7/7] SUNRPC: make kvec const
@ 2017-08-25 14:21 ` Bhumika Goyal
0 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:24 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is only used during a copy operation.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/sunrpc/xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index e34f4ee..a096025 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
}
EXPORT_SYMBOL_GPL(xdr_enter_page);
-static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
+static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
void
xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH 7/7] SUNRPC: make kvec const
@ 2017-08-25 14:21 ` Bhumika Goyal
0 siblings, 0 replies; 35+ messages in thread
From: Bhumika Goyal @ 2017-08-25 14:21 UTC (permalink / raw)
To: julia.lawall, marcel, gustavo, johan.hedberg, davem, pablo,
kadlec, fw, stephen, alex.aring, stefan, kuznet, yoshfuji,
santosh.shilimkar, trond.myklebust, anna.schumaker, bfields,
jlayton, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
Cc: Bhumika Goyal
Make this const as it is only used during a copy operation.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
net/sunrpc/xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index e34f4ee..a096025 100644
--- a/net/sunrpc/xdr.c
+++ b/net/sunrpc/xdr.c
@@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
}
EXPORT_SYMBOL_GPL(xdr_enter_page);
-static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
+static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
void
xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)
--
1.9.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 7/7] SUNRPC: make kvec const
2017-08-25 14:21 ` Bhumika Goyal
(?)
@ 2017-08-25 14:48 ` Jeff Layton
-1 siblings, 0 replies; 35+ messages in thread
From: Jeff Layton @ 2017-08-25 14:48 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, marcel, gustavo, johan.hedberg,
davem, pablo, kadlec, fw, stephen, alex.aring, stefan, kuznet,
yoshfuji, santosh.shilimkar, trond.myklebust, anna.schumaker,
bfields, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
On Fri, 2017-08-25 at 19:51 +0530, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> net/sunrpc/xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e34f4ee..a096025 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
> }
> EXPORT_SYMBOL_GPL(xdr_enter_page);
>
> -static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
> +static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
>
> void
> xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)
Reviewed-by: Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [Bridge] [PATCH 7/7] SUNRPC: make kvec const
@ 2017-08-25 14:48 ` Jeff Layton
0 siblings, 0 replies; 35+ messages in thread
From: Jeff Layton @ 2017-08-25 14:49 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, marcel, gustavo, johan.hedberg,
davem, pablo, kadlec, fw, stephen, alex.aring, stefan, kuznet,
yoshfuji, santosh.shilimkar, trond.myklebust, anna.schumaker,
bfields, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
On Fri, 2017-08-25 at 19:51 +0530, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> net/sunrpc/xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e34f4ee..a096025 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
> }
> EXPORT_SYMBOL_GPL(xdr_enter_page);
>
> -static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
> +static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
>
> void
> xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)
Reviewed-by: Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 7/7] SUNRPC: make kvec const
@ 2017-08-25 14:48 ` Jeff Layton
0 siblings, 0 replies; 35+ messages in thread
From: Jeff Layton @ 2017-08-25 14:48 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, marcel, gustavo, johan.hedberg,
davem, pablo, kadlec, fw, stephen, alex.aring, stefan, kuznet,
yoshfuji, santosh.shilimkar, trond.myklebust, anna.schumaker,
bfields, linux-bluetooth, netdev, linux-kernel, netfilter-devel,
coreteam, bridge, linux-wpan, linux-rdma, rds-devel, linux-nfs
On Fri, 2017-08-25 at 19:51 +0530, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> net/sunrpc/xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e34f4ee..a096025 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
> }
> EXPORT_SYMBOL_GPL(xdr_enter_page);
>
> -static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
> +static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
>
> void
> xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)
Reviewed-by: Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 35+ messages in thread