* [PATCH V2] pinctrl: qcom: spmi-gpio: Correct power_source range check
@ 2017-08-28 3:00 fenglinw
2017-08-31 13:49 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: fenglinw @ 2017-08-28 3:00 UTC (permalink / raw)
To: linux-arm-msm, linux-kernel, bjorn.andersson, Linus Walleij, linux-gpio
Cc: collinsd, aghayal, wruan, kgunda, Fenglin Wu
From: Fenglin Wu <fenglinw@codeaurora.org>
Power source selection in DIG_VIN_CTL is indexed from 0, in the range
check it shouldn't be equal to the total number of power sources.
Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 664b641..8b77c04 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -375,7 +375,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
pad->is_enabled = false;
break;
case PIN_CONFIG_POWER_SOURCE:
- if (arg > pad->num_sources)
+ if (arg >= pad->num_sources)
return -EINVAL;
pad->power_source = arg;
break;
--
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] pinctrl: qcom: spmi-gpio: Correct power_source range check
2017-08-28 3:00 [PATCH V2] pinctrl: qcom: spmi-gpio: Correct power_source range check fenglinw
@ 2017-08-31 13:49 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-08-31 13:49 UTC (permalink / raw)
To: fenglinw
Cc: linux-arm-msm, linux-kernel, Bjorn Andersson, linux-gpio,
David Collins, aghayal, wruan, kgunda
On Mon, Aug 28, 2017 at 5:00 AM, <fenglinw@codeaurora.org> wrote:
> From: Fenglin Wu <fenglinw@codeaurora.org>
>
> Power source selection in DIG_VIN_CTL is indexed from 0, in the range
> check it shouldn't be equal to the total number of power sources.
>
> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
I already applied a version of this.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-31 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 3:00 [PATCH V2] pinctrl: qcom: spmi-gpio: Correct power_source range check fenglinw
2017-08-31 13:49 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.