All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
@ 2017-08-27 12:55 ` Priit Laes
  0 siblings, 0 replies; 9+ messages in thread
From: Priit Laes @ 2017-08-27 12:55 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Linus Walleij,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Priit Laes

This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.

The original patch was intented to avoid some issues with the sunxi
gpio rework and was supposed to be reverted after all the required
DT bits had been merged around v4.10.

Signed-off-by: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
---
 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 0dfd7fa66c48..52edf3b5988d 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -564,7 +564,8 @@ static int sunxi_pconf_group_set(struct pinctrl_dev *pctldev,
 			val = arg / 10 - 1;
 			break;
 		case PIN_CONFIG_BIAS_DISABLE:
-			continue;
+			val = 0;
+			break;
 		case PIN_CONFIG_BIAS_PULL_UP:
 			if (arg == 0)
 				return -EINVAL;
-- 
2.13.5

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
@ 2017-08-27 12:55 ` Priit Laes
  0 siblings, 0 replies; 9+ messages in thread
From: Priit Laes @ 2017-08-27 12:55 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Linus Walleij, linux-arm-kernel,
	linux-gpio, linux-kernel
  Cc: linux-sunxi, Priit Laes

This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.

The original patch was intented to avoid some issues with the sunxi
gpio rework and was supposed to be reverted after all the required
DT bits had been merged around v4.10.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 0dfd7fa66c48..52edf3b5988d 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -564,7 +564,8 @@ static int sunxi_pconf_group_set(struct pinctrl_dev *pctldev,
 			val = arg / 10 - 1;
 			break;
 		case PIN_CONFIG_BIAS_DISABLE:
-			continue;
+			val = 0;
+			break;
 		case PIN_CONFIG_BIAS_PULL_UP:
 			if (arg == 0)
 				return -EINVAL;
-- 
2.13.5

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
@ 2017-08-27 12:55 ` Priit Laes
  0 siblings, 0 replies; 9+ messages in thread
From: Priit Laes @ 2017-08-27 12:55 UTC (permalink / raw)
  To: linux-arm-kernel

This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.

The original patch was intented to avoid some issues with the sunxi
gpio rework and was supposed to be reverted after all the required
DT bits had been merged around v4.10.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 0dfd7fa66c48..52edf3b5988d 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -564,7 +564,8 @@ static int sunxi_pconf_group_set(struct pinctrl_dev *pctldev,
 			val = arg / 10 - 1;
 			break;
 		case PIN_CONFIG_BIAS_DISABLE:
-			continue;
+			val = 0;
+			break;
 		case PIN_CONFIG_BIAS_PULL_UP:
 			if (arg == 0)
 				return -EINVAL;
-- 
2.13.5

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
  2017-08-27 12:55 ` Priit Laes
  (?)
@ 2017-08-28  6:46     ` Maxime Ripard
  -1 siblings, 0 replies; 9+ messages in thread
From: Maxime Ripard @ 2017-08-28  6:46 UTC (permalink / raw)
  To: Priit Laes
  Cc: Chen-Yu Tsai, Linus Walleij,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

1;4803;0c
On Sun, Aug 27, 2017 at 03:55:23PM +0300, Priit Laes wrote:
> This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.
> 
> The original patch was intented to avoid some issues with the sunxi
> gpio rework and was supposed to be reverted after all the required
> DT bits had been merged around v4.10.
> 
> Signed-off-by: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>

Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
@ 2017-08-28  6:46     ` Maxime Ripard
  0 siblings, 0 replies; 9+ messages in thread
From: Maxime Ripard @ 2017-08-28  6:46 UTC (permalink / raw)
  To: Priit Laes
  Cc: Chen-Yu Tsai, Linus Walleij, linux-arm-kernel, linux-gpio,
	linux-kernel, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

1;4803;0c
On Sun, Aug 27, 2017 at 03:55:23PM +0300, Priit Laes wrote:
> This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.
> 
> The original patch was intented to avoid some issues with the sunxi
> gpio rework and was supposed to be reverted after all the required
> DT bits had been merged around v4.10.
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
@ 2017-08-28  6:46     ` Maxime Ripard
  0 siblings, 0 replies; 9+ messages in thread
From: Maxime Ripard @ 2017-08-28  6:46 UTC (permalink / raw)
  To: linux-arm-kernel

1;4803;0c
On Sun, Aug 27, 2017 at 03:55:23PM +0300, Priit Laes wrote:
> This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.
> 
> The original patch was intented to avoid some issues with the sunxi
> gpio rework and was supposed to be reverted after all the required
> DT bits had been merged around v4.10.
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170828/fdcb06e3/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
  2017-08-27 12:55 ` Priit Laes
  (?)
@ 2017-08-31 13:52     ` Linus Walleij
  -1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2017-08-31 13:52 UTC (permalink / raw)
  To: Priit Laes
  Cc: Maxime Ripard, Chen-Yu Tsai,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi

On Sun, Aug 27, 2017 at 2:55 PM, Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org> wrote:

> This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.
>
> The original patch was intented to avoid some issues with the sunxi
> gpio rework and was supposed to be reverted after all the required
> DT bits had been merged around v4.10.
>
> Signed-off-by: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>

Patch applied with Maxime's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
@ 2017-08-31 13:52     ` Linus Walleij
  0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2017-08-31 13:52 UTC (permalink / raw)
  To: Priit Laes
  Cc: Maxime Ripard, Chen-Yu Tsai, linux-arm-kernel, linux-gpio,
	linux-kernel, linux-sunxi

On Sun, Aug 27, 2017 at 2:55 PM, Priit Laes <plaes@plaes.org> wrote:

> This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.
>
> The original patch was intented to avoid some issues with the sunxi
> gpio rework and was supposed to be reverted after all the required
> DT bits had been merged around v4.10.
>
> Signed-off-by: Priit Laes <plaes@plaes.org>

Patch applied with Maxime's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
@ 2017-08-31 13:52     ` Linus Walleij
  0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2017-08-31 13:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, Aug 27, 2017 at 2:55 PM, Priit Laes <plaes@plaes.org> wrote:

> This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.
>
> The original patch was intented to avoid some issues with the sunxi
> gpio rework and was supposed to be reverted after all the required
> DT bits had been merged around v4.10.
>
> Signed-off-by: Priit Laes <plaes@plaes.org>

Patch applied with Maxime's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-08-31 13:53 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-27 12:55 [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)" Priit Laes
2017-08-27 12:55 ` Priit Laes
2017-08-27 12:55 ` Priit Laes
     [not found] ` <20170827125523.29208-1-plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2017-08-28  6:46   ` Maxime Ripard
2017-08-28  6:46     ` Maxime Ripard
2017-08-28  6:46     ` Maxime Ripard
2017-08-31 13:52   ` Linus Walleij
2017-08-31 13:52     ` Linus Walleij
2017-08-31 13:52     ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.