[PATCH igt] igt/vgem_basic: Load and unload the module first

[PATCH igt] igt/vgem_basic: Load and unload the module first

[Chris Wilson]

To ensure the module exists, first load it. Then when we try to unload
the module (to check that our modprobe interface works), we will not get
spurious failures due to -ENOENT (in this case meaning the module did
not exist):

(vgem_basic:18361) igt-core-DEBUG: Starting subtest: unload
(vgem_basic:18361) igt-kmod-DEBUG: Could not remove module vgem (No such file or directory)
Test requirement not met in function test_unload, file vgem_basic.c:331:
Test requirement: module_unload() == 0
Last errno: 2, No such file or directory

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/vgem_basic.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/vgem_basic.c b/tests/vgem_basic.c
index 982da73a..cfd94071 100644
--- a/tests/vgem_basic.c
+++ b/tests/vgem_basic.c
@@ -328,6 +328,9 @@ static void test_unload(void)
 	int vgem, dmabuf;
 	uint32_t *ptr;
 
+	/* Load and unload vgem just to make sure it exists */
+	vgem = __drm_open_driver(DRIVER_VGEM);
+	igt_require(vgem != -1);
 	igt_require(module_unload() == 0);
 
 	vgem = __drm_open_driver(DRIVER_VGEM);
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH igt v2] igt/vgem_basic: Load and unload the module first

[Chris Wilson]

To ensure the module exists, first load it. Then when we try to unload
the module (to check that our modprobe interface works), we will not get
spurious failures due to -ENOENT (in this case meaning the module did
not exist):

(vgem_basic:18361) igt-core-DEBUG: Starting subtest: unload
(vgem_basic:18361) igt-kmod-DEBUG: Could not remove module vgem (No such file or directory)
Test requirement not met in function test_unload, file vgem_basic.c:331:
Test requirement: module_unload() == 0
Last errno: 2, No such file or directory

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/vgem_basic.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/vgem_basic.c b/tests/vgem_basic.c
index 982da73a..1a952c54 100644
--- a/tests/vgem_basic.c
+++ b/tests/vgem_basic.c
@@ -328,6 +328,10 @@ static void test_unload(void)
 	int vgem, dmabuf;
 	uint32_t *ptr;
 
+	/* Load and unload vgem just to make sure it exists */
+	vgem = __drm_open_driver(DRIVER_VGEM);
+	igt_require(vgem != -1);
+	close(vgem);
 	igt_require(module_unload() == 0);
 
 	vgem = __drm_open_driver(DRIVER_VGEM);
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: warning for igt/vgem_basic: Load and unload the module first

[Patchwork]

== Series Details ==

Series: igt/vgem_basic: Load and unload the module first
URL   : https://patchwork.freedesktop.org/series/29371/
State : warning

== Summary ==

IGT patchset tested on top of latest successful build
29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some information about the execbuf calls

with latest DRM-Tip kernel build CI_DRM_3006
4823f19b979c drm-tip: 2017y-08m-25d-15h-55m-05s UTC integration manifest

Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                fail       -> PASS       (fi-snb-2600) fdo#100007
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                fail       -> PASS       (fi-snb-2600) fdo#100215 +1
Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                skip       -> PASS       (fi-skl-x1585l) fdo#101781
Test vgem_basic:
        Subgroup unload:
                pass       -> SKIP       (fi-blb-e6850)
                pass       -> SKIP       (fi-pnv-d510)
                pass       -> SKIP       (fi-bwr-2160)
                pass       -> SKIP       (fi-elk-e7500)
                pass       -> SKIP       (fi-ilk-650)
                pass       -> SKIP       (fi-snb-2520m)
                pass       -> SKIP       (fi-snb-2600)
                pass       -> SKIP       (fi-ivb-3520m)
                pass       -> SKIP       (fi-ivb-3770)
                pass       -> SKIP       (fi-byt-j1900)
                pass       -> SKIP       (fi-byt-n2820)
                pass       -> SKIP       (fi-hsw-4770)
                pass       -> SKIP       (fi-hsw-4770r)
                pass       -> SKIP       (fi-bdw-5557u)
                pass       -> SKIP       (fi-bdw-gvtdvm)
                pass       -> SKIP       (fi-bsw-n3050)
                pass       -> SKIP       (fi-skl-6260u)
                pass       -> SKIP       (fi-skl-6700k)
                pass       -> SKIP       (fi-skl-6770hq)
                pass       -> SKIP       (fi-skl-gvtdvm)
                pass       -> SKIP       (fi-skl-x1585l)
                pass       -> SKIP       (fi-bxt-j4205)
                pass       -> SKIP       (fi-kbl-7500u)
                pass       -> SKIP       (fi-kbl-7560u)
                pass       -> SKIP       (fi-kbl-r)
                pass       -> SKIP       (fi-glk-2a)

fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781

fi-bdw-5557u     total:279  pass:266  dwarn:1   dfail:0   fail:0   skip:12  time:454s
fi-bdw-gvtdvm    total:279  pass:264  dwarn:0   dfail:0   fail:0   skip:15  time:437s
fi-blb-e6850     total:279  pass:223  dwarn:1   dfail:0   fail:0   skip:55  time:363s
fi-bsw-n3050     total:279  pass:242  dwarn:0   dfail:0   fail:0   skip:37  time:566s
fi-bwr-2160      total:279  pass:183  dwarn:0   dfail:0   fail:0   skip:96  time:252s
fi-bxt-j4205     total:279  pass:259  dwarn:0   dfail:0   fail:0   skip:20  time:521s
fi-byt-j1900     total:279  pass:253  dwarn:1   dfail:0   fail:0   skip:25  time:523s
fi-byt-n2820     total:279  pass:249  dwarn:1   dfail:0   fail:0   skip:29  time:517s
fi-elk-e7500     total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:438s
fi-glk-2a        total:279  pass:259  dwarn:0   dfail:0   fail:0   skip:20  time:607s
fi-hsw-4770      total:279  pass:262  dwarn:0   dfail:0   fail:0   skip:17  time:448s
fi-hsw-4770r     total:279  pass:262  dwarn:0   dfail:0   fail:0   skip:17  time:423s
fi-ilk-650       total:279  pass:228  dwarn:0   dfail:0   fail:0   skip:51  time:423s
fi-ivb-3520m     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:500s
fi-ivb-3770      total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:473s
fi-kbl-7500u     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:475s
fi-kbl-7560u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:597s
fi-kbl-r         total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:601s
fi-pnv-d510      total:279  pass:222  dwarn:1   dfail:0   fail:0   skip:56  time:525s
fi-skl-6260u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:473s
fi-skl-6700k     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:477s
fi-skl-6770hq    total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:493s
fi-skl-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:447s
fi-skl-x1585l    total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:505s
fi-snb-2520m     total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:544s
fi-snb-2600      total:279  pass:249  dwarn:0   dfail:0   fail:0   skip:30  time:407s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_104/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for igt/vgem_basic: Load and unload the module first (rev2)

[Patchwork]

== Series Details ==

Series: igt/vgem_basic: Load and unload the module first (rev2)
URL   : https://patchwork.freedesktop.org/series/29371/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
60f6a12195395934f179d5ecc080353190d19a6c tests: chamelium: Eliminate reset when preparing output

with latest DRM-Tip kernel build CI_DRM_3006
4823f19b979c drm-tip: 2017y-08m-25d-15h-55m-05s UTC integration manifest

Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                fail       -> PASS       (fi-snb-2600) fdo#100007
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                fail       -> PASS       (fi-snb-2600) fdo#100215 +1
Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                skip       -> PASS       (fi-skl-x1585l) fdo#101781
Test kms_frontbuffer_tracking:
        Subgroup basic:
                dmesg-warn -> PASS       (fi-bdw-5557u) fdo#102410

fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#102410 https://bugs.freedesktop.org/show_bug.cgi?id=102410

fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:461s
fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:444s
fi-blb-e6850     total:279  pass:224  dwarn:1   dfail:0   fail:0   skip:54  time:363s
fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:548s
fi-bwr-2160      total:279  pass:184  dwarn:0   dfail:0   fail:0   skip:95  time:251s
fi-bxt-j4205     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:523s
fi-byt-j1900     total:279  pass:254  dwarn:1   dfail:0   fail:0   skip:24  time:521s
fi-byt-n2820     total:279  pass:250  dwarn:1   dfail:0   fail:0   skip:28  time:520s
fi-elk-e7500     total:279  pass:230  dwarn:0   dfail:0   fail:0   skip:49  time:439s
fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:612s
fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:456s
fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:427s
fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:424s
fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:507s
fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:476s
fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:476s
fi-kbl-7560u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:600s
fi-kbl-r         total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:594s
fi-pnv-d510      total:279  pass:223  dwarn:1   dfail:0   fail:0   skip:55  time:522s
fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:476s
fi-skl-6700k     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:481s
fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:487s
fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:444s
fi-skl-x1585l    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:505s
fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:553s
fi-snb-2600      total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:403s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_105/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for igt/vgem_basic: Load and unload the module first

[Patchwork]

== Series Details ==

Series: igt/vgem_basic: Load and unload the module first
URL   : https://patchwork.freedesktop.org/series/29371/
State : success

== Summary ==

Test perf:
        Subgroup polling:
                pass       -> FAIL       (shard-hsw) fdo#102252

fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-hsw        total:2230 pass:1229 dwarn:0   dfail:0   fail:19  skip:982 time:9649s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_104/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for igt/vgem_basic: Load and unload the module first (rev2)

[Patchwork]

== Series Details ==

Series: igt/vgem_basic: Load and unload the module first (rev2)
URL   : https://patchwork.freedesktop.org/series/29371/
State : success

== Summary ==

Test vgem_basic:
        Subgroup unload:
                skip       -> PASS       (shard-hsw)

shard-hsw        total:2230 pass:1231 dwarn:0   dfail:0   fail:18  skip:981 time:9645s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_105/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt v2] igt/vgem_basic: Load and unload the module first

[Petri Latvala]

On Fri, Aug 25, 2017 at 07:26:39PM +0100, Chris Wilson wrote:
> To ensure the module exists, first load it. Then when we try to unload
> the module (to check that our modprobe interface works), we will not get
> spurious failures due to -ENOENT (in this case meaning the module did
> not exist):
> 
> (vgem_basic:18361) igt-core-DEBUG: Starting subtest: unload
> (vgem_basic:18361) igt-kmod-DEBUG: Could not remove module vgem (No such file or directory)
> Test requirement not met in function test_unload, file vgem_basic.c:331:
> Test requirement: module_unload() == 0
> Last errno: 2, No such file or directory
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>


Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx