* [PATCH] cobalt: do not register subdev nodes
@ 2017-08-28 8:45 Hans Verkuil
2017-08-28 9:36 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2017-08-28 8:45 UTC (permalink / raw)
To: Linux Media Mailing List
In the distant past the adv7604 driver used private controls. In order to access
them the v4l-subdevX nodes were needed. Later the is_private tag was removed in
the adv7604 driver and the need for v4l-subdevX device nodes disappeared.
Remove the creation of those device nodes from this driver.
Note: the cobalt card is only used inside Cisco and we never actually used the
v4l-subdevX nodes for anything. So this API change can be done safely without
breaking anything.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b/drivers/media/pci/cobalt/cobalt-driver.c
index 98b6cb9505d1..c9d8006ff697 100644
--- a/drivers/media/pci/cobalt/cobalt-driver.c
+++ b/drivers/media/pci/cobalt/cobalt-driver.c
@@ -738,9 +738,6 @@ static int cobalt_probe(struct pci_dev *pci_dev,
goto err_i2c;
}
- retval = v4l2_device_register_subdev_nodes(&cobalt->v4l2_dev);
- if (retval)
- goto err_i2c;
retval = cobalt_nodes_register(cobalt);
if (retval) {
cobalt_err("Error %d registering device nodes\n", retval);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cobalt: do not register subdev nodes
2017-08-28 8:45 [PATCH] cobalt: do not register subdev nodes Hans Verkuil
@ 2017-08-28 9:36 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2017-08-28 9:36 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
On Mon, Aug 28, 2017 at 10:45:58AM +0200, Hans Verkuil wrote:
> In the distant past the adv7604 driver used private controls. In order to access
> them the v4l-subdevX nodes were needed. Later the is_private tag was removed in
> the adv7604 driver and the need for v4l-subdevX device nodes disappeared.
>
> Remove the creation of those device nodes from this driver.
>
> Note: the cobalt card is only used inside Cisco and we never actually used the
> v4l-subdevX nodes for anything. So this API change can be done safely without
> breaking anything.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-28 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 8:45 [PATCH] cobalt: do not register subdev nodes Hans Verkuil
2017-08-28 9:36 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.