From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: David Carrillo-Cisneros <davidcc@google.com>,
linux-kernel@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Stephane Eranian <eranian@google.com>,
Paul Turner <pjt@google.com>
Subject: Re: [PATCH 0/6] perf tools: Minor build fixes
Date: Mon, 28 Aug 2017 11:16:07 -0300 [thread overview]
Message-ID: <20170828141607.GI10477@kernel.org> (raw)
In-Reply-To: <20170828093421.GB15692@krava>
Em Mon, Aug 28, 2017 at 11:34:21AM +0200, Jiri Olsa escreveu:
> On Sun, Aug 27, 2017 at 12:54:36AM -0700, David Carrillo-Cisneros wrote:
> > Collection of minor fixes to compile with LLVM and
> > non-standard tool names.
> >
> > David Carrillo-Cisneros (6):
> > tools build tests: Don't hardcode gcc name
> > perf tools: Allow external definition of flex and bison binary names
> > tools lib: Allow external definition of CC, AR and LD
> > perf tools: Robustify detection of clang binary
> > perf tools: Remove BUG_ON char[] to bool implicit conversions
> > perf tools: Pass full path of FEATURES_DUMP
>
> apart from comment for 5/6 I'm ok with this
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied all that Jiri acked, agree with him that BUG should be
avoided, and also that we should use existing facilities when available,
and when there aren't, try to replicate as best as we can similar
facilities existing in the kernel source code.
- Arnaldo
next prev parent reply other threads:[~2017-08-28 14:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 7:54 [PATCH 0/6] perf tools: Minor build fixes David Carrillo-Cisneros
2017-08-27 7:54 ` [PATCH 1/6] tools build tests: Don't hardcode gcc name David Carrillo-Cisneros
2017-08-29 21:22 ` [tip:perf/core] " tip-bot for David Carrillo-Cisneros
2017-08-27 7:54 ` [PATCH 2/6] perf tools: Allow external definition of flex and bison binary names David Carrillo-Cisneros
2017-08-29 21:23 ` [tip:perf/core] " tip-bot for David Carrillo-Cisneros
2017-08-27 7:54 ` [PATCH 3/6] tools lib: Allow external definition of CC, AR and LD David Carrillo-Cisneros
2017-08-29 21:23 ` [tip:perf/core] " tip-bot for David Carrillo-Cisneros
2017-08-27 7:54 ` [PATCH 4/6] perf tools: Robustify detection of clang binary David Carrillo-Cisneros
2017-08-29 21:23 ` [tip:perf/core] " tip-bot for David Carrillo-Cisneros
2017-08-27 7:54 ` [PATCH 5/6] perf tools: Remove BUG_ON char[] to bool implicit conversions David Carrillo-Cisneros
2017-08-28 9:33 ` Jiri Olsa
2017-08-28 18:30 ` [PATCH] " David Carrillo-Cisneros
2017-08-27 7:54 ` [PATCH 6/6] perf tools: Pass full path of FEATURES_DUMP David Carrillo-Cisneros
2017-08-29 21:24 ` [tip:perf/core] " tip-bot for David Carrillo-Cisneros
2017-08-28 9:34 ` [PATCH 0/6] perf tools: Minor build fixes Jiri Olsa
2017-08-28 14:16 ` Arnaldo Carvalho de Melo [this message]
2017-08-28 18:31 ` David Carrillo-Cisneros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828141607.GI10477@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.