* [PATCH] MAINTAINERS: Add files under drivers/virt/* to CHAR and MISC DRIVERS section
@ 2017-08-25 11:56 Hans de Goede
2017-08-25 13:10 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2017-08-25 11:56 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: Hans de Goede, linux-kernel
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6a349b5c0c2a..db633caa5a1d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3284,6 +3284,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Supported
F: drivers/char/*
F: drivers/misc/*
+F: drivers/virt/*
F: include/linux/miscdevice.h
CHECKPATCH
--
2.13.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add files under drivers/virt/* to CHAR and MISC DRIVERS section
2017-08-25 11:56 [PATCH] MAINTAINERS: Add files under drivers/virt/* to CHAR and MISC DRIVERS section Hans de Goede
@ 2017-08-25 13:10 ` Greg Kroah-Hartman
2017-08-25 13:11 ` Hans de Goede
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2017-08-25 13:10 UTC (permalink / raw)
To: Hans de Goede; +Cc: Arnd Bergmann, linux-kernel
On Fri, Aug 25, 2017 at 01:56:23PM +0200, Hans de Goede wrote:
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6a349b5c0c2a..db633caa5a1d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3284,6 +3284,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> S: Supported
> F: drivers/char/*
> F: drivers/misc/*
> +F: drivers/virt/*
Really? I'm now in charge of this directory too? That's news to me...
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add files under drivers/virt/* to CHAR and MISC DRIVERS section
2017-08-25 13:10 ` Greg Kroah-Hartman
@ 2017-08-25 13:11 ` Hans de Goede
2017-08-28 14:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2017-08-25 13:11 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Arnd Bergmann, linux-kernel
Hi,
On 25-08-17 15:10, Greg Kroah-Hartman wrote:
> On Fri, Aug 25, 2017 at 01:56:23PM +0200, Hans de Goede wrote:
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> MAINTAINERS | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6a349b5c0c2a..db633caa5a1d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3284,6 +3284,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
>> S: Supported
>> F: drivers/char/*
>> F: drivers/misc/*
>> +F: drivers/virt/*
>
> Really? I'm now in charge of this directory too? That's news to me...
This was suggested by Arnd, as he preferred putting the vboxguest driver
under drivers/virt rather then drivers/misc. Note that currently there is
only one .c file under drivers/virt: fsl_hypervisor.c
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add files under drivers/virt/* to CHAR and MISC DRIVERS section
2017-08-25 13:11 ` Hans de Goede
@ 2017-08-28 14:08 ` Greg Kroah-Hartman
2017-08-28 14:13 ` Hans de Goede
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2017-08-28 14:08 UTC (permalink / raw)
To: Hans de Goede; +Cc: Arnd Bergmann, linux-kernel
On Fri, Aug 25, 2017 at 03:11:25PM +0200, Hans de Goede wrote:
> Hi,
>
> On 25-08-17 15:10, Greg Kroah-Hartman wrote:
> > On Fri, Aug 25, 2017 at 01:56:23PM +0200, Hans de Goede wrote:
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > > ---
> > > MAINTAINERS | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 6a349b5c0c2a..db633caa5a1d 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -3284,6 +3284,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > > S: Supported
> > > F: drivers/char/*
> > > F: drivers/misc/*
> > > +F: drivers/virt/*
> >
> > Really? I'm now in charge of this directory too? That's news to me...
>
> This was suggested by Arnd, as he preferred putting the vboxguest driver
> under drivers/virt rather then drivers/misc. Note that currently there is
> only one .c file under drivers/virt: fsl_hypervisor.c
Ok, but how about we wait until there is more than one file in here?
And what happened to all of the other "virt" drivers, why are they not
here? Perhaps using this directory isn't really a good idea?
I don't know...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add files under drivers/virt/* to CHAR and MISC DRIVERS section
2017-08-28 14:08 ` Greg Kroah-Hartman
@ 2017-08-28 14:13 ` Hans de Goede
2017-08-28 14:26 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2017-08-28 14:13 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Arnd Bergmann, linux-kernel
Hi,
On 28-08-17 16:08, Greg Kroah-Hartman wrote:
> On Fri, Aug 25, 2017 at 03:11:25PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 25-08-17 15:10, Greg Kroah-Hartman wrote:
>>> On Fri, Aug 25, 2017 at 01:56:23PM +0200, Hans de Goede wrote:
>>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>> ---
>>>> MAINTAINERS | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 6a349b5c0c2a..db633caa5a1d 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -3284,6 +3284,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
>>>> S: Supported
>>>> F: drivers/char/*
>>>> F: drivers/misc/*
>>>> +F: drivers/virt/*
>>>
>>> Really? I'm now in charge of this directory too? That's news to me...
>>
>> This was suggested by Arnd, as he preferred putting the vboxguest driver
>> under drivers/virt rather then drivers/misc. Note that currently there is
>> only one .c file under drivers/virt: fsl_hypervisor.c
>
> Ok, but how about we wait until there is more than one file in here?
That is fine by me.
> And what happened to all of the other "virt" drivers, why are they not here?
Some vmware drivers are currently under drivers/misc, Arnd's proposal was
to move those to drivers/virt. virtio and hyperv have their own subsys
dirs.
> Perhaps using this directory isn't really a good idea?
I started out with the same idea which is why v1 of my RFC posting of the
vboxguest driver used drivers/misc, alternatively we could move the single
driver currently under drivers/virt to drivers/misc and stop using
drivers/virt.
> I don't know...
Arnd indicated he has a preference for using drivers/virt for vboxguest +
the vmware drivers, I'm fine either way. This really is a bit of a bikeshed-
ish discussion IMHO. So if you and/or Arnd pick one I will happily follow
whatever you choose.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: Add files under drivers/virt/* to CHAR and MISC DRIVERS section
2017-08-28 14:13 ` Hans de Goede
@ 2017-08-28 14:26 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2017-08-28 14:26 UTC (permalink / raw)
To: Hans de Goede; +Cc: Arnd Bergmann, linux-kernel
On Mon, Aug 28, 2017 at 04:13:38PM +0200, Hans de Goede wrote:
> Hi,
>
> On 28-08-17 16:08, Greg Kroah-Hartman wrote:
> > On Fri, Aug 25, 2017 at 03:11:25PM +0200, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 25-08-17 15:10, Greg Kroah-Hartman wrote:
> > > > On Fri, Aug 25, 2017 at 01:56:23PM +0200, Hans de Goede wrote:
> > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > > > > ---
> > > > > MAINTAINERS | 1 +
> > > > > 1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index 6a349b5c0c2a..db633caa5a1d 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -3284,6 +3284,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > > > > S: Supported
> > > > > F: drivers/char/*
> > > > > F: drivers/misc/*
> > > > > +F: drivers/virt/*
> > > >
> > > > Really? I'm now in charge of this directory too? That's news to me...
> > >
> > > This was suggested by Arnd, as he preferred putting the vboxguest driver
> > > under drivers/virt rather then drivers/misc. Note that currently there is
> > > only one .c file under drivers/virt: fsl_hypervisor.c
> >
> > Ok, but how about we wait until there is more than one file in here?
>
> That is fine by me.
>
> > And what happened to all of the other "virt" drivers, why are they not here?
>
> Some vmware drivers are currently under drivers/misc, Arnd's proposal was
> to move those to drivers/virt. virtio and hyperv have their own subsys
> dirs.
>
> > Perhaps using this directory isn't really a good idea?
>
> I started out with the same idea which is why v1 of my RFC posting of the
> vboxguest driver used drivers/misc, alternatively we could move the single
> driver currently under drivers/virt to drivers/misc and stop using
> drivers/virt.
>
> > I don't know...
>
> Arnd indicated he has a preference for using drivers/virt for vboxguest +
> the vmware drivers, I'm fine either way. This really is a bit of a bikeshed-
> ish discussion IMHO. So if you and/or Arnd pick one I will happily follow
> whatever you choose.
Ah, if we move the vmware ones there, I have no problem with it, I
missed that part of the discussion.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-28 14:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-25 11:56 [PATCH] MAINTAINERS: Add files under drivers/virt/* to CHAR and MISC DRIVERS section Hans de Goede
2017-08-25 13:10 ` Greg Kroah-Hartman
2017-08-25 13:11 ` Hans de Goede
2017-08-28 14:08 ` Greg Kroah-Hartman
2017-08-28 14:13 ` Hans de Goede
2017-08-28 14:26 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.