* [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input
@ 2017-08-28 14:55 Paul Kocialkowski
2017-08-28 15:18 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-08-29 12:08 ` [PATCH i-g-t] " Paul Kocialkowski
0 siblings, 2 replies; 5+ messages in thread
From: Paul Kocialkowski @ 2017-08-28 14:55 UTC (permalink / raw)
To: intel-gfx
Before capturing video, the Chamelium will always wait for the video
input to be stable (and perform the FSM if it was not). This means that
there is no need to explicitly do it beforehand.
When the receiver needs to be reset, the call will result in a timeout,
after which the follow-up call to capture the video will perform the FSM
that resets it. Skipping the explicit wait for video input stable allows
the Chamelium to perform the FSM directly, which saves valuable time.
Removing the associated call does not negatively impact the execution of
the CRC and frame comparison tests either.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
---
tests/chamelium.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/chamelium.c b/tests/chamelium.c
index 484bb537..e3d81357 100644
--- a/tests/chamelium.c
+++ b/tests/chamelium.c
@@ -474,9 +474,6 @@ enable_output(data_t *data,
if (chamelium_port_get_type(port) == DRM_MODE_CONNECTOR_VGA)
usleep(250000);
- chamelium_port_wait_video_input_stable(data->chamelium, port,
- HOTPLUG_TIMEOUT);
-
drmModeFreeConnector(connector);
}
--
2.14.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: warning for tests/chamelium: Let the Chamelium itself wait for a stable video input
2017-08-28 14:55 [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input Paul Kocialkowski
@ 2017-08-28 15:18 ` Patchwork
2017-08-29 12:08 ` [PATCH i-g-t] " Paul Kocialkowski
1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-08-28 15:18 UTC (permalink / raw)
To: Paul Kocialkowski; +Cc: intel-gfx
== Series Details ==
Series: tests/chamelium: Let the Chamelium itself wait for a stable video input
URL : https://patchwork.freedesktop.org/series/29432/
State : warning
== Summary ==
IGT patchset tested on top of latest successful build
60f6a12195395934f179d5ecc080353190d19a6c tests: chamelium: Eliminate reset when preparing output
with latest DRM-Tip kernel build CI_DRM_3011
5774a266e918 drm-tip: 2017y-08m-28d-14h-39m-13s UTC integration manifest
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-fail -> PASS (fi-glk-2a)
Subgroup basic-s4-devices:
skip -> PASS (fi-glk-2a)
Test gem_linear_blits:
Subgroup basic:
skip -> PASS (fi-glk-2a)
Test gem_render_linear_blits:
Subgroup basic:
skip -> PASS (fi-glk-2a)
Test gem_render_tiled_blits:
Subgroup basic:
skip -> PASS (fi-glk-2a)
Test gem_ringfill:
Subgroup basic-default:
skip -> PASS (fi-glk-2a)
Subgroup basic-default-interruptible:
skip -> PASS (fi-glk-2a)
Subgroup basic-default-forked:
skip -> PASS (fi-glk-2a)
Subgroup basic-default-fd:
skip -> PASS (fi-glk-2a)
Subgroup basic-default-hang:
skip -> PASS (fi-glk-2a)
Test gem_sync:
Subgroup basic-all:
skip -> PASS (fi-glk-2a)
Subgroup basic-each:
skip -> PASS (fi-glk-2a)
Subgroup basic-many-each:
skip -> PASS (fi-glk-2a)
Subgroup basic-store-all:
skip -> PASS (fi-glk-2a)
Subgroup basic-store-each:
skip -> PASS (fi-glk-2a)
Test gem_tiled_blits:
Subgroup basic:
skip -> PASS (fi-glk-2a)
Test gem_tiled_fence_blits:
Subgroup basic:
skip -> PASS (fi-glk-2a)
Test gem_wait:
Subgroup basic-busy-all:
skip -> PASS (fi-glk-2a)
Subgroup basic-wait-all:
skip -> PASS (fi-glk-2a)
Subgroup basic-await-all:
skip -> PASS (fi-glk-2a)
Test gem_workarounds:
Subgroup basic-read:
skip -> PASS (fi-glk-2a)
Test kms_busy:
Subgroup basic-flip-a:
skip -> PASS (fi-glk-2a)
Subgroup basic-flip-b:
skip -> PASS (fi-glk-2a)
Subgroup basic-flip-c:
skip -> PASS (fi-glk-2a)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
skip -> PASS (fi-glk-2a)
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-snb-2600) fdo#100215
skip -> PASS (fi-glk-2a)
Test kms_flip:
Subgroup basic-flip-vs-modeset:
pass -> SKIP (fi-skl-x1585l) fdo#101781
Test kms_frontbuffer_tracking:
Subgroup basic:
pass -> DMESG-WARN (fi-bdw-5557u)
incomplete -> PASS (fi-bsw-n3050) fdo#101707
fail -> PASS (fi-glk-2a)
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#101707 https://bugs.freedesktop.org/show_bug.cgi?id=101707
fi-bdw-5557u total:279 pass:267 dwarn:1 dfail:0 fail:0 skip:11 time:455s
fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:441s
fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:361s
fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:565s
fi-bwr-2160 total:279 pass:184 dwarn:0 dfail:0 fail:0 skip:95 time:252s
fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:517s
fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:534s
fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:516s
fi-elk-e7500 total:279 pass:230 dwarn:0 dfail:0 fail:0 skip:49 time:443s
fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:617s
fi-hsw-4770 total:279 pass:261 dwarn:0 dfail:0 fail:2 skip:16 time:450s
fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:422s
fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:427s
fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:509s
fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:476s
fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:481s
fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:604s
fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:595s
fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:523s
fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:471s
fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:480s
fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:490s
fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:448s
fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:489s
fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:551s
fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:404s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_112/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input
2017-08-28 14:55 [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input Paul Kocialkowski
2017-08-28 15:18 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2017-08-29 12:08 ` Paul Kocialkowski
2017-08-30 10:24 ` Paul Kocialkowski
1 sibling, 1 reply; 5+ messages in thread
From: Paul Kocialkowski @ 2017-08-29 12:08 UTC (permalink / raw)
To: Lyude; +Cc: intel-gfx
On Mon, 2017-08-28 at 17:55 +0300, Paul Kocialkowski wrote:
> Before capturing video, the Chamelium will always wait for the video
> input to be stable (and perform the FSM if it was not). This means
> that
> there is no need to explicitly do it beforehand.
>
> When the receiver needs to be reset, the call will result in a
> timeout,
> after which the follow-up call to capture the video will perform the
> FSM
> that resets it. Skipping the explicit wait for video input stable
> allows
> the Chamelium to perform the FSM directly, which saves valuable time.
>
> Removing the associated call does not negatively impact the execution
> of
> the CRC and frame comparison tests either.
I got an email from the mailer daemon indicating that this patch could
not be delivered to Lyude.
Lyude: did you receive the patch or should I resend it?
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
> tests/chamelium.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/chamelium.c b/tests/chamelium.c
> index 484bb537..e3d81357 100644
> --- a/tests/chamelium.c
> +++ b/tests/chamelium.c
> @@ -474,9 +474,6 @@ enable_output(data_t *data,
> if (chamelium_port_get_type(port) == DRM_MODE_CONNECTOR_VGA)
> usleep(250000);
>
> - chamelium_port_wait_video_input_stable(data->chamelium, port,
> - HOTPLUG_TIMEOUT);
> -
> drmModeFreeConnector(connector);
> }
>
--
Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input
2017-08-29 12:08 ` [PATCH i-g-t] " Paul Kocialkowski
@ 2017-08-30 10:24 ` Paul Kocialkowski
2017-08-30 18:47 ` Lyude Paul
0 siblings, 1 reply; 5+ messages in thread
From: Paul Kocialkowski @ 2017-08-30 10:24 UTC (permalink / raw)
To: Lyude; +Cc: intel-gfx
On Tue, 2017-08-29 at 15:08 +0300, Paul Kocialkowski wrote:
> On Mon, 2017-08-28 at 17:55 +0300, Paul Kocialkowski wrote:
> > Before capturing video, the Chamelium will always wait for the video
> > input to be stable (and perform the FSM if it was not). This means
> > that
> > there is no need to explicitly do it beforehand.
> >
> > When the receiver needs to be reset, the call will result in a
> > timeout,
> > after which the follow-up call to capture the video will perform the
> > FSM
> > that resets it. Skipping the explicit wait for video input stable
> > allows
> > the Chamelium to perform the FSM directly, which saves valuable
> > time.
> >
> > Removing the associated call does not negatively impact the
> > execution
> > of
> > the CRC and frame comparison tests either.
>
> I got an email from the mailer daemon indicating that this patch could
> not be delivered to Lyude.
>
> Lyude: did you receive the patch or should I resend it?
Either way, it's up at: https://patchwork.freedesktop.org/series/29432/
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> > ---
> > tests/chamelium.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/tests/chamelium.c b/tests/chamelium.c
> > index 484bb537..e3d81357 100644
> > --- a/tests/chamelium.c
> > +++ b/tests/chamelium.c
> > @@ -474,9 +474,6 @@ enable_output(data_t *data,
> > if (chamelium_port_get_type(port) ==
> > DRM_MODE_CONNECTOR_VGA)
> > usleep(250000);
> >
> > - chamelium_port_wait_video_input_stable(data->chamelium,
> > port,
> > - HOTPLUG_TIMEOUT);
> > -
> > drmModeFreeConnector(connector);
> > }
> >
--
Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input
2017-08-30 10:24 ` Paul Kocialkowski
@ 2017-08-30 18:47 ` Lyude Paul
0 siblings, 0 replies; 5+ messages in thread
From: Lyude Paul @ 2017-08-30 18:47 UTC (permalink / raw)
To: Paul Kocialkowski; +Cc: intel-gfx
On Wed, 2017-08-30 at 13:24 +0300, Paul Kocialkowski wrote:
> On Tue, 2017-08-29 at 15:08 +0300, Paul Kocialkowski wrote:
> > On Mon, 2017-08-28 at 17:55 +0300, Paul Kocialkowski wrote:
> > > Before capturing video, the Chamelium will always wait for the
> > > video
> > > input to be stable (and perform the FSM if it was not). This
> > > means
> > > that
> > > there is no need to explicitly do it beforehand.
> > >
> > > When the receiver needs to be reset, the call will result in a
> > > timeout,
> > > after which the follow-up call to capture the video will perform
> > > the
> > > FSM
> > > that resets it. Skipping the explicit wait for video input stable
> > > allows
> > > the Chamelium to perform the FSM directly, which saves valuable
> > > time.
> > >
> > > Removing the associated call does not negatively impact the
> > > execution
> > > of
> > > the CRC and frame comparison tests either.
> >
> > I got an email from the mailer daemon indicating that this patch
> > could
> > not be delivered to Lyude.
> >
> > Lyude: did you receive the patch or should I resend it?
>
> Either way, it's up at: https://patchwork.freedesktop.org/series/2943
> 2/
>
Yeah I didn't get it the first time but that's ok, weird though...
Anyway, R-B'd and pushed, thanks
> > > Signed-off-by: Paul Kocialkowski
> > > <paul.kocialkowski@linux.intel.com>
> > > ---
> > > tests/chamelium.c | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/tests/chamelium.c b/tests/chamelium.c
> > > index 484bb537..e3d81357 100644
> > > --- a/tests/chamelium.c
> > > +++ b/tests/chamelium.c
> > > @@ -474,9 +474,6 @@ enable_output(data_t *data,
> > > if (chamelium_port_get_type(port) ==
> > > DRM_MODE_CONNECTOR_VGA)
> > > usleep(250000);
> > >
> > > - chamelium_port_wait_video_input_stable(data->chamelium,
> > > port,
> > > - HOTPLUG_TIMEOUT);
> > > -
> > > drmModeFreeConnector(connector);
> > > }
> > >
--
Cheers,
Lyude
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-30 18:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 14:55 [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input Paul Kocialkowski
2017-08-28 15:18 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-08-29 12:08 ` [PATCH i-g-t] " Paul Kocialkowski
2017-08-30 10:24 ` Paul Kocialkowski
2017-08-30 18:47 ` Lyude Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.