* [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static
@ 2017-08-16 9:16 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-08-16 9:16 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The structure cht_wc_i2c_adap_driver is local to the source
and does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/i2c/busses/i2c-cht-wc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
index fe5caf70c7fe..01c94c918d4c 100644
--- a/drivers/i2c/busses/i2c-cht-wc.c
+++ b/drivers/i2c/busses/i2c-cht-wc.c
@@ -322,7 +322,7 @@ static struct platform_device_id cht_wc_i2c_adap_id_table[] = {
};
MODULE_DEVICE_TABLE(platform, cht_wc_i2c_adap_id_table);
-struct platform_driver cht_wc_i2c_adap_driver = {
+static struct platform_driver cht_wc_i2c_adap_driver = {
.probe = cht_wc_i2c_adap_i2c_probe,
.remove = cht_wc_i2c_adap_i2c_remove,
.driver = {
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static
@ 2017-08-16 9:16 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-08-16 9:16 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The structure cht_wc_i2c_adap_driver is local to the source
and does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/i2c/busses/i2c-cht-wc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
index fe5caf70c7fe..01c94c918d4c 100644
--- a/drivers/i2c/busses/i2c-cht-wc.c
+++ b/drivers/i2c/busses/i2c-cht-wc.c
@@ -322,7 +322,7 @@ static struct platform_device_id cht_wc_i2c_adap_id_table[] = {
};
MODULE_DEVICE_TABLE(platform, cht_wc_i2c_adap_id_table);
-struct platform_driver cht_wc_i2c_adap_driver = {
+static struct platform_driver cht_wc_i2c_adap_driver = {
.probe = cht_wc_i2c_adap_i2c_probe,
.remove = cht_wc_i2c_adap_i2c_remove,
.driver = {
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static
2017-08-16 9:16 ` Colin King
@ 2017-08-17 16:29 ` Wolfram Sang
-1 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-08-17 16:29 UTC (permalink / raw)
To: Colin King, Hans de Goede; +Cc: linux-i2c, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
On Wed, Aug 16, 2017 at 10:16:59AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure cht_wc_i2c_adap_driver is local to the source
> and does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
CCing Hans to ask him if he maybe wants to create a MAINTAINERS entry
for this driver, so he'll get CCed for such patches? :)
> ---
> drivers/i2c/busses/i2c-cht-wc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
> index fe5caf70c7fe..01c94c918d4c 100644
> --- a/drivers/i2c/busses/i2c-cht-wc.c
> +++ b/drivers/i2c/busses/i2c-cht-wc.c
> @@ -322,7 +322,7 @@ static struct platform_device_id cht_wc_i2c_adap_id_table[] = {
> };
> MODULE_DEVICE_TABLE(platform, cht_wc_i2c_adap_id_table);
>
> -struct platform_driver cht_wc_i2c_adap_driver = {
> +static struct platform_driver cht_wc_i2c_adap_driver = {
> .probe = cht_wc_i2c_adap_i2c_probe,
> .remove = cht_wc_i2c_adap_i2c_remove,
> .driver = {
> --
> 2.11.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static
@ 2017-08-17 16:29 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-08-17 16:29 UTC (permalink / raw)
To: Colin King, Hans de Goede; +Cc: linux-i2c, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
On Wed, Aug 16, 2017 at 10:16:59AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure cht_wc_i2c_adap_driver is local to the source
> and does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
CCing Hans to ask him if he maybe wants to create a MAINTAINERS entry
for this driver, so he'll get CCed for such patches? :)
> ---
> drivers/i2c/busses/i2c-cht-wc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
> index fe5caf70c7fe..01c94c918d4c 100644
> --- a/drivers/i2c/busses/i2c-cht-wc.c
> +++ b/drivers/i2c/busses/i2c-cht-wc.c
> @@ -322,7 +322,7 @@ static struct platform_device_id cht_wc_i2c_adap_id_table[] = {
> };
> MODULE_DEVICE_TABLE(platform, cht_wc_i2c_adap_id_table);
>
> -struct platform_driver cht_wc_i2c_adap_driver = {
> +static struct platform_driver cht_wc_i2c_adap_driver = {
> .probe = cht_wc_i2c_adap_i2c_probe,
> .remove = cht_wc_i2c_adap_i2c_remove,
> .driver = {
> --
> 2.11.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static
2017-08-16 9:16 ` Colin King
@ 2017-08-29 10:09 ` Wolfram Sang
-1 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-08-29 10:09 UTC (permalink / raw)
To: Colin King; +Cc: linux-i2c, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Wed, Aug 16, 2017 at 10:16:59AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure cht_wc_i2c_adap_driver is local to the source
> and does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static
@ 2017-08-29 10:09 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-08-29 10:09 UTC (permalink / raw)
To: Colin King; +Cc: linux-i2c, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Wed, Aug 16, 2017 at 10:16:59AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure cht_wc_i2c_adap_driver is local to the source
> and does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-29 10:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-16 9:16 [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static Colin King
2017-08-16 9:16 ` Colin King
2017-08-17 16:29 ` Wolfram Sang
2017-08-17 16:29 ` Wolfram Sang
2017-08-29 10:09 ` Wolfram Sang
2017-08-29 10:09 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.