All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen/build: Nuke include/{config, generated} during clean
@ 2017-08-28 18:20 Andrew Cooper
  2017-08-29  9:13 ` Jan Beulich
  2017-08-29 11:23 ` Wei Liu
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Cooper @ 2017-08-28 18:20 UTC (permalink / raw)
  To: Xen-devel
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
	Ian Jackson, Tim Deegan, Jan Beulich

Otherwise a stale generated Kconfig may still be used after a tree-wide clean.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Tim Deegan <tim@xen.org>
CC: Wei Liu <wei.liu2@citrix.com>
---
 xen/include/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/Makefile b/xen/include/Makefile
index 3a6fa0f..ba36fe5 100644
--- a/xen/include/Makefile
+++ b/xen/include/Makefile
@@ -144,5 +144,5 @@ all: $(BASEDIR)/include/asm-x86/cpuid-autogen.h
 endif
 
 clean::
-	rm -rf compat headers*.chk
+	rm -rf compat headers*.chk config generated
 	rm -f $(BASEDIR)/include/asm-x86/cpuid-autogen.h
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xen/build: Nuke include/{config, generated} during clean
  2017-08-28 18:20 [PATCH] xen/build: Nuke include/{config, generated} during clean Andrew Cooper
@ 2017-08-29  9:13 ` Jan Beulich
  2017-08-29 11:23 ` Wei Liu
  1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2017-08-29  9:13 UTC (permalink / raw)
  To: Andrew Cooper
  Cc: Stefano Stabellini, WeiLiu, George Dunlap, Tim Deegan,
	Ian Jackson, Xen-devel

>>> On 28.08.17 at 20:20, <andrew.cooper3@citrix.com> wrote:
> Otherwise a stale generated Kconfig may still be used after a tree-wide clean.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
with one minor request:

> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -144,5 +144,5 @@ all: $(BASEDIR)/include/asm-x86/cpuid-autogen.h
>  endif
>  
>  clean::
> -	rm -rf compat headers*.chk
> +	rm -rf compat headers*.chk config generated

Would you mind either keeping directories together or sorting
alphabetically (both of which will yield the same end result)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xen/build: Nuke include/{config, generated} during clean
  2017-08-28 18:20 [PATCH] xen/build: Nuke include/{config, generated} during clean Andrew Cooper
  2017-08-29  9:13 ` Jan Beulich
@ 2017-08-29 11:23 ` Wei Liu
  1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2017-08-29 11:23 UTC (permalink / raw)
  To: Andrew Cooper
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Tim Deegan,
	Ian Jackson, Xen-devel, Jan Beulich

On Mon, Aug 28, 2017 at 07:20:27PM +0100, Andrew Cooper wrote:
> Otherwise a stale generated Kconfig may still be used after a tree-wide clean.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-29 11:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 18:20 [PATCH] xen/build: Nuke include/{config, generated} during clean Andrew Cooper
2017-08-29  9:13 ` Jan Beulich
2017-08-29 11:23 ` Wei Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.