* [Qemu-devel] [PATCH v3] console: add question-mark escape operator
@ 2017-08-29 11:38 Alexander Graf
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2017-08-29 11:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Some termcaps (found using SLES11SP1) use [? sequences. According to man
console_codes (http://linux.die.net/man/4/console_codes) the question mark
is a nop and should simply be ignored.
This patch does exactly that, rendering screen output readable when
outputting guest serial consoles to the graphical console emulator.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
v1 -> v2:
- rebase to 2.10
v2 -> v3:
- fix coding style issues
---
ui/console.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/console.c b/ui/console.c
index d2d3534c49..37fee92001 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -880,8 +880,9 @@ static void console_putchar(QemuConsole *s, int ch)
} else {
if (s->nb_esc_params < MAX_ESC_PARAMS)
s->nb_esc_params++;
- if (ch == ';')
+ if (ch == ';' || ch == '?') {
break;
+ }
trace_console_putchar_csi(s->esc_params[0], s->esc_params[1],
ch, s->nb_esc_params);
s->state = TTY_STATE_NORM;
--
2.12.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] [PATCH v3] console: add question-mark escape operator
@ 2017-08-28 15:41 Alexander Graf
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2017-08-28 15:41 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Some termcaps (found using SLES11SP1) use [? sequences. According to man
console_codes (http://linux.die.net/man/4/console_codes) the question mark
is a nop and should simply be ignored.
This patch does exactly that, rendering screen output readable when
outputting guest serial consoles to the graphical console emulator.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
v1 -> v2:
- rebase to 2.10
v2 -> v3:
- fix coding style issues
---
ui/console.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/console.c b/ui/console.c
index d2d3534c49..37fee92001 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -880,8 +880,9 @@ static void console_putchar(QemuConsole *s, int ch)
} else {
if (s->nb_esc_params < MAX_ESC_PARAMS)
s->nb_esc_params++;
- if (ch == ';')
+ if (ch == ';' || ch == '?') {
break;
+ }
trace_console_putchar_csi(s->esc_params[0], s->esc_params[1],
ch, s->nb_esc_params);
s->state = TTY_STATE_NORM;
--
2.12.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-29 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-29 11:38 [Qemu-devel] [PATCH v3] console: add question-mark escape operator Alexander Graf
-- strict thread matches above, loose matches on Subject: below --
2017-08-28 15:41 Alexander Graf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.