From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org,
linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Christoffer Dall" <cdall@linaro.org>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"James Hogan" <james.hogan@imgtec.com>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Alexander Graf" <agraf@suse.com>
Subject: Re: [PATCH RFC v3 1/9] KVM: s390: optimize detection of started vcpus
Date: Tue, 29 Aug 2017 13:23:42 +0200 [thread overview]
Message-ID: <20170829132342.1ef25500.cohuck@redhat.com> (raw)
In-Reply-To: <67a8b09c-3e7a-943d-8684-f9ad6e70514b@redhat.com>
On Tue, 22 Aug 2017 13:31:27 +0200
David Hildenbrand <david@redhat.com> wrote:
> On 21.08.2017 22:35, Radim Krčmář wrote:
> > We can add a variable instead of scanning all online VCPUs to know how
> > many are started. We can't trivially tell which VCPU is the last one,
> > though.
>
> You could keep the started vcpus in a list. Then you might drop unsigned
> started_vcpus;
>
> No started vcpus: Start pointer NULL
> Single started vcpu: Only one element in the list (easy to check)
> > 1 started vcpus: More than one element int he list (easy to check)
I'm not sure the added complication of keeping a list buys us much
here: We only have the "look for the last vcpu not stopped" operation
for the 2->1 transition.
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mips@linux-mips.org, "James Hogan" <james.hogan@imgtec.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
"Christoffer Dall" <cdall@linaro.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Alexander Graf" <agraf@suse.com>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v3 1/9] KVM: s390: optimize detection of started vcpus
Date: Tue, 29 Aug 2017 13:23:42 +0200 [thread overview]
Message-ID: <20170829132342.1ef25500.cohuck@redhat.com> (raw)
In-Reply-To: <67a8b09c-3e7a-943d-8684-f9ad6e70514b@redhat.com>
On Tue, 22 Aug 2017 13:31:27 +0200
David Hildenbrand <david@redhat.com> wrote:
> On 21.08.2017 22:35, Radim Krčmář wrote:
> > We can add a variable instead of scanning all online VCPUs to know how
> > many are started. We can't trivially tell which VCPU is the last one,
> > though.
>
> You could keep the started vcpus in a list. Then you might drop unsigned
> started_vcpus;
>
> No started vcpus: Start pointer NULL
> Single started vcpu: Only one element in the list (easy to check)
> > 1 started vcpus: More than one element int he list (easy to check)
I'm not sure the added complication of keeping a list buys us much
here: We only have the "look for the last vcpu not stopped" operation
for the 2->1 transition.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: cohuck@redhat.com (Cornelia Huck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC v3 1/9] KVM: s390: optimize detection of started vcpus
Date: Tue, 29 Aug 2017 13:23:42 +0200 [thread overview]
Message-ID: <20170829132342.1ef25500.cohuck@redhat.com> (raw)
In-Reply-To: <67a8b09c-3e7a-943d-8684-f9ad6e70514b@redhat.com>
On Tue, 22 Aug 2017 13:31:27 +0200
David Hildenbrand <david@redhat.com> wrote:
> On 21.08.2017 22:35, Radim Kr?m?? wrote:
> > We can add a variable instead of scanning all online VCPUs to know how
> > many are started. We can't trivially tell which VCPU is the last one,
> > though.
>
> You could keep the started vcpus in a list. Then you might drop unsigned
> started_vcpus;
>
> No started vcpus: Start pointer NULL
> Single started vcpu: Only one element in the list (easy to check)
> > 1 started vcpus: More than one element int he list (easy to check)
I'm not sure the added complication of keeping a list buys us much
here: We only have the "look for the last vcpu not stopped" operation
for the 2->1 transition.
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org,
linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Christoffer Dall" <cdall@linaro.org>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"James Hogan" <james.hogan@imgtec.com>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Alexander Graf" <agraf@suse.com>
Subject: Re: [PATCH RFC v3 1/9] KVM: s390: optimize detection of started vcpus
Date: Tue, 29 Aug 2017 11:23:42 +0000 [thread overview]
Message-ID: <20170829132342.1ef25500.cohuck@redhat.com> (raw)
In-Reply-To: <67a8b09c-3e7a-943d-8684-f9ad6e70514b@redhat.com>
On Tue, 22 Aug 2017 13:31:27 +0200
David Hildenbrand <david@redhat.com> wrote:
> On 21.08.2017 22:35, Radim Krčmář wrote:
> > We can add a variable instead of scanning all online VCPUs to know how
> > many are started. We can't trivially tell which VCPU is the last one,
> > though.
>
> You could keep the started vcpus in a list. Then you might drop unsigned
> started_vcpus;
>
> No started vcpus: Start pointer NULL
> Single started vcpu: Only one element in the list (easy to check)
> > 1 started vcpus: More than one element int he list (easy to check)
I'm not sure the added complication of keeping a list buys us much
here: We only have the "look for the last vcpu not stopped" operation
for the 2->1 transition.
next prev parent reply other threads:[~2017-08-29 11:23 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 20:35 [PATCH RFC v3 0/9] KVM: allow dynamic kvm->vcpus array Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` [PATCH RFC v3 1/9] KVM: s390: optimize detection of started vcpus Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 7:26 ` Christian Borntraeger
2017-08-22 7:26 ` Christian Borntraeger
2017-08-22 7:26 ` Christian Borntraeger
2017-08-22 11:31 ` David Hildenbrand
2017-08-22 11:31 ` David Hildenbrand
2017-08-22 11:31 ` David Hildenbrand
2017-08-29 11:23 ` Cornelia Huck [this message]
2017-08-29 11:23 ` Cornelia Huck
2017-08-29 11:23 ` Cornelia Huck
2017-08-29 11:23 ` Cornelia Huck
2017-08-29 12:05 ` David Hildenbrand
2017-08-29 12:05 ` David Hildenbrand
2017-08-29 12:05 ` David Hildenbrand
2017-08-29 12:42 ` Cornelia Huck
2017-08-29 12:42 ` Cornelia Huck
2017-08-29 12:42 ` Cornelia Huck
2017-08-29 11:26 ` Cornelia Huck
2017-08-29 11:26 ` Cornelia Huck
2017-08-29 11:26 ` Cornelia Huck
2017-08-21 20:35 ` [PATCH RFC v3 2/9] KVM: arm/arm64: fix vcpu self-detection in vgic_v3_dispatch_sgi() Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 11:43 ` David Hildenbrand
2017-08-22 11:43 ` David Hildenbrand
2017-08-22 11:43 ` David Hildenbrand
2017-08-29 10:00 ` Christoffer Dall
2017-08-29 10:00 ` Christoffer Dall
2017-08-29 10:00 ` Christoffer Dall
2017-08-21 20:35 ` [PATCH RFC v3 3/9] KVM: remember position in kvm->vcpus array Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 11:44 ` David Hildenbrand
2017-08-22 11:44 ` David Hildenbrand
2017-08-22 11:44 ` David Hildenbrand
2017-08-29 11:30 ` Cornelia Huck
2017-08-29 11:30 ` Cornelia Huck
2017-08-29 11:30 ` Cornelia Huck
2017-08-21 20:35 ` [PATCH RFC v3 4/9] KVM: arm/arm64: use locking helpers in kvm_vgic_create() Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 11:51 ` David Hildenbrand
2017-08-22 11:51 ` David Hildenbrand
2017-08-22 11:51 ` David Hildenbrand
2017-08-29 10:00 ` Christoffer Dall
2017-08-29 10:00 ` Christoffer Dall
2017-08-29 10:00 ` Christoffer Dall
2017-08-21 20:35 ` [PATCH RFC v3 5/9] KVM: remove unused __KVM_HAVE_ARCH_VM_ALLOC Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` [PATCH RFC v3 6/9] KVM: rework kvm_vcpu_on_spin loop Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 14:06 ` David Hildenbrand
2017-08-22 14:06 ` David Hildenbrand
2017-08-22 14:06 ` David Hildenbrand
2017-08-29 15:24 ` Cornelia Huck
2017-08-29 15:24 ` Cornelia Huck
2017-08-29 15:24 ` Cornelia Huck
2017-08-21 20:35 ` [PATCH RFC v3 7/9] KVM: add kvm_free_vcpus and kvm_arch_free_vcpus Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-22 14:18 ` David Hildenbrand
2017-08-22 14:18 ` David Hildenbrand
2017-08-22 14:18 ` David Hildenbrand
2017-08-29 13:00 ` Cornelia Huck
2017-08-29 13:00 ` Cornelia Huck
2017-08-29 13:00 ` Cornelia Huck
2017-08-21 20:35 ` [PATCH RFC v3 8/9] KVM: implement kvm_for_each_vcpu with a list Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-29 9:58 ` Christoffer Dall
2017-08-29 9:58 ` Christoffer Dall
2017-08-29 9:58 ` Christoffer Dall
2017-08-21 20:35 ` [PATCH RFC v3 9/9] KVM: split kvm->vcpus into chunks Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
2017-08-21 20:35 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829132342.1ef25500.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.com \
--cc=borntraeger@de.ibm.com \
--cc=cdall@linaro.org \
--cc=david@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.