All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: marvell: armada-3720-db: Add vmmc regulator for SD slot
@ 2017-08-29 13:57 Gregory CLEMENT
  2017-09-19 14:09 ` Gregory CLEMENT
  0 siblings, 1 reply; 2+ messages in thread
From: Gregory CLEMENT @ 2017-08-29 13:57 UTC (permalink / raw)
  To: linux-arm-kernel

By adding this regulator, a proper reset is done during boot. Without
this, the UHS failed to be detected after a warm reboot when the SD card
remained in the slot, then it fallback to an HS.

Note that the vmcc is supported by the xenon driver only with the
following fix: "mmc: sdhci-xenon: add set_power callback".

Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
 arch/arm64/boot/dts/marvell/armada-3720-db.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
index 9df0f06ce607..e6e0f38ce6e1 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
@@ -94,6 +94,16 @@
 			  3300000 0x0>;
 		enable-active-high;
 	};
+
+	vcc_sd_reg2: regulator-vmcc {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_sd2";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		enable-active-high;
+		gpio = <&gpio_exp 4 GPIO_ACTIVE_HIGH>;
+	};
 };
 
 /* Gigabit module on CON19(V2.0)/CON21(V1.4) */
@@ -179,6 +189,7 @@
 	bus-width = <4>;
 	marvell,pad-type = "sd";
 	vqmmc-supply = <&vcc_sd_reg1>;
+	vmmc-supply = <&vcc_sd_reg2>;
 	status = "okay";
 };
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] arm64: dts: marvell: armada-3720-db: Add vmmc regulator for SD slot
  2017-08-29 13:57 [PATCH] arm64: dts: marvell: armada-3720-db: Add vmmc regulator for SD slot Gregory CLEMENT
@ 2017-09-19 14:09 ` Gregory CLEMENT
  0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2017-09-19 14:09 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,
 
 On mar., ao?t 29 2017, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> By adding this regulator, a proper reset is done during boot. Without
> this, the UHS failed to be detected after a warm reboot when the SD card
> remained in the slot, then it fallback to an HS.
>
> Note that the vmcc is supported by the xenon driver only with the
> following fix: "mmc: sdhci-xenon: add set_power callback".
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Applied on mvebu/dt64

Gregory
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-db.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> index 9df0f06ce607..e6e0f38ce6e1 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> @@ -94,6 +94,16 @@
>  			  3300000 0x0>;
>  		enable-active-high;
>  	};
> +
> +	vcc_sd_reg2: regulator-vmcc {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_sd2";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-boot-on;
> +		enable-active-high;
> +		gpio = <&gpio_exp 4 GPIO_ACTIVE_HIGH>;
> +	};
>  };
>  
>  /* Gigabit module on CON19(V2.0)/CON21(V1.4) */
> @@ -179,6 +189,7 @@
>  	bus-width = <4>;
>  	marvell,pad-type = "sd";
>  	vqmmc-supply = <&vcc_sd_reg1>;
> +	vmmc-supply = <&vcc_sd_reg2>;
>  	status = "okay";
>  };
>  
> -- 
> 2.14.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-19 14:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-29 13:57 [PATCH] arm64: dts: marvell: armada-3720-db: Add vmmc regulator for SD slot Gregory CLEMENT
2017-09-19 14:09 ` Gregory CLEMENT

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.