[PATCH 0/2] skd: Two additional patches for kernel v4.14

[PATCH 0/2] skd: Two additional patches for kernel v4.14

[Bart Van Assche]

Hello Jens,

Further code review of the skd driver resulted in two additional
patches. Please consider these for kernel v4.14.

Thanks,

Bart.

Bart Van Assche (2):
  skd: Remove blk_queue_bounce_limit() call
  skd: Let the block layer core choose .nr_requests

 drivers/block/skd_main.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.14.1

[PATCH 1/2] skd: Remove blk_queue_bounce_limit() call

[Bart Van Assche]

Since sTec s1120 devices support 64-bit DMA it is not necessary
to request data buffer bouncing. Hence remove the
blk_queue_bounce_limit() call.

Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
---
 drivers/block/skd_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 00a86252b3c5..f987ff601a4c 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -2844,7 +2844,6 @@ static int skd_cons_disk(struct skd_device *skdev)
 		rc = PTR_ERR(q);
 		goto err_out;
 	}
-	blk_queue_bounce_limit(q, BLK_BOUNCE_HIGH);
 	q->queuedata = skdev;
 	q->nr_requests = skd_max_queue_depth / 2;
 
-- 
2.14.1

[PATCH 2/2] skd: Let the block layer core choose .nr_requests

[Bart Van Assche]

Since blk_mq_init_queue() initializes .nr_requests to the tag set
size and since that value is a good default for the skd driver, do
not overwrite the value set by blk_mq_init_queue(). This change
doubles the default value of .nr_requests.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
---
 drivers/block/skd_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index f987ff601a4c..7cedb4295e9d 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -2845,7 +2845,6 @@ static int skd_cons_disk(struct skd_device *skdev)
 		goto err_out;
 	}
 	q->queuedata = skdev;
-	q->nr_requests = skd_max_queue_depth / 2;
 
 	skdev->queue = q;
 	disk->queue = q;
-- 
2.14.1

Re: [PATCH 0/2] skd: Two additional patches for kernel v4.14

[Jens Axboe]

On 08/29/2017 09:32 AM, Bart Van Assche wrote:
> Hello Jens,
> 
> Further code review of the skd driver resulted in two additional
> patches. Please consider these for kernel v4.14.

Looks good to me, applied, thanks.

-- 
Jens Axboe