* [Buildroot] [PATCH V2] bcusdk: eibd: drop local clock_gettime in USB backends
@ 2017-08-25 21:11 Kurt Van Dijck
2017-08-29 21:28 ` Thomas Petazzoni
2017-09-06 11:18 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Kurt Van Dijck @ 2017-08-25 21:11 UTC (permalink / raw)
To: buildroot
clock_gettime is defined locally, and calls pth_int_time, which
in turn calls clock_gettime.
The USB backend shouldn't overrule clock_gettime in the first place.
This patch fixes this endless recursion by removing the local defition.
Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
---
...endless-recursion-when-using-USB-backends.patch | 35 ++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 package/bcusdk/0002-eibd-fix-endless-recursion-when-using-USB-backends.patch
diff --git a/package/bcusdk/0002-eibd-fix-endless-recursion-when-using-USB-backends.patch b/package/bcusdk/0002-eibd-fix-endless-recursion-when-using-USB-backends.patch
new file mode 100644
index 0000000..3b90289
--- /dev/null
+++ b/package/bcusdk/0002-eibd-fix-endless-recursion-when-using-USB-backends.patch
@@ -0,0 +1,35 @@
+From 6bd1b4958e949d83468e053c34bf6c89d14d687a Mon Sep 17 00:00:00 2001
+From: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
+Date: Fri, 25 Aug 2017 23:01:14 +0200
+Subject: [PATCH] eibd: drop local clock_gettime in USB backends
+
+clock_gettime is defined locally, and calls pth_int_time, which
+in turn calls clock_gettime.
+The USB backend shouldn't overrule clock_gettime in the first place.
+This patch fixes this endless recursion by removing the local defition.
+
+Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
+---
+ eibd/usb/linux_usbfs.c | 6 ------
+ 1 file changed, 6 deletions(-)
+
+diff --git a/eibd/usb/linux_usbfs.c b/eibd/usb/linux_usbfs.c
+index c3ec410..957b908 100644
+--- a/eibd/usb/linux_usbfs.c
++++ b/eibd/usb/linux_usbfs.c
+@@ -52,12 +52,6 @@ int pthread_mutex_trylock(pthread_mutex_t *mutex)
+ return 0;
+ }
+
+-int clock_gettime(clockid_t clk_id, struct timespec *tp)
+-{
+- pth_int_time (tp);
+- return 0;
+-}
+-
+ /* sysfs vs usbfs:
+ * opening a usbfs node causes the device to be resumed, so we attempt to
+ * avoid this during enumeration.
+--
+1.8.5.rc3
+
--
1.8.5.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH V2] bcusdk: eibd: drop local clock_gettime in USB backends
2017-08-25 21:11 [Buildroot] [PATCH V2] bcusdk: eibd: drop local clock_gettime in USB backends Kurt Van Dijck
@ 2017-08-29 21:28 ` Thomas Petazzoni
2017-09-06 11:18 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-08-29 21:28 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 25 Aug 2017 23:11:10 +0200, Kurt Van Dijck wrote:
> clock_gettime is defined locally, and calls pth_int_time, which
> in turn calls clock_gettime.
> The USB backend shouldn't overrule clock_gettime in the first place.
> This patch fixes this endless recursion by removing the local defition.
>
> Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> ---
> ...endless-recursion-when-using-USB-backends.patch | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 package/bcusdk/0002-eibd-fix-endless-recursion-when-using-USB-backends.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH V2] bcusdk: eibd: drop local clock_gettime in USB backends
2017-08-25 21:11 [Buildroot] [PATCH V2] bcusdk: eibd: drop local clock_gettime in USB backends Kurt Van Dijck
2017-08-29 21:28 ` Thomas Petazzoni
@ 2017-09-06 11:18 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-09-06 11:18 UTC (permalink / raw)
To: buildroot
>>>>> "Kurt" == Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> writes:
> clock_gettime is defined locally, and calls pth_int_time, which
> in turn calls clock_gettime.
> The USB backend shouldn't overrule clock_gettime in the first place.
> This patch fixes this endless recursion by removing the local defition.
> Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-06 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-25 21:11 [Buildroot] [PATCH V2] bcusdk: eibd: drop local clock_gettime in USB backends Kurt Van Dijck
2017-08-29 21:28 ` Thomas Petazzoni
2017-09-06 11:18 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.