* Re: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support
2017-08-29 13:52 [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support Biju Das
@ 2017-08-29 14:58 ` Wolfram Sang
2017-08-29 15:05 ` Chris Paterson
2017-08-30 7:14 ` Simon Horman
2017-09-01 13:32 ` Ulf Hansson
2 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2017-08-29 14:58 UTC (permalink / raw)
To: Biju Das
Cc: Ulf Hansson, Wolfram Sang, Simon Horman, Magnus Damm,
Chris Paterson, Fabrizio Castro, Geert Uytterhoeven, linux-mmc,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]
On Tue, Aug 29, 2017 at 02:52:06PM +0100, Biju Das wrote:
> Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> DT binding patch for r8a7743/5 SoC is applied for mmc next. But the driver patch
> is still not applied for mmc next.So resending the driver patch.
Didn't Chris Paterson volunteer to write a new patch introducing Gen2
generic compatibles? Or did I misunderstand?
>
> This patch is compiled and tested against mmc/next.
>
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index 160fbb2..df44654 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -98,6 +98,8 @@
> { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
> { .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, },
> { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
> + { .compatible = "renesas,sdhi-r8a7743", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7745", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7791", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7792", .data = &of_rcar_gen2_compatible, },
> --
> 1.9.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support
2017-08-29 14:58 ` Wolfram Sang
@ 2017-08-29 15:05 ` Chris Paterson
2017-08-30 7:16 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Chris Paterson @ 2017-08-29 15:05 UTC (permalink / raw)
To: Wolfram Sang, Biju Das
Cc: Ulf Hansson, Wolfram Sang, Simon Horman, Magnus Damm,
Fabrizio Castro, Geert Uytterhoeven, linux-mmc,
linux-renesas-soc
> From: Wolfram Sang [mailto:wsa@the-dreams.de]
> Sent: 29 August 2017 15:59
>
> On Tue, Aug 29, 2017 at 02:52:06PM +0100, Biju Das wrote:
> > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is
> > identical to the R-Car Gen2 family.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > DT binding patch for r8a7743/5 SoC is applied for mmc next. But the
> > driver patch is still not applied for mmc next.So resending the driver patch.
>
> Didn't Chris Paterson volunteer to write a new patch introducing Gen2 generic
> compatibles? Or did I misunderstand?
I did :)
But after some off-ML discussion with Geert/Simon I decided to leave it to Simon as he's been doing a lot of similar work for all of the R-Car related drivers.
This may not happen immediately, and we already have the bindings/DT patches accepted based on this patch, hence the repost.
Sorry for the confusion!
>
> >
> > This patch is compiled and tested against mmc/next.
> >
> > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > index 160fbb2..df44654 100644
> > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > @@ -98,6 +98,8 @@
> > { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
> > { .compatible = "renesas,sdhi-r8a7778", .data =
> &of_rcar_gen1_compatible, },
> > { .compatible = "renesas,sdhi-r8a7779", .data =
> > &of_rcar_gen1_compatible, },
> > + { .compatible = "renesas,sdhi-r8a7743", .data =
> &of_rcar_gen2_compatible, },
> > + { .compatible = "renesas,sdhi-r8a7745", .data =
> > +&of_rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7790", .data =
> &of_rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7791", .data =
> &of_rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7792", .data =
> > &of_rcar_gen2_compatible, },
> > --
> > 1.9.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support
2017-08-29 15:05 ` Chris Paterson
@ 2017-08-30 7:16 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-08-30 7:16 UTC (permalink / raw)
To: Chris Paterson
Cc: Wolfram Sang, Biju Das, Ulf Hansson, Wolfram Sang, Magnus Damm,
Fabrizio Castro, Geert Uytterhoeven, linux-mmc,
linux-renesas-soc
On Tue, Aug 29, 2017 at 03:05:53PM +0000, Chris Paterson wrote:
>
>
> > From: Wolfram Sang [mailto:wsa@the-dreams.de]
> > Sent: 29 August 2017 15:59
> >
> > On Tue, Aug 29, 2017 at 02:52:06PM +0100, Biju Das wrote:
> > > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is
> > > identical to the R-Car Gen2 family.
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > ---
> > > DT binding patch for r8a7743/5 SoC is applied for mmc next. But the
> > > driver patch is still not applied for mmc next.So resending the driver patch.
> >
> > Didn't Chris Paterson volunteer to write a new patch introducing Gen2 generic
> > compatibles? Or did I misunderstand?
>
> I did :)
>
> But after some off-ML discussion with Geert/Simon I decided to leave it to Simon as he's been doing a lot of similar work for all of the R-Car related drivers.
>
> This may not happen immediately, and we already have the bindings/DT patches accepted based on this patch, hence the repost.
>
> Sorry for the confusion!
I confirm the above conversation.
In my experience rolling out fallback compat strings takes time as there
are often unexpected complications. Perhaps that is not the case here but
in my opinion it would be better if support for these new SoCs didn't have
an extra dependency. After all the goal of the fallback compat strings is
to make adding new SoCs easier not harder.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support
2017-08-29 13:52 [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support Biju Das
2017-08-29 14:58 ` Wolfram Sang
@ 2017-08-30 7:14 ` Simon Horman
2017-09-01 13:32 ` Ulf Hansson
2 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-08-30 7:14 UTC (permalink / raw)
To: Biju Das
Cc: Ulf Hansson, Wolfram Sang, Magnus Damm, Chris Paterson,
Fabrizio Castro, Geert Uytterhoeven, linux-mmc,
linux-renesas-soc
On Tue, Aug 29, 2017 at 02:52:06PM +0100, Biju Das wrote:
> Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> DT binding patch for r8a7743/5 SoC is applied for mmc next. But the driver patch
> is still not applied for mmc next.So resending the driver patch.
>
> This patch is compiled and tested against mmc/next.
>
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index 160fbb2..df44654 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -98,6 +98,8 @@
> { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
> { .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, },
> { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
> + { .compatible = "renesas,sdhi-r8a7743", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7745", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7791", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7792", .data = &of_rcar_gen2_compatible, },
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support
2017-08-29 13:52 [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support Biju Das
2017-08-29 14:58 ` Wolfram Sang
2017-08-30 7:14 ` Simon Horman
@ 2017-09-01 13:32 ` Ulf Hansson
2 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2017-09-01 13:32 UTC (permalink / raw)
To: Biju Das
Cc: Wolfram Sang, Simon Horman, Magnus Damm, Chris Paterson,
Fabrizio Castro, Geert Uytterhoeven, linux-mmc, Linux-Renesas
On 29 August 2017 at 15:52, Biju Das <biju.das@bp.renesas.com> wrote:
> Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> DT binding patch for r8a7743/5 SoC is applied for mmc next. But the driver patch
> is still not applied for mmc next.So resending the driver patch.
>
> This patch is compiled and tested against mmc/next.
>
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index 160fbb2..df44654 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -98,6 +98,8 @@
> { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
> { .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, },
> { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
> + { .compatible = "renesas,sdhi-r8a7743", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7745", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7791", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7792", .data = &of_rcar_gen2_compatible, },
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread