From: Mark Brown <broonie@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org, alexandre.torgue@st.com,
mark.rutland@arm.com, mcoquelin.stm32@gmail.com,
linux@armlinux.org.uk, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf
Date: Wed, 30 Aug 2017 16:02:49 +0100 [thread overview]
Message-ID: <20170830150249.5sofmjz3n2skzucq@sirena.org.uk> (raw)
In-Reply-To: <fd883990-cc87-f8cb-ebe7-5c4c4e51d6f6@st.com>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On Wed, Aug 30, 2017 at 11:11:24AM +0200, Fabrice Gasnier wrote:
> On 08/29/2017 08:57 PM, Mark Brown wrote:
> > On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote:
> >> +static int __init stm32_vrefbuf_init(void)
> >> +{
> >> + return platform_driver_register(&stm32_vrefbuf_driver);
> >> +}
> >> +subsys_initcall(stm32_vrefbuf_init);
> > Why is this at subsys_initcall()?
> Several consumers depend on it when it's being used, among which: STM32
> internal ADC and DAC, but also external components. Purpose is to ensure
> it's ready before these drivers gets probed, instead of being deferred.
> Is it ok to keep it ?
No, that's not OK - just let deferred probe handle it. The same thing
applies to all regulator usage.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf
Date: Wed, 30 Aug 2017 16:02:49 +0100 [thread overview]
Message-ID: <20170830150249.5sofmjz3n2skzucq@sirena.org.uk> (raw)
In-Reply-To: <fd883990-cc87-f8cb-ebe7-5c4c4e51d6f6@st.com>
On Wed, Aug 30, 2017 at 11:11:24AM +0200, Fabrice Gasnier wrote:
> On 08/29/2017 08:57 PM, Mark Brown wrote:
> > On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote:
> >> +static int __init stm32_vrefbuf_init(void)
> >> +{
> >> + return platform_driver_register(&stm32_vrefbuf_driver);
> >> +}
> >> +subsys_initcall(stm32_vrefbuf_init);
> > Why is this at subsys_initcall()?
> Several consumers depend on it when it's being used, among which: STM32
> internal ADC and DAC, but also external components. Purpose is to ensure
> it's ready before these drivers gets probed, instead of being deferred.
> Is it ok to keep it ?
No, that's not OK - just let deferred probe handle it. The same thing
applies to all regulator usage.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170830/d47026aa/attachment.sig>
next prev parent reply other threads:[~2017-08-30 15:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 12:58 [RESEND PATCH 0/3] Add support for STM32 vrefbuf regulator Fabrice Gasnier
2017-08-28 12:58 ` Fabrice Gasnier
2017-08-28 12:58 ` Fabrice Gasnier
2017-08-28 12:58 ` [RESEND PATCH 1/3] dt-bindings: regulator: Add STM32 Voltage Reference Buffer Fabrice Gasnier
2017-08-28 12:58 ` Fabrice Gasnier
2017-08-28 12:58 ` Fabrice Gasnier
2017-08-28 12:58 ` [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf Fabrice Gasnier
2017-08-28 12:58 ` Fabrice Gasnier
2017-08-28 12:58 ` Fabrice Gasnier
2017-08-29 18:57 ` Mark Brown
2017-08-29 18:57 ` Mark Brown
2017-08-30 9:11 ` Fabrice Gasnier
2017-08-30 9:11 ` Fabrice Gasnier
2017-08-30 9:11 ` Fabrice Gasnier
2017-08-30 15:02 ` Mark Brown [this message]
2017-08-30 15:02 ` Mark Brown
2017-08-30 15:23 ` Fabrice Gasnier
2017-08-30 15:23 ` Fabrice Gasnier
2017-08-30 15:23 ` Fabrice Gasnier
2017-08-28 12:58 ` [RESEND PATCH 3/3] ARM: dts: stm32: add vrefbuf to stm32h743 Fabrice Gasnier
2017-08-28 12:58 ` Fabrice Gasnier
2017-08-28 12:58 ` Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830150249.5sofmjz3n2skzucq@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.