All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers/fmc: make structure fmc_dbgfs_sdb_dump static and include fmc-private.h
@ 2017-08-30 17:42 ` Colin King
  0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2017-08-30 17:42 UTC (permalink / raw)
  To: Alessandro Rubini; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The structure fmc_dbgfs_sdb_dump is local to the source and does not
need to be in global scope, so make it static.  Also, fmc-private.h
should be included to fix up two sparse warnings on fmc_debug_init
and fmc_debug_exit.

Cleans up sparse warnings:
symbol 'fmc_dbgfs_sdb_dump' was not declared. Should it be static?
symbol 'fmc_debug_init' was not declared. Should it be static?
symbol 'fmc_debug_exit' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/fmc/fmc-debug.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
index 32930722770c..06c43c1e8899 100644
--- a/drivers/fmc/fmc-debug.c
+++ b/drivers/fmc/fmc-debug.c
@@ -17,6 +17,8 @@
 #include <linux/sdb.h>
 #include <linux/fmc-sdb.h>
 
+#include "fmc-private.h"
+
 #define FMC_DBG_SDB_DUMP "dump_sdb"
 
 static char *__strip_trailing_space(char *buf, char *str, int len)
@@ -140,7 +142,7 @@ static int fmc_sdb_dump_open(struct inode *inode, struct file *file)
 }
 
 
-const struct file_operations fmc_dbgfs_sdb_dump = {
+static const struct file_operations fmc_dbgfs_sdb_dump = {
 	.owner = THIS_MODULE,
 	.open  = fmc_sdb_dump_open,
 	.read = seq_read,
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] drivers/fmc: make structure fmc_dbgfs_sdb_dump static and include fmc-private.h
@ 2017-08-30 17:42 ` Colin King
  0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2017-08-30 17:42 UTC (permalink / raw)
  To: Alessandro Rubini; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The structure fmc_dbgfs_sdb_dump is local to the source and does not
need to be in global scope, so make it static.  Also, fmc-private.h
should be included to fix up two sparse warnings on fmc_debug_init
and fmc_debug_exit.

Cleans up sparse warnings:
symbol 'fmc_dbgfs_sdb_dump' was not declared. Should it be static?
symbol 'fmc_debug_init' was not declared. Should it be static?
symbol 'fmc_debug_exit' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/fmc/fmc-debug.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
index 32930722770c..06c43c1e8899 100644
--- a/drivers/fmc/fmc-debug.c
+++ b/drivers/fmc/fmc-debug.c
@@ -17,6 +17,8 @@
 #include <linux/sdb.h>
 #include <linux/fmc-sdb.h>
 
+#include "fmc-private.h"
+
 #define FMC_DBG_SDB_DUMP "dump_sdb"
 
 static char *__strip_trailing_space(char *buf, char *str, int len)
@@ -140,7 +142,7 @@ static int fmc_sdb_dump_open(struct inode *inode, struct file *file)
 }
 
 
-const struct file_operations fmc_dbgfs_sdb_dump = {
+static const struct file_operations fmc_dbgfs_sdb_dump = {
 	.owner = THIS_MODULE,
 	.open  = fmc_sdb_dump_open,
 	.read = seq_read,
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-30 17:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-30 17:42 [PATCH] drivers/fmc: make structure fmc_dbgfs_sdb_dump static and include fmc-private.h Colin King
2017-08-30 17:42 ` Colin King

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.