From: Ross Zwisler <ross.zwisler@linux.intel.com> To: fstests@vger.kernel.org, Eryu Guan <eguan@redhat.com> Cc: Theodore Ts'o <tytso@mit.edu>, linux-nvdimm@lists.01.org, Randy Dodgen <rdodgen@gmail.com>, Christoph Hellwig <hch@infradead.org>, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: [fstests v2] generic: add test for executables on read-only DAX mounts Date: Wed, 30 Aug 2017 22:09:10 -0600 [thread overview] Message-ID: <20170831040910.25015-1-ross.zwisler@linux.intel.com> (raw) In-Reply-To: <20170830105930.GE27835@eguan.usersys.redhat.com> This adds a regression test for the following kernel patch: commit 42d4a99b09cb ("ext4: fix fault handling when mounted with -o dax,ro") The above patch fixes an issue with ext4 where executables cannot be run on read-only filesystems mounted with the DAX option. This issue does not appear to be present in ext2 or XFS, as they both pass the test. I've also confirmed outside of the test that they are both indeed able to execute binaries on read-only DAX mounts. Thanks to Randy Dodgen for the bug report and reproduction steps. Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> Cc: Randy Dodgen <rdodgen@gmail.com> Cc: Christoph Hellwig <hch@infradead.org> Cc: Theodore Ts'o <tytso@mit.edu> --- Changes in v2: - A bunch of cleanup and simplifications from Eryu. --- tests/generic/451 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/451.out | 3 +++ tests/generic/group | 1 + 3 files changed, 77 insertions(+) create mode 100755 tests/generic/451 create mode 100644 tests/generic/451.out diff --git a/tests/generic/451 b/tests/generic/451 new file mode 100755 index 0000000..785c52e --- /dev/null +++ b/tests/generic/451 @@ -0,0 +1,73 @@ +#! /bin/bash +# FS QA Test 451 +# +# This is a regression test for kernel patch: +# commit 42d4a99b09cb ("ext4: fix fault handling when mounted with -o dax,ro") +# created by Ross Zwisler <ross.zwisler@linux.intel.com> +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Intel Corporation. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# Modify as appropriate. +_supported_fs generic +_supported_os Linux +_require_scratch + +# we need to be able to execute binaries on scratch +_exclude_scratch_mount_option "noexec" + +# real QA test starts here +# format and mount +_scratch_mkfs > $seqres.full 2>&1 +_scratch_mount >> $seqres.full 2>&1 + +LS=$(which ls --skip-alias --skip-functions) +SCRATCH_LS=$SCRATCH_MNT/ls_on_scratch +cp $LS $SCRATCH_LS + +$SCRATCH_LS $SCRATCH_LS | _filter_scratch + +_scratch_remount ro + +$SCRATCH_LS $SCRATCH_LS | _filter_scratch + +# success, all done +status=0 +exit diff --git a/tests/generic/451.out b/tests/generic/451.out new file mode 100644 index 0000000..70e3126 --- /dev/null +++ b/tests/generic/451.out @@ -0,0 +1,3 @@ +QA output created by 451 +SCRATCH_MNT/ls_on_scratch +SCRATCH_MNT/ls_on_scratch diff --git a/tests/generic/group b/tests/generic/group index 044ec3f..45f5789 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -453,3 +453,4 @@ 448 auto quick rw 449 auto quick acl enospc 450 auto quick rw +451 auto quick -- 2.9.5 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com> To: fstests@vger.kernel.org, Eryu Guan <eguan@redhat.com> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>, linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, Randy Dodgen <rdodgen@gmail.com>, Christoph Hellwig <hch@infradead.org>, Theodore Ts'o <tytso@mit.edu> Subject: [fstests v2] generic: add test for executables on read-only DAX mounts Date: Wed, 30 Aug 2017 22:09:10 -0600 [thread overview] Message-ID: <20170831040910.25015-1-ross.zwisler@linux.intel.com> (raw) In-Reply-To: <20170830105930.GE27835@eguan.usersys.redhat.com> This adds a regression test for the following kernel patch: commit 42d4a99b09cb ("ext4: fix fault handling when mounted with -o dax,ro") The above patch fixes an issue with ext4 where executables cannot be run on read-only filesystems mounted with the DAX option. This issue does not appear to be present in ext2 or XFS, as they both pass the test. I've also confirmed outside of the test that they are both indeed able to execute binaries on read-only DAX mounts. Thanks to Randy Dodgen for the bug report and reproduction steps. Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> Cc: Randy Dodgen <rdodgen@gmail.com> Cc: Christoph Hellwig <hch@infradead.org> Cc: Theodore Ts'o <tytso@mit.edu> --- Changes in v2: - A bunch of cleanup and simplifications from Eryu. --- tests/generic/451 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/451.out | 3 +++ tests/generic/group | 1 + 3 files changed, 77 insertions(+) create mode 100755 tests/generic/451 create mode 100644 tests/generic/451.out diff --git a/tests/generic/451 b/tests/generic/451 new file mode 100755 index 0000000..785c52e --- /dev/null +++ b/tests/generic/451 @@ -0,0 +1,73 @@ +#! /bin/bash +# FS QA Test 451 +# +# This is a regression test for kernel patch: +# commit 42d4a99b09cb ("ext4: fix fault handling when mounted with -o dax,ro") +# created by Ross Zwisler <ross.zwisler@linux.intel.com> +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Intel Corporation. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# Modify as appropriate. +_supported_fs generic +_supported_os Linux +_require_scratch + +# we need to be able to execute binaries on scratch +_exclude_scratch_mount_option "noexec" + +# real QA test starts here +# format and mount +_scratch_mkfs > $seqres.full 2>&1 +_scratch_mount >> $seqres.full 2>&1 + +LS=$(which ls --skip-alias --skip-functions) +SCRATCH_LS=$SCRATCH_MNT/ls_on_scratch +cp $LS $SCRATCH_LS + +$SCRATCH_LS $SCRATCH_LS | _filter_scratch + +_scratch_remount ro + +$SCRATCH_LS $SCRATCH_LS | _filter_scratch + +# success, all done +status=0 +exit diff --git a/tests/generic/451.out b/tests/generic/451.out new file mode 100644 index 0000000..70e3126 --- /dev/null +++ b/tests/generic/451.out @@ -0,0 +1,3 @@ +QA output created by 451 +SCRATCH_MNT/ls_on_scratch +SCRATCH_MNT/ls_on_scratch diff --git a/tests/generic/group b/tests/generic/group index 044ec3f..45f5789 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -453,3 +453,4 @@ 448 auto quick rw 449 auto quick acl enospc 450 auto quick rw +451 auto quick -- 2.9.5
next prev parent reply other threads:[~2017-08-31 4:07 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-22 22:24 [PATCH] Fix ext4 fault handling when mounted with -o dax,ro Randy Dodgen 2017-08-23 3:37 ` [PATCH v2] " rdodgen 2017-08-23 3:37 ` rdodgen 2017-08-23 16:38 ` Ross Zwisler 2017-08-23 16:38 ` Ross Zwisler 2017-08-23 20:11 ` Randy Dodgen 2017-08-23 20:11 ` Randy Dodgen 2017-08-23 21:26 ` [PATCH v3] " rdodgen 2017-08-23 21:26 ` rdodgen 2017-08-24 14:45 ` Jan Kara 2017-08-24 14:45 ` Jan Kara 2017-08-24 15:11 ` Ross Zwisler 2017-08-24 15:11 ` Ross Zwisler 2017-08-24 16:01 ` Christoph Hellwig 2017-08-24 16:01 ` Christoph Hellwig 2017-08-24 20:57 ` Theodore Ts'o 2017-08-24 20:57 ` Theodore Ts'o 2017-08-25 7:28 ` Christoph Hellwig 2017-08-25 7:28 ` Christoph Hellwig 2017-08-29 21:20 ` Christoph Hellwig 2017-08-29 21:20 ` Christoph Hellwig 2017-08-29 21:37 ` Ross Zwisler 2017-08-29 21:37 ` Ross Zwisler 2017-08-29 22:07 ` Randy Dodgen 2017-08-29 22:07 ` Randy Dodgen 2017-08-29 22:37 ` [fstests PATCH] generic: add test for executables on read-only DAX mounts Ross Zwisler 2017-08-29 22:37 ` Ross Zwisler 2017-08-30 10:59 ` Eryu Guan 2017-08-30 10:59 ` Eryu Guan 2017-08-31 4:01 ` Ross Zwisler 2017-08-31 4:01 ` Ross Zwisler 2017-08-31 4:01 ` Ross Zwisler 2017-08-31 4:09 ` Ross Zwisler [this message] 2017-08-31 4:09 ` [fstests v2] " Ross Zwisler 2017-08-30 14:51 ` [fstests PATCH] " Christoph Hellwig 2017-08-30 14:51 ` Christoph Hellwig 2017-08-30 14:51 ` Christoph Hellwig 2017-08-31 4:02 ` Ross Zwisler 2017-08-31 4:02 ` Ross Zwisler 2017-08-31 4:02 ` Ross Zwisler 2017-08-31 13:09 ` Christoph Hellwig 2017-08-31 13:09 ` Christoph Hellwig 2017-08-24 19:26 ` [PATCH v3] Fix ext4 fault handling when mounted with -o dax,ro Theodore Ts'o 2017-08-24 19:26 ` Theodore Ts'o
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170831040910.25015-1-ross.zwisler@linux.intel.com \ --to=ross.zwisler@linux.intel.com \ --cc=eguan@redhat.com \ --cc=fstests@vger.kernel.org \ --cc=hch@infradead.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=rdodgen@gmail.com \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.