Regression in next with gpiolib

Regression in next with gpiolib

[Tony Lindgren]

Hi Timur, Linus & Grygorii,

Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
querying its direction") caused a regression on at least pandaboard
es with booting hanging shortly after gpio init.

It seems to be that we're now calling request and free on all gpios
before they are properly configured?

I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
not calling omap_gpio_free() on them makes the system boot again.

These lines are used for the leds in omap4-panda-common.dtsi, and
omap_gpio_free() will by default set the unused lines for input
and bad things happen. I guess hardware failure could also happen
although I have not seen it here.

It seems a similar issue can exist on other platforms too,
so it's probably a good idea to revert this for now.

Any ideas on how we should fix this?

Regards,

Tony

Regression in next with gpiolib

[Tony Lindgren]

Hi Timur, Linus & Grygorii,

Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
querying its direction") caused a regression on at least pandaboard
es with booting hanging shortly after gpio init.

It seems to be that we're now calling request and free on all gpios
before they are properly configured?

I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
not calling omap_gpio_free() on them makes the system boot again.

These lines are used for the leds in omap4-panda-common.dtsi, and
omap_gpio_free() will by default set the unused lines for input
and bad things happen. I guess hardware failure could also happen
although I have not seen it here.

It seems a similar issue can exist on other platforms too,
so it's probably a good idea to revert this for now.

Any ideas on how we should fix this?

Regards,

Tony

Re: Regression in next with gpiolib

[Timur Tabi]

On 08/30/2017 04:41 PM, Tony Lindgren wrote:
> It seems to be that we're now calling request and free on all gpios
> before they are properly configured?

Yes, that's what my patch does.  At the time, it seemed like a good idea 
-- request the GPIO before touching its hardware.  But it appears that 
the 'request' function of some drivers also re-muxes the GPIO in order 
to honor the request.

The question is whether that's correct behavior.  I don't know.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

Regression in next with gpiolib

[Timur Tabi]

On 08/30/2017 04:41 PM, Tony Lindgren wrote:
> It seems to be that we're now calling request and free on all gpios
> before they are properly configured?

Yes, that's what my patch does.  At the time, it seemed like a good idea 
-- request the GPIO before touching its hardware.  But it appears that 
the 'request' function of some drivers also re-muxes the GPIO in order 
to honor the request.

The question is whether that's correct behavior.  I don't know.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: Regression in next with gpiolib

[Linus Walleij]

On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren <tony@atomide.com> wrote:

> Hi Timur, Linus & Grygorii,
>
> Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
> querying its direction") caused a regression on at least pandaboard
> es with booting hanging shortly after gpio init.
>
> It seems to be that we're now calling request and free on all gpios
> before they are properly configured?
>
> I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
> not calling omap_gpio_free() on them makes the system boot again.
>
> These lines are used for the leds in omap4-panda-common.dtsi, and
> omap_gpio_free() will by default set the unused lines for input
> and bad things happen. I guess hardware failure could also happen
> although I have not seen it here.
>
> It seems a similar issue can exist on other platforms too,
> so it's probably a good idea to revert this for now.

I reverted it for now.

Yours,
Linus Walleij

Re: Regression in next with gpiolib

[Linus Walleij]

On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren <tony@atomide.com> wrote:

> Hi Timur, Linus & Grygorii,
>
> Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
> querying its direction") caused a regression on at least pandaboard
> es with booting hanging shortly after gpio init.
>
> It seems to be that we're now calling request and free on all gpios
> before they are properly configured?
>
> I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
> not calling omap_gpio_free() on them makes the system boot again.
>
> These lines are used for the leds in omap4-panda-common.dtsi, and
> omap_gpio_free() will by default set the unused lines for input
> and bad things happen. I guess hardware failure could also happen
> although I have not seen it here.
>
> It seems a similar issue can exist on other platforms too,
> so it's probably a good idea to revert this for now.

I reverted it for now.

Yours,
Linus Walleij

Regression in next with gpiolib

[Linus Walleij]

On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren <tony@atomide.com> wrote:

> Hi Timur, Linus & Grygorii,
>
> Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
> querying its direction") caused a regression on at least pandaboard
> es with booting hanging shortly after gpio init.
>
> It seems to be that we're now calling request and free on all gpios
> before they are properly configured?
>
> I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
> not calling omap_gpio_free() on them makes the system boot again.
>
> These lines are used for the leds in omap4-panda-common.dtsi, and
> omap_gpio_free() will by default set the unused lines for input
> and bad things happen. I guess hardware failure could also happen
> although I have not seen it here.
>
> It seems a similar issue can exist on other platforms too,
> so it's probably a good idea to revert this for now.

I reverted it for now.

Yours,
Linus Walleij

Re: Regression in next with gpiolib

[Tony Lindgren]

* Linus Walleij <linus.walleij@linaro.org> [170830 22:59]:
> On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren <tony@atomide.com> wrote:
> 
> > Hi Timur, Linus & Grygorii,
> >
> > Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
> > querying its direction") caused a regression on at least pandaboard
> > es with booting hanging shortly after gpio init.
> >
> > It seems to be that we're now calling request and free on all gpios
> > before they are properly configured?
> >
> > I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
> > not calling omap_gpio_free() on them makes the system boot again.
> >
> > These lines are used for the leds in omap4-panda-common.dtsi, and
> > omap_gpio_free() will by default set the unused lines for input
> > and bad things happen. I guess hardware failure could also happen
> > although I have not seen it here.
> >
> > It seems a similar issue can exist on other platforms too,
> > so it's probably a good idea to revert this for now.
> 
> I reverted it for now.

OK thanks!

Tony

Re: Regression in next with gpiolib

[Tony Lindgren]

* Linus Walleij <linus.walleij@linaro.org> [170830 22:59]:
> On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren <tony@atomide.com> wrote:
> 
> > Hi Timur, Linus & Grygorii,
> >
> > Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
> > querying its direction") caused a regression on at least pandaboard
> > es with booting hanging shortly after gpio init.
> >
> > It seems to be that we're now calling request and free on all gpios
> > before they are properly configured?
> >
> > I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
> > not calling omap_gpio_free() on them makes the system boot again.
> >
> > These lines are used for the leds in omap4-panda-common.dtsi, and
> > omap_gpio_free() will by default set the unused lines for input
> > and bad things happen. I guess hardware failure could also happen
> > although I have not seen it here.
> >
> > It seems a similar issue can exist on other platforms too,
> > so it's probably a good idea to revert this for now.
> 
> I reverted it for now.

OK thanks!

Tony

Regression in next with gpiolib

[Tony Lindgren]

* Linus Walleij <linus.walleij@linaro.org> [170830 22:59]:
> On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren <tony@atomide.com> wrote:
> 
> > Hi Timur, Linus & Grygorii,
> >
> > Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
> > querying its direction") caused a regression on at least pandaboard
> > es with booting hanging shortly after gpio init.
> >
> > It seems to be that we're now calling request and free on all gpios
> > before they are properly configured?
> >
> > I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
> > not calling omap_gpio_free() on them makes the system boot again.
> >
> > These lines are used for the leds in omap4-panda-common.dtsi, and
> > omap_gpio_free() will by default set the unused lines for input
> > and bad things happen. I guess hardware failure could also happen
> > although I have not seen it here.
> >
> > It seems a similar issue can exist on other platforms too,
> > so it's probably a good idea to revert this for now.
> 
> I reverted it for now.

OK thanks!

Tony