From: Johannes Thumshirn <jthumshirn@suse.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
Oleksandr Natalenko <oleksandr@natalenko.name>
Subject: Re: [PATCH 4/9] blk-mq: only run hw queues for blk-mq
Date: Fri, 1 Sep 2017 10:16:34 +0200 [thread overview]
Message-ID: <20170901081634.gliggrnp3wlrysrv@linux-x5ow.site> (raw)
In-Reply-To: <20170831172728.15817-5-ming.lei@redhat.com>
Hi Ming,
On Fri, Sep 01, 2017 at 01:27:23AM +0800, Ming Lei wrote:
> - blk_mq_run_hw_queues(q, false);
> + if (q->mq_ops)
> + blk_mq_run_hw_queues(q, false);
What speaks against putting the if (q->mq_ops) directly into
blk_mq_run_hw_queues() so we can't accidently call it from the sq path?
Just an idea, no hard preferences here.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
Oleksandr Natalenko <oleksandr@natalenko.name>
Subject: Re: [PATCH 4/9] blk-mq: only run hw queues for blk-mq
Date: Fri, 1 Sep 2017 10:16:34 +0200 [thread overview]
Message-ID: <20170901081634.gliggrnp3wlrysrv@linux-x5ow.site> (raw)
In-Reply-To: <20170831172728.15817-5-ming.lei@redhat.com>
Hi Ming,
On Fri, Sep 01, 2017 at 01:27:23AM +0800, Ming Lei wrote:
> - blk_mq_run_hw_queues(q, false);
> + if (q->mq_ops)
> + blk_mq_run_hw_queues(q, false);
What speaks against putting the if (q->mq_ops) directly into
blk_mq_run_hw_queues() so we can't accidently call it from the sq path?
Just an idea, no hard preferences here.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-09-01 8:16 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 17:27 [PATCH 0/9] block/scsi: safe SCSI quiescing Ming Lei
2017-08-31 17:27 ` [PATCH 1/9] percpu-refcount: introduce percpu_ref_is_dead() Ming Lei
2017-08-31 23:07 ` Bart Van Assche
2017-08-31 23:07 ` Bart Van Assche
2017-09-01 3:49 ` Ming Lei
2017-09-01 13:59 ` Tejun Heo
2017-09-01 15:44 ` Bart Van Assche
2017-09-01 15:44 ` Bart Van Assche
2017-09-01 16:05 ` Ming Lei
2017-08-31 17:27 ` [PATCH 2/9] blk-mq: rename blk_mq_unfreeze_queue as blk_unfreeze_queue Ming Lei
2017-08-31 17:27 ` [PATCH 3/9] blk-mq: rename blk_mq_freeze_queue as blk_freeze_queue Ming Lei
2017-08-31 22:35 ` Bart Van Assche
2017-08-31 22:35 ` Bart Van Assche
2017-09-01 3:51 ` Ming Lei
2017-08-31 17:27 ` [PATCH 4/9] blk-mq: only run hw queues for blk-mq Ming Lei
2017-09-01 8:16 ` Johannes Thumshirn [this message]
2017-09-01 8:16 ` Johannes Thumshirn
2017-09-01 12:33 ` Ming Lei
2017-09-01 12:44 ` Johannes Thumshirn
2017-09-01 12:44 ` Johannes Thumshirn
2017-08-31 17:27 ` [PATCH 5/9] block: introduce blk_drain_queue() Ming Lei
2017-08-31 22:34 ` Bart Van Assche
2017-08-31 22:34 ` Bart Van Assche
2017-09-01 3:52 ` Ming Lei
2017-08-31 17:27 ` [PATCH 6/9] blk-mq: rename blk_mq_freeze_queue_wait as blk_freeze_queue_wait Ming Lei
2017-08-31 22:37 ` Bart Van Assche
2017-08-31 22:37 ` Bart Van Assche
2017-09-01 3:53 ` Ming Lei
2017-08-31 17:27 ` [PATCH 7/9] block: tracking request allocation with q_usage_counter Ming Lei
2017-08-31 17:27 ` [PATCH 8/9] block: allow to allocate req with REQF_PREEMPT when queue is frozen Ming Lei
2017-08-31 22:50 ` Bart Van Assche
2017-08-31 22:50 ` Bart Van Assche
2017-09-01 3:55 ` Ming Lei
2017-09-01 15:43 ` Bart Van Assche
2017-09-01 15:43 ` Bart Van Assche
2017-09-01 16:56 ` Ming Lei
2017-08-31 17:27 ` [PATCH 9/9] SCSI: freeze block queue when SCSI device is put into quiesce Ming Lei
2017-08-31 17:34 ` [PATCH 0/9] block/scsi: safe SCSI quiescing Oleksandr Natalenko
2017-08-31 17:34 ` Oleksandr Natalenko
2017-08-31 17:38 ` Ming Lei
2017-08-31 18:31 ` Oleksandr Natalenko
2017-08-31 18:31 ` Oleksandr Natalenko
2017-09-01 3:45 ` Ming Lei
2017-09-01 6:24 ` oleksandr
2017-09-01 6:30 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901081634.gliggrnp3wlrysrv@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.