* [Qemu-devel] [PATCH v2 0/3] docker: Add test-block
@ 2017-08-31 11:22 Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 1/3] docker: Use unconfined security profile Fam Zheng
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Fam Zheng @ 2017-08-31 11:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée
A few tweaks to the docker images and running commands allow us to run
qemu-iotests in the fedora container. This will be added to the patchew test
cases later.
v2: Add nettle-devel because a few iotest cases blindly assumes the support is
there.
Fam Zheng (3):
docker: Use unconfined security profile
docker: Add nettle-devel to fedora image
docker: Add test-block
tests/docker/Makefile.include | 1 +
tests/docker/dockerfiles/fedora.docker | 1 +
tests/docker/test-block | 21 +++++++++++++++++++++
3 files changed, 23 insertions(+)
create mode 100755 tests/docker/test-block
--
2.13.5
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH v2 1/3] docker: Use unconfined security profile
2017-08-31 11:22 [Qemu-devel] [PATCH v2 0/3] docker: Add test-block Fam Zheng
@ 2017-08-31 11:22 ` Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 2/3] docker: Add nettle-devel to fedora image Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 3/3] docker: Add test-block Fam Zheng
2 siblings, 0 replies; 14+ messages in thread
From: Fam Zheng @ 2017-08-31 11:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée
Some by default blocked syscalls are required to run tests for example
userfaultfd.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/Makefile.include | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index aaab1a4208..8ded838b20 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -145,6 +145,7 @@ docker-run: docker-qemu-src
$(call quiet-command, \
$(SRC_PATH)/tests/docker/docker.py run \
$(if $(NOUSER),,-u $(shell id -u)) -t \
+ --security-opt seccomp=unconfined \
$(if $V,,--rm) \
$(if $(DEBUG),-i,) \
$(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \
--
2.13.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH v2 2/3] docker: Add nettle-devel to fedora image
2017-08-31 11:22 [Qemu-devel] [PATCH v2 0/3] docker: Add test-block Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 1/3] docker: Use unconfined security profile Fam Zheng
@ 2017-08-31 11:22 ` Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 3/3] docker: Add test-block Fam Zheng
2 siblings, 0 replies; 14+ messages in thread
From: Fam Zheng @ 2017-08-31 11:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée
The LUKS cases in qemu-iotests requires this.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/dockerfiles/fedora.docker | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 4eaa8ed2a5..27e8201c54 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -3,6 +3,7 @@ ENV PACKAGES \
ccache git tar PyYAML sparse flex bison python2 bzip2 hostname \
glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
gcc gcc-c++ clang make perl which bc findutils libaio-devel \
+ nettle-devel \
mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
mingw32-gtk2 mingw32-gtk3 mingw32-gnutls mingw32-nettle mingw32-libtasn1 \
mingw32-libjpeg-turbo mingw32-libpng mingw32-curl mingw32-libssh2 \
--
2.13.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-08-31 11:22 [Qemu-devel] [PATCH v2 0/3] docker: Add test-block Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 1/3] docker: Use unconfined security profile Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 2/3] docker: Add nettle-devel to fedora image Fam Zheng
@ 2017-08-31 11:22 ` Fam Zheng
2017-08-31 16:06 ` Eric Blake
2017-08-31 16:18 ` Daniel P. Berrange
2 siblings, 2 replies; 14+ messages in thread
From: Fam Zheng @ 2017-08-31 11:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/test-block | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100755 tests/docker/test-block
diff --git a/tests/docker/test-block b/tests/docker/test-block
new file mode 100755
index 0000000000..20ef70538f
--- /dev/null
+++ b/tests/docker/test-block
@@ -0,0 +1,21 @@
+#!/bin/bash -e
+#
+# Run block test cases
+#
+# Copyright (c) 2017 Red Hat Inc.
+#
+# Authors:
+# Fam Zheng <famz@redhat.com>
+#
+# This work is licensed under the terms of the GNU GPL, version 2
+# or (at your option) any later version. See the COPYING file in
+# the top-level directory.
+
+. common.rc
+
+cd "$BUILD_DIR"
+
+build_qemu --target-list=x86_64-softmmu
+cd tests/qemu-iotests
+./check -raw
+./check -qcow2
--
2.13.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 3/3] docker: Add test-block Fam Zheng
@ 2017-08-31 16:06 ` Eric Blake
2017-08-31 16:31 ` Kashyap Chamarthy
2017-09-01 9:55 ` Fam Zheng
2017-08-31 16:18 ` Daniel P. Berrange
1 sibling, 2 replies; 14+ messages in thread
From: Eric Blake @ 2017-08-31 16:06 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Alex Bennée, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On 08/31/2017 06:22 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/docker/test-block | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100755 tests/docker/test-block
> +cd "$BUILD_DIR"
> +
> +build_qemu --target-list=x86_64-softmmu
> +cd tests/qemu-iotests
> +./check -raw
> +./check -qcow2
Should we also run ./check -nbd?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 3/3] docker: Add test-block Fam Zheng
2017-08-31 16:06 ` Eric Blake
@ 2017-08-31 16:18 ` Daniel P. Berrange
2017-08-31 16:21 ` Eric Blake
2017-09-01 8:22 ` Fam Zheng
1 sibling, 2 replies; 14+ messages in thread
From: Daniel P. Berrange @ 2017-08-31 16:18 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
On Thu, Aug 31, 2017 at 07:22:10PM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/docker/test-block | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100755 tests/docker/test-block
>
> diff --git a/tests/docker/test-block b/tests/docker/test-block
> new file mode 100755
> index 0000000000..20ef70538f
> --- /dev/null
> +++ b/tests/docker/test-block
> @@ -0,0 +1,21 @@
> +#!/bin/bash -e
> +#
> +# Run block test cases
> +#
> +# Copyright (c) 2017 Red Hat Inc.
> +#
> +# Authors:
> +# Fam Zheng <famz@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2
> +# or (at your option) any later version. See the COPYING file in
> +# the top-level directory.
> +
> +. common.rc
> +
> +cd "$BUILD_DIR"
> +
> +build_qemu --target-list=x86_64-softmmu
> +cd tests/qemu-iotests
> +./check -raw
> +./check -qcow2
Could you add 'check -luks' - it should be passing already with git
master. Ideally it wants password-less sudo enabled, but will skip
the appropriate test if that's not there.
'qcow' (v1) was also passing last time I checked, though it is
waaaaaay slow to run compared to qcow2, so I'd understand if you
were reluctant to turn that on due to speed
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-08-31 16:18 ` Daniel P. Berrange
@ 2017-08-31 16:21 ` Eric Blake
2017-08-31 16:36 ` Philippe Mathieu-Daudé
2017-09-01 8:22 ` Fam Zheng
1 sibling, 1 reply; 14+ messages in thread
From: Eric Blake @ 2017-08-31 16:21 UTC (permalink / raw)
To: Daniel P. Berrange, Fam Zheng
Cc: Alex Bennée, qemu-devel, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
On 08/31/2017 11:18 AM, Daniel P. Berrange wrote:
>
> 'qcow' (v1) was also passing last time I checked, though it is
> waaaaaay slow to run compared to qcow2, so I'd understand if you
> were reluctant to turn that on due to speed
Even './check -qcow -g quick' might be nicer than nothing, but that is
also slooooooow
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-08-31 16:06 ` Eric Blake
@ 2017-08-31 16:31 ` Kashyap Chamarthy
2017-09-01 9:55 ` Fam Zheng
1 sibling, 0 replies; 14+ messages in thread
From: Kashyap Chamarthy @ 2017-08-31 16:31 UTC (permalink / raw)
To: Eric Blake
Cc: Fam Zheng, qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
On Thu, Aug 31, 2017 at 11:06:55AM -0500, Eric Blake wrote:
> On 08/31/2017 06:22 AM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > tests/docker/test-block | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> > create mode 100755 tests/docker/test-block
>
>
> > +cd "$BUILD_DIR"
> > +
> > +build_qemu --target-list=x86_64-softmmu
> > +cd tests/qemu-iotests
> > +./check -raw
> > +./check -qcow2
>
> Should we also run ./check -nbd?
FWIW, yes, if it's not too onerous. Not least because many of the
NBD-using block layer features are important storage virtualization
features for management layers.
--
/kashyap
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-08-31 16:21 ` Eric Blake
@ 2017-08-31 16:36 ` Philippe Mathieu-Daudé
2017-09-01 7:06 ` Fam Zheng
0 siblings, 1 reply; 14+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-08-31 16:36 UTC (permalink / raw)
To: Eric Blake, Daniel P. Berrange, Fam Zheng
Cc: Alex Bennée, qemu-devel, Peter Maydell
On 08/31/2017 01:21 PM, Eric Blake wrote:
> On 08/31/2017 11:18 AM, Daniel P. Berrange wrote:
>>
>> 'qcow' (v1) was also passing last time I checked, though it is
>> waaaaaay slow to run compared to qcow2, so I'd understand if you
>> were reluctant to turn that on due to speed
>
> Even './check -qcow -g quick' might be nicer than nothing, but that is
> also slooooooow
What about having a daily job running it on /master? Better than running
it once before each release :)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-08-31 16:36 ` Philippe Mathieu-Daudé
@ 2017-09-01 7:06 ` Fam Zheng
0 siblings, 0 replies; 14+ messages in thread
From: Fam Zheng @ 2017-09-01 7:06 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eric Blake, Daniel P. Berrange, Peter Maydell, Alex Bennée,
qemu-devel
On Thu, 08/31 13:36, Philippe Mathieu-Daudé wrote:
> On 08/31/2017 01:21 PM, Eric Blake wrote:
> > On 08/31/2017 11:18 AM, Daniel P. Berrange wrote:
> > >
> > > 'qcow' (v1) was also passing last time I checked, though it is
> > > waaaaaay slow to run compared to qcow2, so I'd understand if you
> > > were reluctant to turn that on due to speed
> >
> > Even './check -qcow -g quick' might be nicer than nothing, but that is
> > also slooooooow
>
> What about having a daily job running it on /master? Better than running it
> once before each release :)
>
Can Shippable or Travis cover that?
Fam
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-08-31 16:18 ` Daniel P. Berrange
2017-08-31 16:21 ` Eric Blake
@ 2017-09-01 8:22 ` Fam Zheng
2017-09-01 9:22 ` Daniel P. Berrange
1 sibling, 1 reply; 14+ messages in thread
From: Fam Zheng @ 2017-09-01 8:22 UTC (permalink / raw)
To: Daniel P. Berrange
Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
On Thu, 08/31 17:18, Daniel P. Berrange wrote:
> Could you add 'check -luks' - it should be passing already with git
> master. Ideally it wants password-less sudo enabled, but will skip
> the appropriate test if that's not there.
I have this failure:
192 - output mismatch (see 192.out.bad)
--- /home/fam/work/qemu/tests/qemu-iotests/192.out 2017-08-31 15:12:00.044744485 +0800
+++ 192.out.bad 2017-09-01 16:21:34.908390978 +0800
@@ -1,7 +1,4 @@
QA output created by 192
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
-QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) nbd_server_start unix:TEST_DIR/nbd
-(qemu) nbd_server_add -w drive0
-(qemu) q
+QEMU_PROG: -drive format=luks,file=driver=luks,key-secret=keysec0,file.filename=TEST_DIR/t.luks,if=ide,id=drive0: Can't specify 'file' and 'filename' options at the same time
*** done
Failures: 192
Failed 1 of 1 tests
Fam
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-09-01 8:22 ` Fam Zheng
@ 2017-09-01 9:22 ` Daniel P. Berrange
0 siblings, 0 replies; 14+ messages in thread
From: Daniel P. Berrange @ 2017-09-01 9:22 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
On Fri, Sep 01, 2017 at 04:22:13PM +0800, Fam Zheng wrote:
> On Thu, 08/31 17:18, Daniel P. Berrange wrote:
> > Could you add 'check -luks' - it should be passing already with git
> > master. Ideally it wants password-less sudo enabled, but will skip
> > the appropriate test if that's not there.
>
> I have this failure:
urgh, someone broke it already :-( that's why we need to run tests
automatically :-) I'll see about a fix
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-08-31 16:06 ` Eric Blake
2017-08-31 16:31 ` Kashyap Chamarthy
@ 2017-09-01 9:55 ` Fam Zheng
2017-09-01 10:07 ` Daniel P. Berrange
1 sibling, 1 reply; 14+ messages in thread
From: Fam Zheng @ 2017-09-01 9:55 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
On Thu, 08/31 11:06, Eric Blake wrote:
> On 08/31/2017 06:22 AM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > tests/docker/test-block | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> > create mode 100755 tests/docker/test-block
>
>
> > +cd "$BUILD_DIR"
> > +
> > +build_qemu --target-list=x86_64-softmmu
> > +cd tests/qemu-iotests
> > +./check -raw
> > +./check -qcow2
>
> Should we also run ./check -nbd?
Yes, I can add it, and -g quick to all formats, so that the whole test is not
lagged too badly, and that writing "quick" tests is encouraged in some degree.
Fam
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block
2017-09-01 9:55 ` Fam Zheng
@ 2017-09-01 10:07 ` Daniel P. Berrange
0 siblings, 0 replies; 14+ messages in thread
From: Daniel P. Berrange @ 2017-09-01 10:07 UTC (permalink / raw)
To: Fam Zheng
Cc: Eric Blake, Alex Bennée, qemu-devel, Philippe Mathieu-Daudé
On Fri, Sep 01, 2017 at 05:55:52PM +0800, Fam Zheng wrote:
> On Thu, 08/31 11:06, Eric Blake wrote:
> > On 08/31/2017 06:22 AM, Fam Zheng wrote:
> > > Signed-off-by: Fam Zheng <famz@redhat.com>
> > > ---
> > > tests/docker/test-block | 21 +++++++++++++++++++++
> > > 1 file changed, 21 insertions(+)
> > > create mode 100755 tests/docker/test-block
> >
> >
> > > +cd "$BUILD_DIR"
> > > +
> > > +build_qemu --target-list=x86_64-softmmu
> > > +cd tests/qemu-iotests
> > > +./check -raw
> > > +./check -qcow2
> >
> > Should we also run ./check -nbd?
>
> Yes, I can add it, and -g quick to all formats, so that the whole test is not
> lagged too badly, and that writing "quick" tests is encouraged in some degree.
If you also add a "daily" test, you could make the daily one run all tests,
while the per-commit one just uses 'quick'.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-09-01 10:07 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 11:22 [Qemu-devel] [PATCH v2 0/3] docker: Add test-block Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 1/3] docker: Use unconfined security profile Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 2/3] docker: Add nettle-devel to fedora image Fam Zheng
2017-08-31 11:22 ` [Qemu-devel] [PATCH v2 3/3] docker: Add test-block Fam Zheng
2017-08-31 16:06 ` Eric Blake
2017-08-31 16:31 ` Kashyap Chamarthy
2017-09-01 9:55 ` Fam Zheng
2017-09-01 10:07 ` Daniel P. Berrange
2017-08-31 16:18 ` Daniel P. Berrange
2017-08-31 16:21 ` Eric Blake
2017-08-31 16:36 ` Philippe Mathieu-Daudé
2017-09-01 7:06 ` Fam Zheng
2017-09-01 8:22 ` Fam Zheng
2017-09-01 9:22 ` Daniel P. Berrange
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.