All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][staging-next] staging: typec: fusb302: make structure fusb302_psy_desc static
@ 2017-09-01 10:20 ` Colin King
  0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-09-01 10:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Guenter Roeck, Hans de Goede, Yueyao Zhu,
	Rui Miguel Silva, Guru Das Srinagesh, Frans Klaver, devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The const structure fusb302_psy_desc is local to the source and
does not need to be in global scope, so make it static.

Cleans up sparse warnings
symbol 'fusb302_psy_desc' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/typec/fusb302/fusb302.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
index cf6355f59cd9..fc6a3cf74eb3 100644
--- a/drivers/staging/typec/fusb302/fusb302.c
+++ b/drivers/staging/typec/fusb302/fusb302.c
@@ -1723,7 +1723,7 @@ static enum power_supply_property fusb302_psy_properties[] = {
 	POWER_SUPPLY_PROP_CURRENT_MAX,
 };
 
-const struct power_supply_desc fusb302_psy_desc = {
+static const struct power_supply_desc fusb302_psy_desc = {
 	.name		= "fusb302-typec-source",
 	.type		= POWER_SUPPLY_TYPE_USB_TYPE_C,
 	.properties	= fusb302_psy_properties,
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH][staging-next] staging: typec: fusb302: make structure fusb302_psy_desc static
@ 2017-09-01 10:20 ` Colin King
  0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-09-01 10:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Guenter Roeck, Hans de Goede, Yueyao Zhu,
	Rui Miguel Silva, Guru Das Srinagesh, Frans Klaver, devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The const structure fusb302_psy_desc is local to the source and
does not need to be in global scope, so make it static.

Cleans up sparse warnings
symbol 'fusb302_psy_desc' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/typec/fusb302/fusb302.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
index cf6355f59cd9..fc6a3cf74eb3 100644
--- a/drivers/staging/typec/fusb302/fusb302.c
+++ b/drivers/staging/typec/fusb302/fusb302.c
@@ -1723,7 +1723,7 @@ static enum power_supply_property fusb302_psy_properties[] = {
 	POWER_SUPPLY_PROP_CURRENT_MAX,
 };
 
-const struct power_supply_desc fusb302_psy_desc = {
+static const struct power_supply_desc fusb302_psy_desc = {
 	.name		= "fusb302-typec-source",
 	.type		= POWER_SUPPLY_TYPE_USB_TYPE_C,
 	.properties	= fusb302_psy_properties,
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH][staging-next] staging: typec: fusb302: make structure fusb302_psy_desc static
  2017-09-01 10:20 ` Colin King
@ 2017-09-01 14:20   ` Guenter Roeck
  -1 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2017-09-01 14:20 UTC (permalink / raw)
  To: Colin King
  Cc: Greg Kroah-Hartman, Hans de Goede, Yueyao Zhu, Rui Miguel Silva,
	Guru Das Srinagesh, Frans Klaver, devel, kernel-janitors,
	linux-kernel

On Fri, Sep 01, 2017 at 11:20:57AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The const structure fusb302_psy_desc is local to the source and
> does not need to be in global scope, so make it static.
> 
> Cleans up sparse warnings
> symbol 'fusb302_psy_desc' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/staging/typec/fusb302/fusb302.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
> index cf6355f59cd9..fc6a3cf74eb3 100644
> --- a/drivers/staging/typec/fusb302/fusb302.c
> +++ b/drivers/staging/typec/fusb302/fusb302.c
> @@ -1723,7 +1723,7 @@ static enum power_supply_property fusb302_psy_properties[] = {
>  	POWER_SUPPLY_PROP_CURRENT_MAX,
>  };
>  
> -const struct power_supply_desc fusb302_psy_desc = {
> +static const struct power_supply_desc fusb302_psy_desc = {
>  	.name		= "fusb302-typec-source",
>  	.type		= POWER_SUPPLY_TYPE_USB_TYPE_C,
>  	.properties	= fusb302_psy_properties,
> -- 
> 2.14.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH][staging-next] staging: typec: fusb302: make structure fusb302_psy_desc static
@ 2017-09-01 14:20   ` Guenter Roeck
  0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2017-09-01 14:20 UTC (permalink / raw)
  To: Colin King
  Cc: Greg Kroah-Hartman, Hans de Goede, Yueyao Zhu, Rui Miguel Silva,
	Guru Das Srinagesh, Frans Klaver, devel, kernel-janitors,
	linux-kernel

On Fri, Sep 01, 2017 at 11:20:57AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The const structure fusb302_psy_desc is local to the source and
> does not need to be in global scope, so make it static.
> 
> Cleans up sparse warnings
> symbol 'fusb302_psy_desc' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/staging/typec/fusb302/fusb302.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
> index cf6355f59cd9..fc6a3cf74eb3 100644
> --- a/drivers/staging/typec/fusb302/fusb302.c
> +++ b/drivers/staging/typec/fusb302/fusb302.c
> @@ -1723,7 +1723,7 @@ static enum power_supply_property fusb302_psy_properties[] = {
>  	POWER_SUPPLY_PROP_CURRENT_MAX,
>  };
>  
> -const struct power_supply_desc fusb302_psy_desc = {
> +static const struct power_supply_desc fusb302_psy_desc = {
>  	.name		= "fusb302-typec-source",
>  	.type		= POWER_SUPPLY_TYPE_USB_TYPE_C,
>  	.properties	= fusb302_psy_properties,
> -- 
> 2.14.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-01 14:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-01 10:20 [PATCH][staging-next] staging: typec: fusb302: make structure fusb302_psy_desc static Colin King
2017-09-01 10:20 ` Colin King
2017-09-01 14:20 ` Guenter Roeck
2017-09-01 14:20   ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.