All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/vtables: Fix typo
@ 2017-09-01 14:40 Thierry Reding
  2017-09-01 14:40 ` [PATCH 2/2] drm/atomic: Fix typo in kerneldoc Thierry Reding
  2017-09-01 16:51 ` [PATCH 1/2] drm/vtables: Fix typo Ville Syrjälä
  0 siblings, 2 replies; 4+ messages in thread
From: Thierry Reding @ 2017-09-01 14:40 UTC (permalink / raw)
  To: dri-devel

From: Thierry Reding <treding@nvidia.com>

The callback is named .atomic_check, not .atomc_check.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 include/drm/drm_modeset_helper_vtables.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
index c55cf3ff6847..16646c44b7df 100644
--- a/include/drm/drm_modeset_helper_vtables.h
+++ b/include/drm/drm_modeset_helper_vtables.h
@@ -314,7 +314,7 @@ struct drm_crtc_helper_funcs {
 	 * implementation in drm_atomic_helper_check().
 	 *
 	 * When using drm_atomic_helper_check_planes() this hook is called
-	 * after the &drm_plane_helper_funcs.atomc_check hook for planes, which
+	 * after the &drm_plane_helper_funcs.atomic_check hook for planes, which
 	 * allows drivers to assign shared resources requested by planes in this
 	 * callback here. For more complicated dependencies the driver can call
 	 * the provided check helpers multiple times until the computed state
-- 
2.13.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] drm/atomic: Fix typo in kerneldoc
  2017-09-01 14:40 [PATCH 1/2] drm/vtables: Fix typo Thierry Reding
@ 2017-09-01 14:40 ` Thierry Reding
  2017-09-01 16:51 ` [PATCH 1/2] drm/vtables: Fix typo Ville Syrjälä
  1 sibling, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2017-09-01 14:40 UTC (permalink / raw)
  To: dri-devel

From: Thierry Reding <treding@nvidia.com>

The for_each_crtc_in_state() is used to iterate over CRTCs rather than
connectors.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 include/drm/drm_atomic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index 8a5808eb5628..f73b663c1f76 100644
--- a/include/drm/drm_atomic.h
+++ b/include/drm/drm_atomic.h
@@ -643,7 +643,7 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p);
 		for_each_if (connector)
 
 /**
- * for_each_crtc_in_state - iterate over all connectors in an atomic update
+ * for_each_crtc_in_state - iterate over all CRTCs in an atomic update
  * @__state: &struct drm_atomic_state pointer
  * @crtc: &struct drm_crtc iteration cursor
  * @crtc_state: &struct drm_crtc_state iteration cursor
-- 
2.13.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] drm/vtables: Fix typo
  2017-09-01 14:40 [PATCH 1/2] drm/vtables: Fix typo Thierry Reding
  2017-09-01 14:40 ` [PATCH 2/2] drm/atomic: Fix typo in kerneldoc Thierry Reding
@ 2017-09-01 16:51 ` Ville Syrjälä
  2017-09-01 19:03   ` Thierry Reding
  1 sibling, 1 reply; 4+ messages in thread
From: Ville Syrjälä @ 2017-09-01 16:51 UTC (permalink / raw)
  To: Thierry Reding; +Cc: dri-devel

On Fri, Sep 01, 2017 at 04:40:41PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The callback is named .atomic_check, not .atomc_check.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

For the series
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  include/drm/drm_modeset_helper_vtables.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
> index c55cf3ff6847..16646c44b7df 100644
> --- a/include/drm/drm_modeset_helper_vtables.h
> +++ b/include/drm/drm_modeset_helper_vtables.h
> @@ -314,7 +314,7 @@ struct drm_crtc_helper_funcs {
>  	 * implementation in drm_atomic_helper_check().
>  	 *
>  	 * When using drm_atomic_helper_check_planes() this hook is called
> -	 * after the &drm_plane_helper_funcs.atomc_check hook for planes, which
> +	 * after the &drm_plane_helper_funcs.atomic_check hook for planes, which
>  	 * allows drivers to assign shared resources requested by planes in this
>  	 * callback here. For more complicated dependencies the driver can call
>  	 * the provided check helpers multiple times until the computed state
> -- 
> 2.13.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] drm/vtables: Fix typo
  2017-09-01 16:51 ` [PATCH 1/2] drm/vtables: Fix typo Ville Syrjälä
@ 2017-09-01 19:03   ` Thierry Reding
  0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2017-09-01 19:03 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 442 bytes --]

On Fri, Sep 01, 2017 at 07:51:41PM +0300, Ville Syrjälä wrote:
> On Fri, Sep 01, 2017 at 04:40:41PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > The callback is named .atomic_check, not .atomc_check.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> For the series
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Applied to drm-misc-next, thanks.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-09-01 19:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-01 14:40 [PATCH 1/2] drm/vtables: Fix typo Thierry Reding
2017-09-01 14:40 ` [PATCH 2/2] drm/atomic: Fix typo in kerneldoc Thierry Reding
2017-09-01 16:51 ` [PATCH 1/2] drm/vtables: Fix typo Ville Syrjälä
2017-09-01 19:03   ` Thierry Reding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.