[opkg-utils PATCH] opkg-build*: fix empty package name in error message

[opkg-utils PATCH] opkg-build*: fix empty package name in error message

[Adam Trhon]

When opkg-build detects illegal character in package name it prints an error
message with this name. Due to a wrong variable name the package name in the
error message is empty. The same error occurs in opkg-buildpackage as well.
This patch fixes both.

Signed-off-by: Adam Trhon <adam.trhon@tbs-biometrics.com>
---
 opkg-build        | 2 +-
 opkg-buildpackage | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/opkg-build b/opkg-build
index e02eaca..0fe513a 100755
--- a/opkg-build
+++ b/opkg-build
@@ -108,7 +108,7 @@ You probably want to chown these to a system user: " >&2
 	[ "$?" -ne 0 ] && PKG_ERROR=1
 
 	if echo $pkg | grep '[^a-z0-9.+-]'; then
-		echo "*** Error: Package name $name contains illegal characters, (other than [a-z0-9.+-])" >&2
+		echo "*** Error: Package name $pkg contains illegal characters, (other than [a-z0-9.+-])" >&2
 		PKG_ERROR=1;
 	fi
 
diff --git a/opkg-buildpackage b/opkg-buildpackage
index 719c9a5..b7c0e8c 100755
--- a/opkg-buildpackage
+++ b/opkg-buildpackage
@@ -66,7 +66,7 @@ pkg_appears_sane_control() {
 	required_field Description >/dev/null
 
 	if echo $pkg | grep '[^a-z0-9.+-]'; then
-		echo "opkg-build: Error: Package name $name contains illegal characters, (other than [a-z0-9.+-])"
+		echo "opkg-build: Error: Package name $pkg contains illegal characters, (other than [a-z0-9.+-])"
 		PKG_ERROR=1;
 	fi
 
-- 
2.14.1

Re: [opkg-devel] [opkg-utils PATCH] opkg-build*: fix empty package name in error message

[Alejandro del Castillo]

merged, thanks!

On 09/02/2017 11:23 AM, Adam Trhon wrote:
> When opkg-build detects illegal character in package name it prints an error
> message with this name. Due to a wrong variable name the package name in the
> error message is empty. The same error occurs in opkg-buildpackage as well.
> This patch fixes both.
> 
> Signed-off-by: Adam Trhon <adam.trhon@tbs-biometrics.com>
> ---
>  opkg-build        | 2 +-
>  opkg-buildpackage | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/opkg-build b/opkg-build
> index e02eaca..0fe513a 100755
> --- a/opkg-build
> +++ b/opkg-build
> @@ -108,7 +108,7 @@ You probably want to chown these to a system user: " >&2
>  	[ "$?" -ne 0 ] && PKG_ERROR=1
>  
>  	if echo $pkg | grep '[^a-z0-9.+-]'; then
> -		echo "*** Error: Package name $name contains illegal characters, (other than [a-z0-9.+-])" >&2
> +		echo "*** Error: Package name $pkg contains illegal characters, (other than [a-z0-9.+-])" >&2
>  		PKG_ERROR=1;
>  	fi
>  
> diff --git a/opkg-buildpackage b/opkg-buildpackage
> index 719c9a5..b7c0e8c 100755
> --- a/opkg-buildpackage
> +++ b/opkg-buildpackage
> @@ -66,7 +66,7 @@ pkg_appears_sane_control() {
>  	required_field Description >/dev/null
>  
>  	if echo $pkg | grep '[^a-z0-9.+-]'; then
> -		echo "opkg-build: Error: Package name $name contains illegal characters, (other than [a-z0-9.+-])"
> +		echo "opkg-build: Error: Package name $pkg contains illegal characters, (other than [a-z0-9.+-])"
>  		PKG_ERROR=1;
>  	fi
>  
> 

-- 
Cheers,

Alejandro