* [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks
@ 2017-09-03 13:16 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2017-09-03 13:16 UTC (permalink / raw)
To: Markus Mayer, bcm-kernel-feedback-list, Zhang Rui,
Eduardo Valentin, Brian Norris, Gregory Fong, Florian Fainelli,
linux-pm, linux-arm-kernel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The comparisons for integer low on low > INT_MAX and also
integer high > INT_MAX are never going to be true since an
int type cannot be greater than INT_MAX. Remove these redundant
checks.
Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
result (CONSTANT_EXPRESSION_RESULT)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
index 87b8e7a86ee3..bcb3945feea6 100644
--- a/drivers/thermal/broadcom/brcmstb_thermal.c
+++ b/drivers/thermal/broadcom/brcmstb_thermal.c
@@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
if (low) {
- if (low > INT_MAX)
- low = INT_MAX;
avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
} else {
@@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
}
if (high < ULONG_MAX) {
- if (high > INT_MAX)
- high = INT_MAX;
avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
} else {
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks
@ 2017-09-03 13:16 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2017-09-03 13:16 UTC (permalink / raw)
To: linux-arm-kernel
From: Colin Ian King <colin.king@canonical.com>
The comparisons for integer low on low > INT_MAX and also
integer high > INT_MAX are never going to be true since an
int type cannot be greater than INT_MAX. Remove these redundant
checks.
Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
result (CONSTANT_EXPRESSION_RESULT)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
index 87b8e7a86ee3..bcb3945feea6 100644
--- a/drivers/thermal/broadcom/brcmstb_thermal.c
+++ b/drivers/thermal/broadcom/brcmstb_thermal.c
@@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
if (low) {
- if (low > INT_MAX)
- low = INT_MAX;
avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
} else {
@@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
}
if (high < ULONG_MAX) {
- if (high > INT_MAX)
- high = INT_MAX;
avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
} else {
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks
@ 2017-09-03 13:16 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2017-09-03 13:16 UTC (permalink / raw)
To: linux-arm-kernel
From: Colin Ian King <colin.king@canonical.com>
The comparisons for integer low on low > INT_MAX and also
integer high > INT_MAX are never going to be true since an
int type cannot be greater than INT_MAX. Remove these redundant
checks.
Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
result (CONSTANT_EXPRESSION_RESULT)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
index 87b8e7a86ee3..bcb3945feea6 100644
--- a/drivers/thermal/broadcom/brcmstb_thermal.c
+++ b/drivers/thermal/broadcom/brcmstb_thermal.c
@@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
if (low) {
- if (low > INT_MAX)
- low = INT_MAX;
avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
} else {
@@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
}
if (high < ULONG_MAX) {
- if (high > INT_MAX)
- high = INT_MAX;
avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
} else {
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks
2017-09-03 13:16 ` Colin King
(?)
@ 2017-09-06 18:40 ` Brian Norris
-1 siblings, 0 replies; 9+ messages in thread
From: Brian Norris @ 2017-09-06 18:40 UTC (permalink / raw)
To: Colin King
Cc: Markus Mayer, bcm-kernel-feedback-list, Zhang Rui,
Eduardo Valentin, Gregory Fong, Florian Fainelli, linux-pm,
linux-arm-kernel, kernel-janitors, linux-kernel, Dan Carpenter
Hi,
On Sun, Sep 03, 2017 at 02:16:19PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The comparisons for integer low on low > INT_MAX and also
> integer high > INT_MAX are never going to be true since an
> int type cannot be greater than INT_MAX. Remove these redundant
> checks.
>
> Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
> result (CONSTANT_EXPRESSION_RESULT)")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
> index 87b8e7a86ee3..bcb3945feea6 100644
> --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> @@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
>
> if (low) {
> - if (low > INT_MAX)
> - low = INT_MAX;
> avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
> avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
> } else {
> @@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> }
>
> if (high < ULONG_MAX) {
Dan's robots noticed that the above condition is not useful either (on
architectures where INT_MAX < ULONG_MAX -- i.e., all?), since 'high' is
'int', not 'unsigned long'.
Should probably fix that
s/ULONG_MAX/INT_MAX/
?
Brian
> - if (high > INT_MAX)
> - high = INT_MAX;
> avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
> avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
> } else {
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks
@ 2017-09-06 18:40 ` Brian Norris
0 siblings, 0 replies; 9+ messages in thread
From: Brian Norris @ 2017-09-06 18:40 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Sun, Sep 03, 2017 at 02:16:19PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The comparisons for integer low on low > INT_MAX and also
> integer high > INT_MAX are never going to be true since an
> int type cannot be greater than INT_MAX. Remove these redundant
> checks.
>
> Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
> result (CONSTANT_EXPRESSION_RESULT)")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
> index 87b8e7a86ee3..bcb3945feea6 100644
> --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> @@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
>
> if (low) {
> - if (low > INT_MAX)
> - low = INT_MAX;
> avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
> avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
> } else {
> @@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> }
>
> if (high < ULONG_MAX) {
Dan's robots noticed that the above condition is not useful either (on
architectures where INT_MAX < ULONG_MAX -- i.e., all?), since 'high' is
'int', not 'unsigned long'.
Should probably fix that
s/ULONG_MAX/INT_MAX/
?
Brian
> - if (high > INT_MAX)
> - high = INT_MAX;
> avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
> avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
> } else {
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks
@ 2017-09-06 18:40 ` Brian Norris
0 siblings, 0 replies; 9+ messages in thread
From: Brian Norris @ 2017-09-06 18:40 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Sun, Sep 03, 2017 at 02:16:19PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The comparisons for integer low on low > INT_MAX and also
> integer high > INT_MAX are never going to be true since an
> int type cannot be greater than INT_MAX. Remove these redundant
> checks.
>
> Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
> result (CONSTANT_EXPRESSION_RESULT)")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
> index 87b8e7a86ee3..bcb3945feea6 100644
> --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> @@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
>
> if (low) {
> - if (low > INT_MAX)
> - low = INT_MAX;
> avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
> avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
> } else {
> @@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> }
>
> if (high < ULONG_MAX) {
Dan's robots noticed that the above condition is not useful either (on
architectures where INT_MAX < ULONG_MAX -- i.e., all?), since 'high' is
'int', not 'unsigned long'.
Should probably fix that
s/ULONG_MAX/INT_MAX/
?
Brian
> - if (high > INT_MAX)
> - high = INT_MAX;
> avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
> avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
> } else {
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks
2017-09-06 18:40 ` Brian Norris
(?)
@ 2017-09-08 2:59 ` Eduardo Valentin
-1 siblings, 0 replies; 9+ messages in thread
From: Eduardo Valentin @ 2017-09-08 2:59 UTC (permalink / raw)
To: Brian Norris
Cc: Colin King, Markus Mayer, bcm-kernel-feedback-list, Zhang Rui,
Gregory Fong, Florian Fainelli, linux-pm, linux-arm-kernel,
kernel-janitors, linux-kernel, Dan Carpenter
Hello,
On Wed, Sep 06, 2017 at 11:40:46AM -0700, Brian Norris wrote:
> Hi,
>
> On Sun, Sep 03, 2017 at 02:16:19PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The comparisons for integer low on low > INT_MAX and also
> > integer high > INT_MAX are never going to be true since an
> > int type cannot be greater than INT_MAX. Remove these redundant
> > checks.
> >
> > Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
> > result (CONSTANT_EXPRESSION_RESULT)")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
> > index 87b8e7a86ee3..bcb3945feea6 100644
> > --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> > +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> > @@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> > dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
> >
> > if (low) {
> > - if (low > INT_MAX)
> > - low = INT_MAX;
> > avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
> > avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
> > } else {
> > @@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> > }
> >
> > if (high < ULONG_MAX) {
>
> Dan's robots noticed that the above condition is not useful either (on
> architectures where INT_MAX < ULONG_MAX -- i.e., all?), since 'high' is
> 'int', not 'unsigned long'.
>
> Should probably fix that
>
> s/ULONG_MAX/INT_MAX/
Yeah, that would probably make sense. I might be also the case that the
driver was considering long because that was the type used to represent
temperature some time back in the thermal subsystem. So, the limits on
the driver may be outdated.
>
> ?
>
> Brian
>
> > - if (high > INT_MAX)
> > - high = INT_MAX;
> > avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
> > avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
> > } else {
> > --
> > 2.14.1
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks
@ 2017-09-08 2:59 ` Eduardo Valentin
0 siblings, 0 replies; 9+ messages in thread
From: Eduardo Valentin @ 2017-09-08 2:59 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Wed, Sep 06, 2017 at 11:40:46AM -0700, Brian Norris wrote:
> Hi,
>
> On Sun, Sep 03, 2017 at 02:16:19PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The comparisons for integer low on low > INT_MAX and also
> > integer high > INT_MAX are never going to be true since an
> > int type cannot be greater than INT_MAX. Remove these redundant
> > checks.
> >
> > Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
> > result (CONSTANT_EXPRESSION_RESULT)")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
> > index 87b8e7a86ee3..bcb3945feea6 100644
> > --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> > +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> > @@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> > dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
> >
> > if (low) {
> > - if (low > INT_MAX)
> > - low = INT_MAX;
> > avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
> > avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
> > } else {
> > @@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> > }
> >
> > if (high < ULONG_MAX) {
>
> Dan's robots noticed that the above condition is not useful either (on
> architectures where INT_MAX < ULONG_MAX -- i.e., all?), since 'high' is
> 'int', not 'unsigned long'.
>
> Should probably fix that
>
> s/ULONG_MAX/INT_MAX/
Yeah, that would probably make sense. I might be also the case that the
driver was considering long because that was the type used to represent
temperature some time back in the thermal subsystem. So, the limits on
the driver may be outdated.
>
> ?
>
> Brian
>
> > - if (high > INT_MAX)
> > - high = INT_MAX;
> > avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
> > avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
> > } else {
> > --
> > 2.14.1
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks
@ 2017-09-08 2:59 ` Eduardo Valentin
0 siblings, 0 replies; 9+ messages in thread
From: Eduardo Valentin @ 2017-09-08 2:59 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Wed, Sep 06, 2017 at 11:40:46AM -0700, Brian Norris wrote:
> Hi,
>
> On Sun, Sep 03, 2017 at 02:16:19PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The comparisons for integer low on low > INT_MAX and also
> > integer high > INT_MAX are never going to be true since an
> > int type cannot be greater than INT_MAX. Remove these redundant
> > checks.
> >
> > Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect
> > result (CONSTANT_EXPRESSION_RESULT)")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/thermal/broadcom/brcmstb_thermal.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
> > index 87b8e7a86ee3..bcb3945feea6 100644
> > --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> > +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> > @@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> > dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high);
> >
> > if (low) {
> > - if (low > INT_MAX)
> > - low = INT_MAX;
> > avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low);
> > avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1);
> > } else {
> > @@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high)
> > }
> >
> > if (high < ULONG_MAX) {
>
> Dan's robots noticed that the above condition is not useful either (on
> architectures where INT_MAX < ULONG_MAX -- i.e., all?), since 'high' is
> 'int', not 'unsigned long'.
>
> Should probably fix that
>
> s/ULONG_MAX/INT_MAX/
Yeah, that would probably make sense. I might be also the case that the
driver was considering long because that was the type used to represent
temperature some time back in the thermal subsystem. So, the limits on
the driver may be outdated.
>
> ?
>
> Brian
>
> > - if (high > INT_MAX)
> > - high = INT_MAX;
> > avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high);
> > avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1);
> > } else {
> > --
> > 2.14.1
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-09-08 2:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-03 13:16 [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks Colin King
2017-09-03 13:16 ` Colin King
2017-09-03 13:16 ` Colin King
2017-09-06 18:40 ` Brian Norris
2017-09-06 18:40 ` Brian Norris
2017-09-06 18:40 ` Brian Norris
2017-09-08 2:59 ` Eduardo Valentin
2017-09-08 2:59 ` Eduardo Valentin
2017-09-08 2:59 ` Eduardo Valentin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.