* [U-Boot] [PATCH] crypto/fsl: fix obj-yy in Makefile
@ 2017-09-03 17:17 Clemens Gruber
2017-09-03 17:23 ` Fabio Estevam
2017-09-04 13:05 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Clemens Gruber @ 2017-09-03 17:17 UTC (permalink / raw)
To: u-boot
When enabling CONFIG_CMD_BLOB and/or CONFIG_CMD_DEKBLOB, the build fails
with a linker error:
...
LD u-boot
arch/arm/mach-imx/built-in.o: In function `blob_encap_dek':
/home/clemens/dev/u-boot/arch/arm/mach-imx/cmd_dek.c:46: undefined
reference to `blob_dek'
This is due to an error in the Makefile, resulting in obj-yy/obj-yn/..
and fsl_blob.o is therefore not linked.
Fix it by splitting it up into two obj-y lines.
Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
---
drivers/crypto/fsl/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/fsl/Makefile b/drivers/crypto/fsl/Makefile
index fd736cf3be..ea878e1822 100644
--- a/drivers/crypto/fsl/Makefile
+++ b/drivers/crypto/fsl/Makefile
@@ -6,5 +6,6 @@
obj-y += sec.o
obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o
-obj-$(CONFIG_CMD_BLOB)$(CONFIG_CMD_DEKBLOB) += fsl_blob.o
+obj-$(CONFIG_CMD_BLOB) += fsl_blob.o
+obj-$(CONFIG_CMD_DEKBLOB) += fsl_blob.o
obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] crypto/fsl: fix obj-yy in Makefile
2017-09-03 17:17 [U-Boot] [PATCH] crypto/fsl: fix obj-yy in Makefile Clemens Gruber
@ 2017-09-03 17:23 ` Fabio Estevam
2017-09-04 13:05 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2017-09-03 17:23 UTC (permalink / raw)
To: u-boot
On Sun, Sep 3, 2017 at 2:17 PM, Clemens Gruber
<clemens.gruber@pqgruber.com> wrote:
> When enabling CONFIG_CMD_BLOB and/or CONFIG_CMD_DEKBLOB, the build fails
> with a linker error:
> ...
> LD u-boot
> arch/arm/mach-imx/built-in.o: In function `blob_encap_dek':
> /home/clemens/dev/u-boot/arch/arm/mach-imx/cmd_dek.c:46: undefined
> reference to `blob_dek'
>
> This is due to an error in the Makefile, resulting in obj-yy/obj-yn/..
> and fsl_blob.o is therefore not linked.
>
> Fix it by splitting it up into two obj-y lines.
>
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] crypto/fsl: fix obj-yy in Makefile
2017-09-03 17:17 [U-Boot] [PATCH] crypto/fsl: fix obj-yy in Makefile Clemens Gruber
2017-09-03 17:23 ` Fabio Estevam
@ 2017-09-04 13:05 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-09-04 13:05 UTC (permalink / raw)
To: u-boot
On Sun, Sep 03, 2017 at 07:17:10PM +0200, Clemens Gruber wrote:
> When enabling CONFIG_CMD_BLOB and/or CONFIG_CMD_DEKBLOB, the build fails
> with a linker error:
> ...
> LD u-boot
> arch/arm/mach-imx/built-in.o: In function `blob_encap_dek':
> /home/clemens/dev/u-boot/arch/arm/mach-imx/cmd_dek.c:46: undefined
> reference to `blob_dek'
>
> This is due to an error in the Makefile, resulting in obj-yy/obj-yn/..
> and fsl_blob.o is therefore not linked.
>
> Fix it by splitting it up into two obj-y lines.
>
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170904/8eec01a0/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-04 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-03 17:17 [U-Boot] [PATCH] crypto/fsl: fix obj-yy in Makefile Clemens Gruber
2017-09-03 17:23 ` Fabio Estevam
2017-09-04 13:05 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.