[PATCH v2 1/2] rootfs-postcommands: remove empty line

[PATCH v2 1/2] rootfs-postcommands: remove empty line

[Jose Alarcon]

Signed-off-by: Jose Alarcon <jose.alarcon@ge.com>
---
 meta/classes/rootfs-postcommands.bbclass | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/classes/rootfs-postcommands.bbclass b/meta/classes/rootfs-postcommands.bbclass
index e7999d4..fb36bad 100644
--- a/meta/classes/rootfs-postcommands.bbclass
+++ b/meta/classes/rootfs-postcommands.bbclass
@@ -291,7 +291,6 @@ rootfs_sysroot_relativelinks () {
 	sysroot-relativelinks.py ${SDK_OUTPUT}/${SDKTARGETSYSROOT}
 }
 
-
 # Generated test data json file
 python write_image_test_data() {
     from oe.data import export2json
-- 
2.10.1

[PATCH v2 2/2] rootfs-postcommands: add test for unsatisfied RRECOMMENDS

[Jose Alarcon]

The do_rootfs log contains a number of unsatisfied package
recommendations. At the moment those are only visible when
reviewing the rootfs log.

This patch adds an extra check to surface any unsatisfied
recommendation  as WARNINGS to the build output.

Enable this check with:
ROOTFS_POSTPROCESS_COMMAND += "rootfs_log_check_recommends;"

Signed-off-by: Jose Alarcon <jose.alarcon@ge.com>
---
 meta/classes/rootfs-postcommands.bbclass | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/meta/classes/rootfs-postcommands.bbclass b/meta/classes/rootfs-postcommands.bbclass
index fb36bad..f6d31a0 100644
--- a/meta/classes/rootfs-postcommands.bbclass
+++ b/meta/classes/rootfs-postcommands.bbclass
@@ -307,3 +307,15 @@ python write_image_test_data() {
            os.remove(testdata_link)
         os.symlink(os.path.basename(testdata), testdata_link)
 }
+
+# Check for unsatisfied recommendations (RRECOMMENDS)
+python rootfs_log_check_recommends() {
+    log_path = d.expand("${T}/log.do_rootfs")
+    with open(log_path, 'r') as log:
+        for line in log:
+            if 'log_check' in line:
+                continue
+
+            if 'unsatisfied recommendation for' in line:
+                bb.warn('[log_check] %s: %s' % (d.getVar('PN', True), line))
+}
-- 
2.10.1

Re: [PATCH v2 2/2] rootfs-postcommands: add test for unsatisfied RRECOMMENDS

[Khem Raj]

On Sun, Sep 3, 2017 at 10:12 PM, Jose Alarcon <jose.alarcon@ge.com> wrote:
> The do_rootfs log contains a number of unsatisfied package
> recommendations. At the moment those are only visible when
> reviewing the rootfs log.
>
> This patch adds an extra check to surface any unsatisfied
> recommendation  as WARNINGS to the build output.
>

I think a note is more appropriate here.

> Enable this check with:
> ROOTFS_POSTPROCESS_COMMAND += "rootfs_log_check_recommends;"
>
> Signed-off-by: Jose Alarcon <jose.alarcon@ge.com>
> ---
>  meta/classes/rootfs-postcommands.bbclass | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/meta/classes/rootfs-postcommands.bbclass b/meta/classes/rootfs-postcommands.bbclass
> index fb36bad..f6d31a0 100644
> --- a/meta/classes/rootfs-postcommands.bbclass
> +++ b/meta/classes/rootfs-postcommands.bbclass
> @@ -307,3 +307,15 @@ python write_image_test_data() {
>             os.remove(testdata_link)
>          os.symlink(os.path.basename(testdata), testdata_link)
>  }
> +
> +# Check for unsatisfied recommendations (RRECOMMENDS)
> +python rootfs_log_check_recommends() {
> +    log_path = d.expand("${T}/log.do_rootfs")
> +    with open(log_path, 'r') as log:
> +        for line in log:
> +            if 'log_check' in line:
> +                continue
> +
> +            if 'unsatisfied recommendation for' in line:
> +                bb.warn('[log_check] %s: %s' % (d.getVar('PN', True), line))
> +}
> --
> 2.10.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v2 2/2] rootfs-postcommands: add test for unsatisfied RRECOMMENDS

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On 4 September 2017 at 21:10, Khem Raj <raj.khem@gmail.com> wrote:

> On Sun, Sep 3, 2017 at 10:12 PM, Jose Alarcon <jose.alarcon@ge.com> wrote:
> > The do_rootfs log contains a number of unsatisfied package
> > recommendations. At the moment those are only visible when
> > reviewing the rootfs log.
> >
> > This patch adds an extra check to surface any unsatisfied
> > recommendation  as WARNINGS to the build output.
> >
>
> I think a note is more appropriate here.


As it's opt-in, I agree that warning is relevant.  If the user didn't care
for this, they wouldn't have opted in.

Ross

[-- Attachment #2: Type: text/html, Size: 1054 bytes --]

Re: [PATCH v2 2/2] rootfs-postcommands: add test for unsatisfied RRECOMMENDS

[Khem Raj]

On Mon, Sep 4, 2017 at 1:12 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 4 September 2017 at 21:10, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Sun, Sep 3, 2017 at 10:12 PM, Jose Alarcon <jose.alarcon@ge.com> wrote:
>> > The do_rootfs log contains a number of unsatisfied package
>> > recommendations. At the moment those are only visible when
>> > reviewing the rootfs log.
>> >
>> > This patch adds an extra check to surface any unsatisfied
>> > recommendation  as WARNINGS to the build output.
>> >
>>
>> I think a note is more appropriate here.
>
>
> As it's opt-in, I agree that warning is relevant.  If the user didn't care
> for this, they wouldn't have opted in.

yes I forgot that its an opt-in and was thinking its another set of warnings
with opt-in it should be ok.

>
> Ross