All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Wolfram Sang <wsa@the-dreams.de>, Len Brown <lenb@kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Kevin Hilman <khilman@kernel.org>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jisheng Zhang <jszhang@marvell.com>,
	John Stultz <john.stultz@linaro.org>,
	Guodong Xu <guodong.xu@linaro.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Haojian Zhuang <haojian.zhuang@linaro.org>,
	Johannes Stezenbach <js@sig21.net>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v3 0/8] PM / ACPI / i2c: Deploy runtime PM centric path for system sleep
Date: Mon, 4 Sep 2017 07:46:37 +0200	[thread overview]
Message-ID: <20170904054637.GA23707@wunner.de> (raw)
In-Reply-To: <1668277.7DWLdgHGid@aspire.rjw.lan>

On Mon, Sep 04, 2017 at 02:17:21AM +0200, Rafael J. Wysocki wrote:
> OTOH I'm starting to think that direct_complete is only theoretically
> useful and may not be actually set very often in practice, whereas it
> adds significant complexity to the code, so I'm not sure about it any
> more.

That makes me come out of the woodwork as a direct_complete fan:

Runtime resuming a discrete GPU on a modern dual GPU laptop takes about
1.5 sec, runtime resuming Thunderbolt controllers more than 2 sec.
A discrete GPU easily consumes 10W, a Thunderbolt controller 2W.

So not having direct_complete would noticeably delay system suspend and
resume as well as reduce battery life.

Lukas

WARNING: multiple messages have this Message-ID (diff)
From: lukas@wunner.de (Lukas Wunner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/8] PM / ACPI / i2c: Deploy runtime PM centric path for system sleep
Date: Mon, 4 Sep 2017 07:46:37 +0200	[thread overview]
Message-ID: <20170904054637.GA23707@wunner.de> (raw)
In-Reply-To: <1668277.7DWLdgHGid@aspire.rjw.lan>

On Mon, Sep 04, 2017 at 02:17:21AM +0200, Rafael J. Wysocki wrote:
> OTOH I'm starting to think that direct_complete is only theoretically
> useful and may not be actually set very often in practice, whereas it
> adds significant complexity to the code, so I'm not sure about it any
> more.

That makes me come out of the woodwork as a direct_complete fan:

Runtime resuming a discrete GPU on a modern dual GPU laptop takes about
1.5 sec, runtime resuming Thunderbolt controllers more than 2 sec.
A discrete GPU easily consumes 10W, a Thunderbolt controller 2W.

So not having direct_complete would noticeably delay system suspend and
resume as well as reduce battery life.

Lukas

  reply	other threads:[~2017-09-04  5:46 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 14:56 [PATCH v3 0/8] PM / ACPI / i2c: Deploy runtime PM centric path for system sleep Ulf Hansson
2017-08-29 14:56 ` Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 1/8] PM / Sleep: Make the runtime PM centric path known to the PM core Ulf Hansson
2017-08-29 14:56   ` Ulf Hansson
2017-08-29 15:15   ` Rafael J. Wysocki
2017-08-29 15:15     ` Rafael J. Wysocki
2017-08-30  7:13     ` Ulf Hansson
2017-08-30  7:13       ` Ulf Hansson
2017-08-30 13:37       ` Rafael J. Wysocki
2017-08-30 13:37         ` Rafael J. Wysocki
2017-08-31  9:06         ` Ulf Hansson
2017-08-31  9:06           ` Ulf Hansson
2017-09-02 14:48           ` Rafael J. Wysocki
2017-09-02 14:48             ` Rafael J. Wysocki
2017-08-29 14:56 ` [PATCH v3 2/8] PM / ACPI: Restore acpi_subsys_complete() Ulf Hansson
2017-08-29 14:56   ` Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 3/8] PM / Sleep: Remove pm_complete_with_resume_check() Ulf Hansson
2017-08-29 14:56   ` Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 4/8] PM / ACPI: Split code validating need for runtime resume in ->prepare() Ulf Hansson
2017-08-29 14:56   ` Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 5/8] PM / ACPI: Split acpi_lpss_suspend_late|resume_early() Ulf Hansson
2017-08-29 14:56   ` Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 6/8] PM / ACPI: Enable the runtime PM centric approach for system sleep Ulf Hansson
2017-08-29 14:56   ` Ulf Hansson
2017-08-29 15:27   ` Rafael J. Wysocki
2017-08-29 15:27     ` Rafael J. Wysocki
2017-09-01  8:27     ` Ulf Hansson
2017-09-01  8:27       ` Ulf Hansson
2017-09-02 15:38       ` Rafael J. Wysocki
2017-09-02 15:38         ` Rafael J. Wysocki
2017-09-04 13:21         ` Ulf Hansson
2017-09-04 13:21           ` Ulf Hansson
2017-09-06  0:02           ` Rafael J. Wysocki
2017-09-06  0:02             ` Rafael J. Wysocki
2017-08-29 14:56 ` [PATCH v3 7/8] i2c: designware: Don't resume device in the ->complete() callback Ulf Hansson
2017-08-29 14:56   ` Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 8/8] i2c: designware: Deploy the runtime PM centric path for system sleep Ulf Hansson
2017-08-29 14:56   ` Ulf Hansson
2017-08-29 20:19 ` [PATCH v3 0/8] PM / ACPI / i2c: Deploy " Rafael J. Wysocki
2017-08-29 20:19   ` Rafael J. Wysocki
2017-08-30  9:57   ` Ulf Hansson
2017-08-30  9:57     ` Ulf Hansson
2017-08-31  0:17     ` Rafael J. Wysocki
2017-08-31  0:17       ` Rafael J. Wysocki
2017-09-01 10:42       ` Ulf Hansson
2017-09-01 10:42         ` Ulf Hansson
2017-09-04  0:17         ` Rafael J. Wysocki
2017-09-04  0:17           ` Rafael J. Wysocki
2017-09-04  5:46           ` Lukas Wunner [this message]
2017-09-04  5:46             ` Lukas Wunner
2017-09-04 10:04             ` Rafael J. Wysocki
2017-09-04 10:04               ` Rafael J. Wysocki
2017-09-04 12:55           ` Ulf Hansson
2017-09-04 12:55             ` Ulf Hansson
2017-09-06  0:52             ` Rafael J. Wysocki
2017-09-06  0:52               ` Rafael J. Wysocki
2017-09-06 10:46               ` Rafael J. Wysocki
2017-09-06 10:46                 ` Rafael J. Wysocki
2017-09-06 13:59                 ` Ulf Hansson
2017-09-06 13:59                   ` Ulf Hansson
2017-09-06 21:39                   ` Rafael J. Wysocki
2017-09-06 21:39                     ` Rafael J. Wysocki
2017-09-06 13:54               ` Ulf Hansson
2017-09-06 13:54                 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170904054637.GA23707@wunner.de \
    --to=lukas@wunner.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=guodong.xu@linaro.org \
    --cc=haojian.zhuang@linaro.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=john.stultz@linaro.org \
    --cc=js@sig21.net \
    --cc=jszhang@marvell.com \
    --cc=khilman@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=sumit.semwal@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.