All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] drivers: net: xgene: Misc bug fixes
@ 2017-09-05 18:16 ` Iyappan Subramanian
  0 siblings, 0 replies; 10+ messages in thread
From: Iyappan Subramanian @ 2017-09-05 18:16 UTC (permalink / raw)
  To: davem, netdev; +Cc: linux-arm-kernel, dnelson, patches, Iyappan Subramanian

This patch set fixes bugs related to handling the case for ACPI for,
reading and programming tx/rx delay values.

Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
---

Iyappan Subramanian (2):
  drivers: net: xgene: Read tx/rx delay for ACPI
  drivers: net: xgene: Remove return statement from void function

Quan Nguyen (1):
  drivers: net: xgene: Configure tx/rx delay for ACPI

 drivers/net/ethernet/apm/xgene/xgene_enet_hw.c   | 7 ++-----
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 6 ++----
 2 files changed, 4 insertions(+), 9 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 0/3] drivers: net: xgene: Misc bug fixes
@ 2017-09-05 18:16 ` Iyappan Subramanian
  0 siblings, 0 replies; 10+ messages in thread
From: Iyappan Subramanian @ 2017-09-05 18:16 UTC (permalink / raw)
  To: linux-arm-kernel

This patch set fixes bugs related to handling the case for ACPI for,
reading and programming tx/rx delay values.

Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
---

Iyappan Subramanian (2):
  drivers: net: xgene: Read tx/rx delay for ACPI
  drivers: net: xgene: Remove return statement from void function

Quan Nguyen (1):
  drivers: net: xgene: Configure tx/rx delay for ACPI

 drivers/net/ethernet/apm/xgene/xgene_enet_hw.c   | 7 ++-----
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 6 ++----
 2 files changed, 4 insertions(+), 9 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/3] drivers: net: xgene: Read tx/rx delay for ACPI
  2017-09-05 18:16 ` Iyappan Subramanian
@ 2017-09-05 18:16   ` Iyappan Subramanian
  -1 siblings, 0 replies; 10+ messages in thread
From: Iyappan Subramanian @ 2017-09-05 18:16 UTC (permalink / raw)
  To: davem, netdev
  Cc: Quan Nguyen, dnelson, patches, linux-arm-kernel, Iyappan Subramanian

This patch fixes reading tx/rx delay values for ACPI.

Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
Signed-off-by: Quan Nguyen <qnguyen@apm.com>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 6e253d9..655c0fc 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -1591,7 +1591,7 @@ static int xgene_get_tx_delay(struct xgene_enet_pdata *pdata)
 	struct device *dev = &pdata->pdev->dev;
 	int delay, ret;
 
-	ret = of_property_read_u32(dev->of_node, "tx-delay", &delay);
+	ret = device_property_read_u32(dev, "tx-delay", &delay);
 	if (ret) {
 		pdata->tx_delay = 4;
 		return 0;
@@ -1612,7 +1612,7 @@ static int xgene_get_rx_delay(struct xgene_enet_pdata *pdata)
 	struct device *dev = &pdata->pdev->dev;
 	int delay, ret;
 
-	ret = of_property_read_u32(dev->of_node, "rx-delay", &delay);
+	ret = device_property_read_u32(dev, "rx-delay", &delay);
 	if (ret) {
 		pdata->rx_delay = 2;
 		return 0;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 1/3] drivers: net: xgene: Read tx/rx delay for ACPI
@ 2017-09-05 18:16   ` Iyappan Subramanian
  0 siblings, 0 replies; 10+ messages in thread
From: Iyappan Subramanian @ 2017-09-05 18:16 UTC (permalink / raw)
  To: linux-arm-kernel

This patch fixes reading tx/rx delay values for ACPI.

Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
Signed-off-by: Quan Nguyen <qnguyen@apm.com>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 6e253d9..655c0fc 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -1591,7 +1591,7 @@ static int xgene_get_tx_delay(struct xgene_enet_pdata *pdata)
 	struct device *dev = &pdata->pdev->dev;
 	int delay, ret;
 
-	ret = of_property_read_u32(dev->of_node, "tx-delay", &delay);
+	ret = device_property_read_u32(dev, "tx-delay", &delay);
 	if (ret) {
 		pdata->tx_delay = 4;
 		return 0;
@@ -1612,7 +1612,7 @@ static int xgene_get_rx_delay(struct xgene_enet_pdata *pdata)
 	struct device *dev = &pdata->pdev->dev;
 	int delay, ret;
 
-	ret = of_property_read_u32(dev->of_node, "rx-delay", &delay);
+	ret = device_property_read_u32(dev, "rx-delay", &delay);
 	if (ret) {
 		pdata->rx_delay = 2;
 		return 0;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/3] drivers: net: xgene: Configure tx/rx delay for ACPI
  2017-09-05 18:16 ` Iyappan Subramanian
@ 2017-09-05 18:16   ` Iyappan Subramanian
  -1 siblings, 0 replies; 10+ messages in thread
From: Iyappan Subramanian @ 2017-09-05 18:16 UTC (permalink / raw)
  To: davem, netdev
  Cc: linux-arm-kernel, dnelson, patches, Quan Nguyen, Iyappan Subramanian

From: Quan Nguyen <qnguyen@apm.com>

This patch fixes configuring tx/rx delay values for ACPI.

Signed-off-by: Quan Nguyen <qnguyen@apm.com>
Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
index e45b587..3188f55 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
@@ -468,7 +468,6 @@ static void xgene_enet_configure_clock(struct xgene_enet_pdata *pdata)
 
 static void xgene_gmac_set_speed(struct xgene_enet_pdata *pdata)
 {
-	struct device *dev = &pdata->pdev->dev;
 	u32 icm0, icm2, mc2;
 	u32 intf_ctl, rgmii, value;
 
@@ -500,10 +499,8 @@ static void xgene_gmac_set_speed(struct xgene_enet_pdata *pdata)
 		intf_ctl |= ENET_GHD_MODE;
 		CFG_MACMODE_SET(&icm0, 2);
 		CFG_WAITASYNCRD_SET(&icm2, 0);
-		if (dev->of_node) {
-			CFG_TXCLK_MUXSEL0_SET(&rgmii, pdata->tx_delay);
-			CFG_RXCLK_MUXSEL0_SET(&rgmii, pdata->rx_delay);
-		}
+		CFG_TXCLK_MUXSEL0_SET(&rgmii, pdata->tx_delay);
+		CFG_RXCLK_MUXSEL0_SET(&rgmii, pdata->rx_delay);
 		rgmii |= CFG_SPEED_1250;
 
 		xgene_enet_rd_csr(pdata, DEBUG_REG_ADDR, &value);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/3] drivers: net: xgene: Configure tx/rx delay for ACPI
@ 2017-09-05 18:16   ` Iyappan Subramanian
  0 siblings, 0 replies; 10+ messages in thread
From: Iyappan Subramanian @ 2017-09-05 18:16 UTC (permalink / raw)
  To: linux-arm-kernel

From: Quan Nguyen <qnguyen@apm.com>

This patch fixes configuring tx/rx delay values for ACPI.

Signed-off-by: Quan Nguyen <qnguyen@apm.com>
Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
index e45b587..3188f55 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
@@ -468,7 +468,6 @@ static void xgene_enet_configure_clock(struct xgene_enet_pdata *pdata)
 
 static void xgene_gmac_set_speed(struct xgene_enet_pdata *pdata)
 {
-	struct device *dev = &pdata->pdev->dev;
 	u32 icm0, icm2, mc2;
 	u32 intf_ctl, rgmii, value;
 
@@ -500,10 +499,8 @@ static void xgene_gmac_set_speed(struct xgene_enet_pdata *pdata)
 		intf_ctl |= ENET_GHD_MODE;
 		CFG_MACMODE_SET(&icm0, 2);
 		CFG_WAITASYNCRD_SET(&icm2, 0);
-		if (dev->of_node) {
-			CFG_TXCLK_MUXSEL0_SET(&rgmii, pdata->tx_delay);
-			CFG_RXCLK_MUXSEL0_SET(&rgmii, pdata->rx_delay);
-		}
+		CFG_TXCLK_MUXSEL0_SET(&rgmii, pdata->tx_delay);
+		CFG_RXCLK_MUXSEL0_SET(&rgmii, pdata->rx_delay);
 		rgmii |= CFG_SPEED_1250;
 
 		xgene_enet_rd_csr(pdata, DEBUG_REG_ADDR, &value);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 3/3] drivers: net: xgene: Remove return statement from void function
  2017-09-05 18:16 ` Iyappan Subramanian
@ 2017-09-05 18:16   ` Iyappan Subramanian
  -1 siblings, 0 replies; 10+ messages in thread
From: Iyappan Subramanian @ 2017-09-05 18:16 UTC (permalink / raw)
  To: davem, netdev; +Cc: linux-arm-kernel, dnelson, patches, Iyappan Subramanian

commit 183db4 ("drivers: net: xgene: Correct probe sequence handling")
changed the return type of xgene_enet_check_phy_handle() to void.

This patch, removes the return statement from the last line.

Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 655c0fc..3b889ef 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -1674,8 +1674,6 @@ static void xgene_enet_check_phy_handle(struct xgene_enet_pdata *pdata)
 	ret = xgene_enet_phy_connect(pdata->ndev);
 	if (!ret)
 		pdata->mdio_driver = true;
-
-	return;
 }
 
 static void xgene_enet_gpiod_get(struct xgene_enet_pdata *pdata)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 3/3] drivers: net: xgene: Remove return statement from void function
@ 2017-09-05 18:16   ` Iyappan Subramanian
  0 siblings, 0 replies; 10+ messages in thread
From: Iyappan Subramanian @ 2017-09-05 18:16 UTC (permalink / raw)
  To: linux-arm-kernel

commit 183db4 ("drivers: net: xgene: Correct probe sequence handling")
changed the return type of xgene_enet_check_phy_handle() to void.

This patch, removes the return statement from the last line.

Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 655c0fc..3b889ef 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -1674,8 +1674,6 @@ static void xgene_enet_check_phy_handle(struct xgene_enet_pdata *pdata)
 	ret = xgene_enet_phy_connect(pdata->ndev);
 	if (!ret)
 		pdata->mdio_driver = true;
-
-	return;
 }
 
 static void xgene_enet_gpiod_get(struct xgene_enet_pdata *pdata)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] drivers: net: xgene: Misc bug fixes
  2017-09-05 18:16 ` Iyappan Subramanian
@ 2017-09-05 21:58   ` David Miller
  -1 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2017-09-05 21:58 UTC (permalink / raw)
  To: isubramanian; +Cc: netdev, dnelson, patches, linux-arm-kernel

From: Iyappan Subramanian <isubramanian@apm.com>
Date: Tue,  5 Sep 2017 11:16:29 -0700

> This patch set fixes bugs related to handling the case for ACPI for,
> reading and programming tx/rx delay values.
> 
> Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>

Series applied, thank you.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 0/3] drivers: net: xgene: Misc bug fixes
@ 2017-09-05 21:58   ` David Miller
  0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2017-09-05 21:58 UTC (permalink / raw)
  To: linux-arm-kernel

From: Iyappan Subramanian <isubramanian@apm.com>
Date: Tue,  5 Sep 2017 11:16:29 -0700

> This patch set fixes bugs related to handling the case for ACPI for,
> reading and programming tx/rx delay values.
> 
> Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>

Series applied, thank you.

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-09-05 21:58 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-05 18:16 [PATCH 0/3] drivers: net: xgene: Misc bug fixes Iyappan Subramanian
2017-09-05 18:16 ` Iyappan Subramanian
2017-09-05 18:16 ` [PATCH 1/3] drivers: net: xgene: Read tx/rx delay for ACPI Iyappan Subramanian
2017-09-05 18:16   ` Iyappan Subramanian
2017-09-05 18:16 ` [PATCH 2/3] drivers: net: xgene: Configure " Iyappan Subramanian
2017-09-05 18:16   ` Iyappan Subramanian
2017-09-05 18:16 ` [PATCH 3/3] drivers: net: xgene: Remove return statement from void function Iyappan Subramanian
2017-09-05 18:16   ` Iyappan Subramanian
2017-09-05 21:58 ` [PATCH 0/3] drivers: net: xgene: Misc bug fixes David Miller
2017-09-05 21:58   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.