* [U-Boot] [PATCH] gitignore: add intermediates from libfdt build
@ 2017-08-29 9:47 Philipp Tomsich
2017-08-31 12:52 ` Simon Glass
0 siblings, 1 reply; 7+ messages in thread
From: Philipp Tomsich @ 2017-08-29 9:47 UTC (permalink / raw)
To: u-boot
Since ee95d10 (fdt: Build the new python libfdt module), a number of
additional files are auto-generated/installed into the tools directory.
List these in .gitignore to suppress having them listed as untracked.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
References: ee95d10 (fdt: Build the new python libfdt module)
---
.gitignore | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/.gitignore b/.gitignore
index 29757aa..f6f5dae 100644
--- a/.gitignore
+++ b/.gitignore
@@ -57,6 +57,14 @@ fit-dtb.blob
/include/config/
/include/generated/
+# Since "ee95d10 fdt: Build the new python libfdt module", a number of
+# build artifacts and intermediated from the python libfdt module are
+# installed into the /tools directory.
+/tools/_libfdt.so
+/tools/libfdt.py
+/tools/libfdt.pyc
+/tools/libfdt_wrap.c
+
# stgit generated dirs
patches-*
.stgit-edit.txt
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] gitignore: add intermediates from libfdt build
2017-08-29 9:47 [U-Boot] [PATCH] gitignore: add intermediates from libfdt build Philipp Tomsich
@ 2017-08-31 12:52 ` Simon Glass
2017-09-04 16:27 ` sjg at google.com
2017-09-05 1:33 ` Bin Meng
0 siblings, 2 replies; 7+ messages in thread
From: Simon Glass @ 2017-08-31 12:52 UTC (permalink / raw)
To: u-boot
On 29 August 2017 at 17:47, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> Since ee95d10 (fdt: Build the new python libfdt module), a number of
> additional files are auto-generated/installed into the tools directory.
> List these in .gitignore to suppress having them listed as untracked.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> References: ee95d10 (fdt: Build the new python libfdt module)
>
> ---
>
> .gitignore | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] gitignore: add intermediates from libfdt build
2017-08-31 12:52 ` Simon Glass
@ 2017-09-04 16:27 ` sjg at google.com
2017-09-05 1:33 ` Bin Meng
1 sibling, 0 replies; 7+ messages in thread
From: sjg at google.com @ 2017-09-04 16:27 UTC (permalink / raw)
To: u-boot
On 29 August 2017 at 17:47, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> Since ee95d10 (fdt: Build the new python libfdt module), a number of
> additional files are auto-generated/installed into the tools directory.
> List these in .gitignore to suppress having them listed as untracked.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> References: ee95d10 (fdt: Build the new python libfdt module)
>
> ---
>
> .gitignore | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] gitignore: add intermediates from libfdt build
2017-08-31 12:52 ` Simon Glass
2017-09-04 16:27 ` sjg at google.com
@ 2017-09-05 1:33 ` Bin Meng
2017-09-05 8:57 ` Simon Glass
1 sibling, 1 reply; 7+ messages in thread
From: Bin Meng @ 2017-09-05 1:33 UTC (permalink / raw)
To: u-boot
On Thu, Aug 31, 2017 at 8:52 PM, Simon Glass <sjg@chromium.org> wrote:
> On 29 August 2017 at 17:47, Philipp Tomsich
> <philipp.tomsich@theobroma-systems.com> wrote:
>> Since ee95d10 (fdt: Build the new python libfdt module), a number of
>> additional files are auto-generated/installed into the tools directory.
>> List these in .gitignore to suppress having them listed as untracked.
>>
>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> References: ee95d10 (fdt: Build the new python libfdt module)
>>
>> ---
>>
>> .gitignore | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
I just noticed this. Shouldn't this be put in the tools/.gitignore instead?
I have a similar patch @ http://patchwork.ozlabs.org/patch/809493/
Regards,
Bin
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] gitignore: add intermediates from libfdt build
2017-09-05 1:33 ` Bin Meng
@ 2017-09-05 8:57 ` Simon Glass
2017-09-06 1:12 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Simon Glass @ 2017-09-05 8:57 UTC (permalink / raw)
To: u-boot
Hi Bin,
On 5 September 2017 at 09:33, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Thu, Aug 31, 2017 at 8:52 PM, Simon Glass <sjg@chromium.org> wrote:
>> On 29 August 2017 at 17:47, Philipp Tomsich
>> <philipp.tomsich@theobroma-systems.com> wrote:
>>> Since ee95d10 (fdt: Build the new python libfdt module), a number of
>>> additional files are auto-generated/installed into the tools directory.
>>> List these in .gitignore to suppress having them listed as untracked.
>>>
>>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>> References: ee95d10 (fdt: Build the new python libfdt module)
>>>
>>> ---
>>>
>>> .gitignore | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> I just noticed this. Shouldn't this be put in the tools/.gitignore instead?
>
> I have a similar patch @ http://patchwork.ozlabs.org/patch/809493/
Yes you are probably right. I have already sent a pull request though.
Tom what do you think?
Regards,
Simon
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] gitignore: add intermediates from libfdt build
2017-09-05 8:57 ` Simon Glass
@ 2017-09-06 1:12 ` Tom Rini
2017-09-06 5:23 ` Bin Meng
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2017-09-06 1:12 UTC (permalink / raw)
To: u-boot
On Tue, Sep 05, 2017 at 04:57:07PM +0800, Simon Glass wrote:
> Hi Bin,
>
> On 5 September 2017 at 09:33, Bin Meng <bmeng.cn@gmail.com> wrote:
> > On Thu, Aug 31, 2017 at 8:52 PM, Simon Glass <sjg@chromium.org> wrote:
> >> On 29 August 2017 at 17:47, Philipp Tomsich
> >> <philipp.tomsich@theobroma-systems.com> wrote:
> >>> Since ee95d10 (fdt: Build the new python libfdt module), a number of
> >>> additional files are auto-generated/installed into the tools directory.
> >>> List these in .gitignore to suppress having them listed as untracked.
> >>>
> >>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> >>> References: ee95d10 (fdt: Build the new python libfdt module)
> >>>
> >>> ---
> >>>
> >>> .gitignore | 8 ++++++++
> >>> 1 file changed, 8 insertions(+)
> >>
> >> Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> > I just noticed this. Shouldn't this be put in the tools/.gitignore instead?
> >
> > I have a similar patch @ http://patchwork.ozlabs.org/patch/809493/
>
> Yes you are probably right. I have already sent a pull request though.
>
> Tom what do you think?
We have many examples of .gitignore in subdirectories, so lets continue
there. I believe that keeps the file manageable.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170905/0b724d94/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] gitignore: add intermediates from libfdt build
2017-09-06 1:12 ` Tom Rini
@ 2017-09-06 5:23 ` Bin Meng
0 siblings, 0 replies; 7+ messages in thread
From: Bin Meng @ 2017-09-06 5:23 UTC (permalink / raw)
To: u-boot
On Wed, Sep 6, 2017 at 9:12 AM, Tom Rini <trini@konsulko.com> wrote:
> On Tue, Sep 05, 2017 at 04:57:07PM +0800, Simon Glass wrote:
>> Hi Bin,
>>
>> On 5 September 2017 at 09:33, Bin Meng <bmeng.cn@gmail.com> wrote:
>> > On Thu, Aug 31, 2017 at 8:52 PM, Simon Glass <sjg@chromium.org> wrote:
>> >> On 29 August 2017 at 17:47, Philipp Tomsich
>> >> <philipp.tomsich@theobroma-systems.com> wrote:
>> >>> Since ee95d10 (fdt: Build the new python libfdt module), a number of
>> >>> additional files are auto-generated/installed into the tools directory.
>> >>> List these in .gitignore to suppress having them listed as untracked.
>> >>>
>> >>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> >>> References: ee95d10 (fdt: Build the new python libfdt module)
>> >>>
>> >>> ---
>> >>>
>> >>> .gitignore | 8 ++++++++
>> >>> 1 file changed, 8 insertions(+)
>> >>
>> >> Reviewed-by: Simon Glass <sjg@chromium.org>
>> >
>> > I just noticed this. Shouldn't this be put in the tools/.gitignore instead?
>> >
>> > I have a similar patch @ http://patchwork.ozlabs.org/patch/809493/
>>
>> Yes you are probably right. I have already sent a pull request though.
>>
>> Tom what do you think?
>
> We have many examples of .gitignore in subdirectories, so lets continue
> there. I believe that keeps the file manageable.
I will post a v2 to fix this.
Regards,
Bin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-06 5:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-29 9:47 [U-Boot] [PATCH] gitignore: add intermediates from libfdt build Philipp Tomsich
2017-08-31 12:52 ` Simon Glass
2017-09-04 16:27 ` sjg at google.com
2017-09-05 1:33 ` Bin Meng
2017-09-05 8:57 ` Simon Glass
2017-09-06 1:12 ` Tom Rini
2017-09-06 5:23 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.