[rtc-linux] [PATCH] drivers/rtc/rtc-pcf85263.c: add support for devicetree

[rtc-linux] [PATCH] drivers/rtc/rtc-pcf85263.c: add support for devicetree

[ying.zhang22455]

From: Zhang Ying-22455 <ying.zhang22455@nxp.com>

Add compatible string "nxp,rtc-pcf85263"
Document the binding

Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
---
 Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt

diff --git a/Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt b/Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt
new file mode 100644
index 000000000000..d2ffd3626f5c
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt
@@ -0,0 +1,15 @@
+NXP PCF85263 SPI Real Time Clock
+
+Required properties:
+- compatible: should be: "nxp,rtc-pcf85263"
+- reg: should be the SPI slave chipselect address
+
+Optional properties:
+- spi-cs-high: PCF85263 needs chipselect high
+
+Example:
+
+rtc: nxp,rtc-pcf85263@51 {
+	compatible = "nxp,rtc-pcf85263"
+	reg = <51>
+};
-- 
2.14.1

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [rtc-linux] [PATCH] drivers/rtc/rtc-pcf85263.c: add support for devicetree

[Alexandre Belloni]

Hi,

This email was not send to the correct mailing list.

On 06/09/2017 at 13:44:03 +0800, ying.zhang22455@nxp.com wrote:
> From: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> 
> Add compatible string "nxp,rtc-pcf85263"

It doesn't add the compatible string anywhere.

> Document the binding
> 
> Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> ---
>  Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt b/Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt
> new file mode 100644
> index 000000000000..d2ffd3626f5c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,rtc-85263.txt
> @@ -0,0 +1,15 @@
> +NXP PCF85263 SPI Real Time Clock
> +
> +Required properties:
> +- compatible: should be: "nxp,rtc-pcf85263"

The proper compatible string would be "nxp,pcf85263"

Also, please have a look at
http://patchwork.ozlabs.org/patch/658956/
http://patchwork.ozlabs.org/patch/658957/

Martin never replied but you can probably push them again.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com