* [Buildroot] [PATCH] mmc-utils: use upstream provided install target
@ 2017-09-04 7:40 Baruch Siach
2017-09-06 21:33 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2017-09-04 7:40 UTC (permalink / raw)
To: buildroot
Cc: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/mmc-utils/mmc-utils.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/mmc-utils/mmc-utils.mk b/package/mmc-utils/mmc-utils.mk
index 0b9a6d14193d..7292c029f5a2 100644
--- a/package/mmc-utils/mmc-utils.mk
+++ b/package/mmc-utils/mmc-utils.mk
@@ -13,7 +13,7 @@ define MMC_UTILS_BUILD_CMDS
endef
define MMC_UTILS_INSTALL_TARGET_CMDS
- $(INSTALL) -D -m 0755 $(@D)/mmc $(TARGET_DIR)/usr/bin/mmc
+ prefix=$(TARGET_DIR) $(MAKE) -C $(@D) install
endef
$(eval $(generic-package))
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] mmc-utils: use upstream provided install target
2017-09-04 7:40 [Buildroot] [PATCH] mmc-utils: use upstream provided install target Baruch Siach
@ 2017-09-06 21:33 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-09-06 21:33 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 4 Sep 2017 10:40:40 +0300, Baruch Siach wrote:
> define MMC_UTILS_INSTALL_TARGET_CMDS
> - $(INSTALL) -D -m 0755 $(@D)/mmc $(TARGET_DIR)/usr/bin/mmc
> + prefix=$(TARGET_DIR) $(MAKE) -C $(@D) install
> endef
This is not entirely correct, for a few reasons: first, your patch
introduces a difference as the "mmc" program is now installed
in /bin/mmc and not /usr/bin/mmc, which isn't nice.
Also, it mis-uses prefix, as DESTDIR should be used. The correct
use is prefix=/usr (to override the default of /usr/local) and
DESTDIR=$(TARGET_DIR).
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-06 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-04 7:40 [Buildroot] [PATCH] mmc-utils: use upstream provided install target Baruch Siach
2017-09-06 21:33 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.