All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
	thuth@redhat.com, cohuck@redhat.com, david@redhat.com,
	borntraeger@de.ibm.com, Alexander Graf <agraf@suse.de>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Matthew Rosato <mjrosato@linux.vnet.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH v4 06/21] s390x: move subsystem_reset() to s390-virtio-ccw.h
Date: Mon, 11 Sep 2017 17:21:35 +0200	[thread overview]
Message-ID: <20170911152150.12535-7-david@redhat.com> (raw)
In-Reply-To: <20170911152150.12535-1-david@redhat.com>

Implemented in s390-virtio-ccw.c, so move it to the right header.
We can also drop the extern. Fix up one include.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 include/hw/s390x/s390-virtio-ccw.h | 2 ++
 target/s390x/cpu.h                 | 1 -
 target/s390x/diag.c                | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/hw/s390x/s390-virtio-ccw.h b/include/hw/s390x/s390-virtio-ccw.h
index 41a9d2862b..a9a90c2022 100644
--- a/include/hw/s390x/s390-virtio-ccw.h
+++ b/include/hw/s390x/s390-virtio-ccw.h
@@ -56,4 +56,6 @@ bool gs_allowed(void);
  */
 bool css_migration_enabled(void);
 
+void subsystem_reset(void);
+
 #endif
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 7073fa59e9..372f7d8885 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -721,7 +721,6 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *hostbuf,
 
 /* outside of target/s390x/ */
 S390CPU *s390_cpu_addr2state(uint16_t cpu_addr);
-extern void subsystem_reset(void);
 int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);
 
 #endif
diff --git a/target/s390x/diag.c b/target/s390x/diag.c
index e6b5e6de37..82a623948d 100644
--- a/target/s390x/diag.c
+++ b/target/s390x/diag.c
@@ -20,6 +20,7 @@
 #include "hw/watchdog/wdt_diag288.h"
 #include "sysemu/cpus.h"
 #include "hw/s390x/ipl.h"
+#include "hw/s390x/s390-virtio-ccw.h"
 
 static int modified_clear_reset(S390CPU *cpu)
 {
-- 
2.13.5

  parent reply	other threads:[~2017-09-11 15:22 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 15:21 [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug via device_add David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 01/21] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 02/21] cpu: drop old comments describing members David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 03/21] s390x: get rid of s390-virtio.c David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 04/21] s390x: rename s390-virtio.h to s390-virtio-hcall.h David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 05/21] s390x: move s390_virtio_hypercall() " David Hildenbrand
2017-09-11 15:21 ` David Hildenbrand [this message]
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 07/21] target/s390x: move some s390x typedefs to cpu-qom.h David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 08/21] s390x: move sclp_service_call() to sclp.h David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 09/21] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault() David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 10/21] target/s390x: use program_interrupt() in per_check_exception() David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG David Hildenbrand
2017-09-12 12:43   ` Igor Mammedov
2017-09-12 15:42     ` David Hildenbrand
2017-09-13  7:19       ` Igor Mammedov
2017-09-13 12:10         ` David Hildenbrand
2017-09-13 12:35           ` Cornelia Huck
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 12/21] target/s390x: set cpu->id for linux user when realizing David Hildenbrand
2017-09-12 12:46   ` Igor Mammedov
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 13/21] target/s390x: use "core-id" for cpu number/address/id handling David Hildenbrand
2017-09-12 13:07   ` Igor Mammedov
2017-09-12 13:15     ` David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id to next_core_id David Hildenbrand
2017-09-12 13:09   ` Igor Mammedov
2017-09-12 13:16     ` David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 15/21] s390x: print CPU definitions in sorted order David Hildenbrand
2017-09-12 10:51   ` Christian Borntraeger
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 16/21] s390x: allow cpu hotplug via device_add David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 17/21] s390x: CPU hot unplug via device_del cannot work for now David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 18/21] s390x: implement query-hotpluggable-cpus David Hildenbrand
2017-09-12 13:43   ` Igor Mammedov
2017-09-12 14:03     ` David Hildenbrand
2017-09-12 14:24       ` Thomas Huth
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 19/21] s390x: get rid of cpu_s390x_create() David Hildenbrand
2017-09-12 13:50   ` Igor Mammedov
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 20/21] s390x: generate sclp cpu information from possible_cpus David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 21/21] s390x: allow CPU hotplug in random core-id order David Hildenbrand
2017-09-12 13:55 ` [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug via device_add Igor Mammedov
2017-09-12 13:56   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170911152150.12535-7-david@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.de \
    --cc=armbru@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mjrosato@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.