Re: [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id to next_core_id

From: David Hildenbrand <david@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org,
	Matthew Rosato <mjrosato@linux.vnet.ibm.com>,
	thuth@redhat.com, Eduardo Habkost <ehabkost@redhat.com>,
	cohuck@redhat.com,
	Richard Henderson <richard.henderson@linaro.org>,
	Alexander Graf <agraf@suse.de>,
	Markus Armbruster <armbru@redhat.com>,
	borntraeger@de.ibm.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id to next_core_id
Date: Tue, 12 Sep 2017 15:16:15 +0200	[thread overview]
Message-ID: <933e6e9a-aea1-1d8e-210c-e1837e414bdf@redhat.com> (raw)
In-Reply-To: <20170912150947.70cf9b71@nial.brq.redhat.com>

On 12.09.2017 15:09, Igor Mammedov wrote:
> On Mon, 11 Sep 2017 17:21:43 +0200
> David Hildenbrand <david@redhat.com> wrote:
> 
>> Adapt to the new term "core_id". While at it, fix the type and drop the
>> initialization to 0 (which is superfluous).
>>
>> Reviewed-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>>  target/s390x/cpu-qom.h |  2 +-
>>  target/s390x/cpu.c     | 11 +++++------
>>  2 files changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/target/s390x/cpu-qom.h b/target/s390x/cpu-qom.h
>> index 2435cd8390..2e446fab51 100644
>> --- a/target/s390x/cpu-qom.h
>> +++ b/target/s390x/cpu-qom.h
>> @@ -54,7 +54,7 @@ typedef struct S390CPUClass {
>>      bool is_migration_safe;
>>      const char *desc;
>>  
>> -    int64_t next_cpu_id;
>> +    uint32_t next_core_id;
> is it possible to hotplug cpus in out of order in real hw?

Yes, at least under z/VM. See last two patches in this series.

-- 

Thanks,

David