All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids
@ 2017-09-11 16:11 Anuj Phogat
  2017-09-11 16:11 ` [PATCH 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5 Anuj Phogat
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Anuj Phogat @ 2017-09-11 16:11 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

See Mesa commits: ebc5ccf and b2dae9f

Cc: Matt Turner <mattst88@gmail.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
---
 drivers/gpu/drm/i915/i915_pci.c |  1 -
 include/drm/i915_pciids.h       | 15 ++-------------
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 129877b..ecf6d4c 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -613,7 +613,6 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_KBL_GT1_IDS(&intel_kabylake_gt1_info),
 	INTEL_KBL_GT2_IDS(&intel_kabylake_gt2_info),
 	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
-	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
 	INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
 	INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
 	INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 1257e15..a1bf90e 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -337,15 +337,10 @@
 	INTEL_VGA_DEVICE(0x3185, info)
 
 #define INTEL_KBL_GT1_IDS(info)	\
-	INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
-	INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
 	INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
 	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
-	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
 	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
-	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
-	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
-	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
+	INTEL_VGA_DEVICE(0x590B, info)  /* Halo GT1 */
 
 #define INTEL_KBL_GT2_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
@@ -353,22 +348,16 @@
 	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
 	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
-	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
 	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
 
 #define INTEL_KBL_GT3_IDS(info) \
-	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
 
-#define INTEL_KBL_GT4_IDS(info) \
-	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
-
 #define INTEL_KBL_IDS(info) \
 	INTEL_KBL_GT1_IDS(info), \
 	INTEL_KBL_GT2_IDS(info), \
-	INTEL_KBL_GT3_IDS(info), \
-	INTEL_KBL_GT4_IDS(info)
+	INTEL_KBL_GT3_IDS(info)
 
 /* CFL S */
 #define INTEL_CFL_S_GT1_IDS(info) \
-- 
2.9.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5
  2017-09-11 16:11 [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids Anuj Phogat
@ 2017-09-11 16:11 ` Anuj Phogat
  2017-09-20 20:31   ` [PATCH v2 " Anuj Phogat
  2017-09-11 16:31 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids Patchwork
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Anuj Phogat @ 2017-09-11 16:11 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

See Mesa commit 9c588ff

Cc: Matt Turner <mattst88@gmail.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
---
 include/drm/i915_pciids.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index a1bf90e..1c29063 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -337,13 +337,13 @@
 	INTEL_VGA_DEVICE(0x3185, info)
 
 #define INTEL_KBL_GT1_IDS(info)	\
-	INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
 	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
 	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
 	INTEL_VGA_DEVICE(0x590B, info)  /* Halo GT1 */
 
 #define INTEL_KBL_GT2_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
+	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
 	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
 	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
-- 
2.9.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids
  2017-09-11 16:11 [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids Anuj Phogat
  2017-09-11 16:11 ` [PATCH 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5 Anuj Phogat
@ 2017-09-11 16:31 ` Patchwork
  2017-09-11 17:10 ` [Intel-gfx] [PATCH 1/2] " Rodrigo Vivi
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2017-09-11 16:31 UTC (permalink / raw)
  To: Anuj Phogat; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids
URL   : https://patchwork.freedesktop.org/series/30151/
State : success

== Summary ==

Series 30151v1 series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids
https://patchwork.freedesktop.org/api/1.0/series/30151/revisions/1/mbox/

Test chamelium:
        Subgroup dp-crc-fast:
                fail       -> PASS       (fi-kbl-7500u) fdo#102514
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-snb-2600) fdo#100215
Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                skip       -> PASS       (fi-skl-x1585l) fdo#101781

fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:449s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:456s
fi-blb-e6850     total:289  pass:224  dwarn:1   dfail:0   fail:0   skip:64  time:377s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:532s
fi-bwr-2160      total:289  pass:184  dwarn:0   dfail:0   fail:0   skip:105 time:269s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:510s
fi-byt-j1900     total:289  pass:254  dwarn:1   dfail:0   fail:0   skip:34  time:502s
fi-byt-n2820     total:289  pass:250  dwarn:1   dfail:0   fail:0   skip:38  time:494s
fi-cfl-s         total:289  pass:250  dwarn:4   dfail:0   fail:0   skip:35  time:458s
fi-elk-e7500     total:289  pass:230  dwarn:0   dfail:0   fail:0   skip:59  time:448s
fi-glk-2a        total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:590s
fi-hsw-4770      total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:429s
fi-hsw-4770r     total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:405s
fi-ilk-650       total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:438s
fi-ivb-3520m     total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:488s
fi-ivb-3770      total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:467s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:496s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:578s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:582s
fi-pnv-d510      total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:552s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:456s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:517s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:494s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:462s
fi-skl-x1585l    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:503s
fi-snb-2520m     total:289  pass:251  dwarn:0   dfail:0   fail:0   skip:38  time:563s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:1   skip:39  time:423s

a06ff73a7522af231e77776d7948e4d8099558c6 drm-tip: 2017y-09m-11d-13h-31m-34s UTC integration manifest
6b0df78ec3a4 drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5
e07796a20208 drm/i915/kbl: Remove unused Kabylake pci ids

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5647/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids
  2017-09-11 16:11 [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids Anuj Phogat
  2017-09-11 16:11 ` [PATCH 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5 Anuj Phogat
  2017-09-11 16:31 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids Patchwork
@ 2017-09-11 17:10 ` Rodrigo Vivi
  2017-09-12 17:24   ` Anuj Phogat
  2017-09-12 20:30   ` Paulo Zanoni
  2017-09-11 19:31 ` ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
  2017-09-20 20:39 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids (rev2) Patchwork
  4 siblings, 2 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2017-09-11 17:10 UTC (permalink / raw)
  To: Anuj Phogat; +Cc: mesa-dev, intel-gfx

On Mon, Sep 11, 2017 at 04:11:33PM +0000, Anuj Phogat wrote:
> See Mesa commits: ebc5ccf and b2dae9f

I believe we need to be in sync between multiple gfx stack components,
but I  don't believe we should remove ids.

In the past we had cases where we noticed a product group using a listed
id to do a product and we just noticed the id after a user reported at fd.o.

For us in kernel the cycle until that id gets into a stable release
propagated to OSVs distros can be a bit long.

Also Xserver ids are nowadays in sync with Mesa ones and I believe some
OSVs might take a while to upgrade the Xserver as well in case of a new
found product with some "new" id.

For this reason I was always in favor of adding all possible reserved ids from the
beginning.

And this approach worked well on BDW and SKL, where we've seeing later some
reserved ids becoming real product and we didn't have to do any extra step.

For this same reason I believe the right solution is to
add those ids back to mesa instead of removing from kernel and libdrm.

Thanks,
Rodrigo.

> 
> Cc: Matt Turner <mattst88@gmail.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
> ---
>  drivers/gpu/drm/i915/i915_pci.c |  1 -
>  include/drm/i915_pciids.h       | 15 ++-------------
>  2 files changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 129877b..ecf6d4c 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -613,7 +613,6 @@ static const struct pci_device_id pciidlist[] = {
>  	INTEL_KBL_GT1_IDS(&intel_kabylake_gt1_info),
>  	INTEL_KBL_GT2_IDS(&intel_kabylake_gt2_info),
>  	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
> -	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
>  	INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
>  	INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
>  	INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 1257e15..a1bf90e 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -337,15 +337,10 @@
>  	INTEL_VGA_DEVICE(0x3185, info)
>  
>  #define INTEL_KBL_GT1_IDS(info)	\
> -	INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
> -	INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
>  	INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
>  	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
> -	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
>  	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
> -	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
> -	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
> -	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
> +	INTEL_VGA_DEVICE(0x590B, info)  /* Halo GT1 */
>  
>  #define INTEL_KBL_GT2_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
> @@ -353,22 +348,16 @@
>  	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
>  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
>  	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
> -	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
>  	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
>  
>  #define INTEL_KBL_GT3_IDS(info) \
> -	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
>  
> -#define INTEL_KBL_GT4_IDS(info) \
> -	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
> -
>  #define INTEL_KBL_IDS(info) \
>  	INTEL_KBL_GT1_IDS(info), \
>  	INTEL_KBL_GT2_IDS(info), \
> -	INTEL_KBL_GT3_IDS(info), \
> -	INTEL_KBL_GT4_IDS(info)
> +	INTEL_KBL_GT3_IDS(info)
>  
>  /* CFL S */
>  #define INTEL_CFL_S_GT1_IDS(info) \
> -- 
> 2.9.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids
  2017-09-11 16:11 [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids Anuj Phogat
                   ` (2 preceding siblings ...)
  2017-09-11 17:10 ` [Intel-gfx] [PATCH 1/2] " Rodrigo Vivi
@ 2017-09-11 19:31 ` Patchwork
  2017-09-20 20:39 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids (rev2) Patchwork
  4 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2017-09-11 19:31 UTC (permalink / raw)
  To: Anuj Phogat; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids
URL   : https://patchwork.freedesktop.org/series/30151/
State : success

== Summary ==

Test kms_atomic_transition:
        Subgroup plane-all-transition-nonblocking:
                fail       -> PASS       (shard-hsw)

shard-hsw        total:2255 pass:1215 dwarn:0   dfail:0   fail:13  skip:1027 time:9225s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5647/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids
  2017-09-11 17:10 ` [Intel-gfx] [PATCH 1/2] " Rodrigo Vivi
@ 2017-09-12 17:24   ` Anuj Phogat
  2017-09-12 20:30   ` Paulo Zanoni
  1 sibling, 0 replies; 14+ messages in thread
From: Anuj Phogat @ 2017-09-12 17:24 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: mesa-dev, Intel GFX

On Mon, Sep 11, 2017 at 10:10 AM, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Mon, Sep 11, 2017 at 04:11:33PM +0000, Anuj Phogat wrote:
>> See Mesa commits: ebc5ccf and b2dae9f
>
> I believe we need to be in sync between multiple gfx stack components,
> but I  don't believe we should remove ids.
>
> In the past we had cases where we noticed a product group using a listed
> id to do a product and we just noticed the id after a user reported at fd.o.
>
> For us in kernel the cycle until that id gets into a stable release
> propagated to OSVs distros can be a bit long.
>
> Also Xserver ids are nowadays in sync with Mesa ones and I believe some
> OSVs might take a while to upgrade the Xserver as well in case of a new
> found product with some "new" id.
>
> For this reason I was always in favor of adding all possible reserved ids from the
> beginning.
>
> And this approach worked well on BDW and SKL, where we've seeing later some
> reserved ids becoming real product and we didn't have to do any extra step.
>
> For this same reason I believe the right solution is to
> add those ids back to mesa instead of removing from kernel and libdrm.
>
I'm fine with keeping the unused pci id's in Mesa tree and keep it uniform
across multiple gfx stack components. I'll revert the Mesa patch.

> Thanks,
> Rodrigo.
>
>>
>> Cc: Matt Turner <mattst88@gmail.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
>> ---
>>  drivers/gpu/drm/i915/i915_pci.c |  1 -
>>  include/drm/i915_pciids.h       | 15 ++-------------
>>  2 files changed, 2 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
>> index 129877b..ecf6d4c 100644
>> --- a/drivers/gpu/drm/i915/i915_pci.c
>> +++ b/drivers/gpu/drm/i915/i915_pci.c
>> @@ -613,7 +613,6 @@ static const struct pci_device_id pciidlist[] = {
>>       INTEL_KBL_GT1_IDS(&intel_kabylake_gt1_info),
>>       INTEL_KBL_GT2_IDS(&intel_kabylake_gt2_info),
>>       INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
>> -     INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
>>       INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
>>       INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
>>       INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
>> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
>> index 1257e15..a1bf90e 100644
>> --- a/include/drm/i915_pciids.h
>> +++ b/include/drm/i915_pciids.h
>> @@ -337,15 +337,10 @@
>>       INTEL_VGA_DEVICE(0x3185, info)
>>
>>  #define INTEL_KBL_GT1_IDS(info)      \
>> -     INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
>> -     INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
>>       INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
>>       INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
>> -     INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
>>       INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
>> -     INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
>> -     INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
>> -     INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
>> +     INTEL_VGA_DEVICE(0x590B, info)  /* Halo GT1 */
>>
>>  #define INTEL_KBL_GT2_IDS(info)      \
>>       INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
>> @@ -353,22 +348,16 @@
>>       INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
>>       INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
>>       INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
>> -     INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
>>       INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
>>
>>  #define INTEL_KBL_GT3_IDS(info) \
>> -     INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
>>       INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
>>       INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
>>
>> -#define INTEL_KBL_GT4_IDS(info) \
>> -     INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
>> -
>>  #define INTEL_KBL_IDS(info) \
>>       INTEL_KBL_GT1_IDS(info), \
>>       INTEL_KBL_GT2_IDS(info), \
>> -     INTEL_KBL_GT3_IDS(info), \
>> -     INTEL_KBL_GT4_IDS(info)
>> +     INTEL_KBL_GT3_IDS(info)
>>
>>  /* CFL S */
>>  #define INTEL_CFL_S_GT1_IDS(info) \
>> --
>> 2.9.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids
  2017-09-11 17:10 ` [Intel-gfx] [PATCH 1/2] " Rodrigo Vivi
  2017-09-12 17:24   ` Anuj Phogat
@ 2017-09-12 20:30   ` Paulo Zanoni
  2017-09-13  0:31     ` Rodrigo Vivi
  1 sibling, 1 reply; 14+ messages in thread
From: Paulo Zanoni @ 2017-09-12 20:30 UTC (permalink / raw)
  To: Rodrigo Vivi, Anuj Phogat; +Cc: mesa-dev, intel-gfx

Em Seg, 2017-09-11 às 10:10 -0700, Rodrigo Vivi escreveu:
> On Mon, Sep 11, 2017 at 04:11:33PM +0000, Anuj Phogat wrote:
> > See Mesa commits: ebc5ccf and b2dae9f
> 
> I believe we need to be in sync between multiple gfx stack
> components,
> but I  don't believe we should remove ids.
> 
> In the past we had cases where we noticed a product group using a
> listed
> id to do a product and we just noticed the id after a user reported
> at fd.o.

On the other hand, don't we have the risk that someone is going to see
that these IDs are unused for KBL and them repurpose them om some
future non-KBL product?

> 
> For us in kernel the cycle until that id gets into a stable release
> propagated to OSVs distros can be a bit long.
> 
> Also Xserver ids are nowadays in sync with Mesa ones and I believe
> some
> OSVs might take a while to upgrade the Xserver as well in case of a
> new
> found product with some "new" id.
> 
> For this reason I was always in favor of adding all possible reserved
> ids from the
> beginning.
> 
> And this approach worked well on BDW and SKL, where we've seeing
> later some
> reserved ids becoming real product and we didn't have to do any extra
> step.
> 
> For this same reason I believe the right solution is to
> add those ids back to mesa instead of removing from kernel and
> libdrm.
> 
> Thanks,
> Rodrigo.
> 
> > 
> > Cc: Matt Turner <mattst88@gmail.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
> > ---
> >  drivers/gpu/drm/i915/i915_pci.c |  1 -
> >  include/drm/i915_pciids.h       | 15 ++-------------
> >  2 files changed, 2 insertions(+), 14 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c
> > b/drivers/gpu/drm/i915/i915_pci.c
> > index 129877b..ecf6d4c 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -613,7 +613,6 @@ static const struct pci_device_id pciidlist[] =
> > {
> >  	INTEL_KBL_GT1_IDS(&intel_kabylake_gt1_info),
> >  	INTEL_KBL_GT2_IDS(&intel_kabylake_gt2_info),
> >  	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
> > -	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
> >  	INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
> >  	INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
> >  	INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > index 1257e15..a1bf90e 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -337,15 +337,10 @@
> >  	INTEL_VGA_DEVICE(0x3185, info)
> >  
> >  #define INTEL_KBL_GT1_IDS(info)	\
> > -	INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
> > -	INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
> >  	INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
> >  	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
> > -	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
> >  	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
> > -	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
> > -	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
> > -	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
> > +	INTEL_VGA_DEVICE(0x590B, info)  /* Halo GT1 */
> >  
> >  #define INTEL_KBL_GT2_IDS(info)	\
> >  	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
> > @@ -353,22 +348,16 @@
> >  	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
> >  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
> >  	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
> > -	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
> >  	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
> >  
> >  #define INTEL_KBL_GT3_IDS(info) \
> > -	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
> >  
> > -#define INTEL_KBL_GT4_IDS(info) \
> > -	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
> > -
> >  #define INTEL_KBL_IDS(info) \
> >  	INTEL_KBL_GT1_IDS(info), \
> >  	INTEL_KBL_GT2_IDS(info), \
> > -	INTEL_KBL_GT3_IDS(info), \
> > -	INTEL_KBL_GT4_IDS(info)
> > +	INTEL_KBL_GT3_IDS(info)
> >  
> >  /* CFL S */
> >  #define INTEL_CFL_S_GT1_IDS(info) \
> > -- 
> > 2.9.4
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids
  2017-09-12 20:30   ` Paulo Zanoni
@ 2017-09-13  0:31     ` Rodrigo Vivi
  2017-09-20 19:08       ` Anuj Phogat
  0 siblings, 1 reply; 14+ messages in thread
From: Rodrigo Vivi @ 2017-09-13  0:31 UTC (permalink / raw)
  To: Paulo Zanoni; +Cc: intel-gfx, mesa-dev

On Tue, Sep 12, 2017 at 08:30:47PM +0000, Paulo Zanoni wrote:
> Em Seg, 2017-09-11 às 10:10 -0700, Rodrigo Vivi escreveu:
> > On Mon, Sep 11, 2017 at 04:11:33PM +0000, Anuj Phogat wrote:
> > > See Mesa commits: ebc5ccf and b2dae9f
> > 
> > I believe we need to be in sync between multiple gfx stack
> > components,
> > but I  don't believe we should remove ids.
> > 
> > In the past we had cases where we noticed a product group using a
> > listed
> > id to do a product and we just noticed the id after a user reported
> > at fd.o.
> 
> On the other hand, don't we have the risk that someone is going to see
> that these IDs are unused for KBL and them repurpose them om some
> future non-KBL product?

There is only risk if the id was removed from Spec. But when that happens I'm in favor
of removing from the components as well.
While it is listed there even without POR it is reserved.

> 
> > 
> > For us in kernel the cycle until that id gets into a stable release
> > propagated to OSVs distros can be a bit long.
> > 
> > Also Xserver ids are nowadays in sync with Mesa ones and I believe
> > some
> > OSVs might take a while to upgrade the Xserver as well in case of a
> > new
> > found product with some "new" id.
> > 
> > For this reason I was always in favor of adding all possible reserved
> > ids from the
> > beginning.
> > 
> > And this approach worked well on BDW and SKL, where we've seeing
> > later some
> > reserved ids becoming real product and we didn't have to do any extra
> > step.
> > 
> > For this same reason I believe the right solution is to
> > add those ids back to mesa instead of removing from kernel and
> > libdrm.
> > 
> > Thanks,
> > Rodrigo.
> > 
> > > 
> > > Cc: Matt Turner <mattst88@gmail.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
> > > ---
> > >  drivers/gpu/drm/i915/i915_pci.c |  1 -
> > >  include/drm/i915_pciids.h       | 15 ++-------------
> > >  2 files changed, 2 insertions(+), 14 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/i915_pci.c
> > > b/drivers/gpu/drm/i915/i915_pci.c
> > > index 129877b..ecf6d4c 100644
> > > --- a/drivers/gpu/drm/i915/i915_pci.c
> > > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > > @@ -613,7 +613,6 @@ static const struct pci_device_id pciidlist[] =
> > > {
> > >  	INTEL_KBL_GT1_IDS(&intel_kabylake_gt1_info),
> > >  	INTEL_KBL_GT2_IDS(&intel_kabylake_gt2_info),
> > >  	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
> > > -	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
> > >  	INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
> > >  	INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
> > >  	INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
> > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > > index 1257e15..a1bf90e 100644
> > > --- a/include/drm/i915_pciids.h
> > > +++ b/include/drm/i915_pciids.h
> > > @@ -337,15 +337,10 @@
> > >  	INTEL_VGA_DEVICE(0x3185, info)
> > >  
> > >  #define INTEL_KBL_GT1_IDS(info)	\
> > > -	INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
> > > -	INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
> > >  	INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
> > >  	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
> > > -	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
> > >  	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
> > > -	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
> > > -	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
> > > -	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
> > > +	INTEL_VGA_DEVICE(0x590B, info)  /* Halo GT1 */
> > >  
> > >  #define INTEL_KBL_GT2_IDS(info)	\
> > >  	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
> > > @@ -353,22 +348,16 @@
> > >  	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
> > >  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
> > >  	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
> > > -	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
> > >  	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
> > >  
> > >  #define INTEL_KBL_GT3_IDS(info) \
> > > -	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
> > >  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> > >  	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
> > >  
> > > -#define INTEL_KBL_GT4_IDS(info) \
> > > -	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
> > > -
> > >  #define INTEL_KBL_IDS(info) \
> > >  	INTEL_KBL_GT1_IDS(info), \
> > >  	INTEL_KBL_GT2_IDS(info), \
> > > -	INTEL_KBL_GT3_IDS(info), \
> > > -	INTEL_KBL_GT4_IDS(info)
> > > +	INTEL_KBL_GT3_IDS(info)
> > >  
> > >  /* CFL S */
> > >  #define INTEL_CFL_S_GT1_IDS(info) \
> > > -- 
> > > 2.9.4
> > > 
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids
  2017-09-13  0:31     ` Rodrigo Vivi
@ 2017-09-20 19:08       ` Anuj Phogat
  0 siblings, 0 replies; 14+ messages in thread
From: Anuj Phogat @ 2017-09-20 19:08 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: mesa-dev, Intel GFX, Paulo Zanoni

Dropping this patch.

On Tue, Sep 12, 2017 at 5:31 PM, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Tue, Sep 12, 2017 at 08:30:47PM +0000, Paulo Zanoni wrote:
>> Em Seg, 2017-09-11 às 10:10 -0700, Rodrigo Vivi escreveu:
>> > On Mon, Sep 11, 2017 at 04:11:33PM +0000, Anuj Phogat wrote:
>> > > See Mesa commits: ebc5ccf and b2dae9f
>> >
>> > I believe we need to be in sync between multiple gfx stack
>> > components,
>> > but I  don't believe we should remove ids.
>> >
>> > In the past we had cases where we noticed a product group using a
>> > listed
>> > id to do a product and we just noticed the id after a user reported
>> > at fd.o.
>>
>> On the other hand, don't we have the risk that someone is going to see
>> that these IDs are unused for KBL and them repurpose them om some
>> future non-KBL product?
>
> There is only risk if the id was removed from Spec. But when that happens I'm in favor
> of removing from the components as well.
> While it is listed there even without POR it is reserved.
>
>>
>> >
>> > For us in kernel the cycle until that id gets into a stable release
>> > propagated to OSVs distros can be a bit long.
>> >
>> > Also Xserver ids are nowadays in sync with Mesa ones and I believe
>> > some
>> > OSVs might take a while to upgrade the Xserver as well in case of a
>> > new
>> > found product with some "new" id.
>> >
>> > For this reason I was always in favor of adding all possible reserved
>> > ids from the
>> > beginning.
>> >
>> > And this approach worked well on BDW and SKL, where we've seeing
>> > later some
>> > reserved ids becoming real product and we didn't have to do any extra
>> > step.
>> >
>> > For this same reason I believe the right solution is to
>> > add those ids back to mesa instead of removing from kernel and
>> > libdrm.
>> >
>> > Thanks,
>> > Rodrigo.
>> >
>> > >
>> > > Cc: Matt Turner <mattst88@gmail.com>
>> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> > > Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
>> > > ---
>> > >  drivers/gpu/drm/i915/i915_pci.c |  1 -
>> > >  include/drm/i915_pciids.h       | 15 ++-------------
>> > >  2 files changed, 2 insertions(+), 14 deletions(-)
>> > >
>> > > diff --git a/drivers/gpu/drm/i915/i915_pci.c
>> > > b/drivers/gpu/drm/i915/i915_pci.c
>> > > index 129877b..ecf6d4c 100644
>> > > --- a/drivers/gpu/drm/i915/i915_pci.c
>> > > +++ b/drivers/gpu/drm/i915/i915_pci.c
>> > > @@ -613,7 +613,6 @@ static const struct pci_device_id pciidlist[] =
>> > > {
>> > >   INTEL_KBL_GT1_IDS(&intel_kabylake_gt1_info),
>> > >   INTEL_KBL_GT2_IDS(&intel_kabylake_gt2_info),
>> > >   INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
>> > > - INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
>> > >   INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
>> > >   INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
>> > >   INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
>> > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
>> > > index 1257e15..a1bf90e 100644
>> > > --- a/include/drm/i915_pciids.h
>> > > +++ b/include/drm/i915_pciids.h
>> > > @@ -337,15 +337,10 @@
>> > >   INTEL_VGA_DEVICE(0x3185, info)
>> > >
>> > >  #define INTEL_KBL_GT1_IDS(info)  \
>> > > - INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
>> > > - INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
>> > >   INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
>> > >   INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
>> > > - INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
>> > >   INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
>> > > - INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
>> > > - INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
>> > > - INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
>> > > + INTEL_VGA_DEVICE(0x590B, info)  /* Halo GT1 */
>> > >
>> > >  #define INTEL_KBL_GT2_IDS(info)  \
>> > >   INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
>> > > @@ -353,22 +348,16 @@
>> > >   INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
>> > >   INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
>> > >   INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
>> > > - INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
>> > >   INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
>> > >
>> > >  #define INTEL_KBL_GT3_IDS(info) \
>> > > - INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
>> > >   INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
>> > >   INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
>> > >
>> > > -#define INTEL_KBL_GT4_IDS(info) \
>> > > - INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
>> > > -
>> > >  #define INTEL_KBL_IDS(info) \
>> > >   INTEL_KBL_GT1_IDS(info), \
>> > >   INTEL_KBL_GT2_IDS(info), \
>> > > - INTEL_KBL_GT3_IDS(info), \
>> > > - INTEL_KBL_GT4_IDS(info)
>> > > + INTEL_KBL_GT3_IDS(info)
>> > >
>> > >  /* CFL S */
>> > >  #define INTEL_CFL_S_GT1_IDS(info) \
>> > > --
>> > > 2.9.4
>> > >
>> > > _______________________________________________
>> > > Intel-gfx mailing list
>> > > Intel-gfx@lists.freedesktop.org
>> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH v2 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5
  2017-09-11 16:11 ` [PATCH 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5 Anuj Phogat
@ 2017-09-20 20:31   ` Anuj Phogat
  2017-09-20 21:34     ` Rodrigo Vivi
  0 siblings, 1 reply; 14+ messages in thread
From: Anuj Phogat @ 2017-09-20 20:31 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

See Mesa commit 9c588ff

Cc: Matt Turner <mattst88@gmail.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
---
 include/drm/i915_pciids.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 1257e15c1a03..972a25633525 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -339,7 +339,6 @@
 #define INTEL_KBL_GT1_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
 	INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
-	INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
 	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
 	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
 	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
@@ -349,6 +348,7 @@
 
 #define INTEL_KBL_GT2_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
+	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
 	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
 	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
-- 
2.13.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids (rev2)
  2017-09-11 16:11 [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids Anuj Phogat
                   ` (3 preceding siblings ...)
  2017-09-11 19:31 ` ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
@ 2017-09-20 20:39 ` Patchwork
  4 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2017-09-20 20:39 UTC (permalink / raw)
  To: Anuj Phogat; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids (rev2)
URL   : https://patchwork.freedesktop.org/series/30151/
State : failure

== Summary ==

  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CHK     scripts/mod/devicetable-offsets.h
  CHK     include/generated/compile.h
  CC      arch/x86/kernel/early-quirks.o
In file included from ./include/drm/i915_drm.h:29:0,
                 from arch/x86/kernel/early-quirks.c:19:
./include/drm/i915_pciids.h:38:36: error: expected identifier or ‘(’ before ‘{’ token
 #define INTEL_VGA_DEVICE(id, info) {  \
                                    ^
./include/drm/i915_pciids.h:341:2: note: in expansion of macro ‘INTEL_VGA_DEVICE’
  INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
  ^~~~~~~~~~~~~~~~
./include/drm/i915_pciids.h:341:32: error: expected identifier or ‘(’ before ‘,’ token
  INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
                                ^
./include/drm/i915_pciids.h:343:32: error: expected identifier or ‘(’ before ‘,’ token
  INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
                                ^
./include/drm/i915_pciids.h:344:32: error: expected identifier or ‘(’ before ‘,’ token
  INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
                                ^
./include/drm/i915_pciids.h:346:32: error: expected identifier or ‘(’ before ‘,’ token
  INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
                                ^
./include/drm/i915_pciids.h:347:32: error: expected identifier or ‘(’ before ‘,’ token
  INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
                                ^
./include/drm/i915_pciids.h:340:1: error: expected expression before ‘<<’ token
 <<<<<<< HEAD
 ^
./include/drm/i915_pciids.h:364:2: note: in expansion of macro ‘INTEL_KBL_GT1_IDS’
  INTEL_KBL_GT1_IDS(info), \
  ^~~~~~~~~~~~~~~~~
arch/x86/kernel/early-quirks.c:528:2: note: in expansion of macro ‘INTEL_KBL_IDS’
  INTEL_KBL_IDS(&gen9_early_ops),
  ^~~~~~~~~~~~~
scripts/Makefile.build:311: recipe for target 'arch/x86/kernel/early-quirks.o' failed
make[2]: *** [arch/x86/kernel/early-quirks.o] Error 1
scripts/Makefile.build:570: recipe for target 'arch/x86/kernel' failed
make[1]: *** [arch/x86/kernel] Error 2
Makefile:1019: recipe for target 'arch/x86' failed
make: *** [arch/x86] Error 2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5
  2017-09-20 20:31   ` [PATCH v2 " Anuj Phogat
@ 2017-09-20 21:34     ` Rodrigo Vivi
  2017-09-20 21:43       ` Anuj Phogat
  0 siblings, 1 reply; 14+ messages in thread
From: Rodrigo Vivi @ 2017-09-20 21:34 UTC (permalink / raw)
  To: Anuj Phogat; +Cc: intel-gfx

On Wed, Sep 20, 2017 at 08:31:26PM +0000, Anuj Phogat wrote:
> See Mesa commit 9c588ff
> 
> Cc: Matt Turner <mattst88@gmail.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  include/drm/i915_pciids.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 1257e15c1a03..972a25633525 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -339,7 +339,6 @@
>  #define INTEL_KBL_GT1_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
>  	INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
> -	INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
>  	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
>  	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
>  	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
> @@ -349,6 +348,7 @@
>  
>  #define INTEL_KBL_GT2_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
> +	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
>  	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
>  	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
>  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
> -- 
> 2.13.5
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5
  2017-09-20 21:34     ` Rodrigo Vivi
@ 2017-09-20 21:43       ` Anuj Phogat
  2017-09-21 13:23         ` Rodrigo Vivi
  0 siblings, 1 reply; 14+ messages in thread
From: Anuj Phogat @ 2017-09-20 21:43 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: Intel GFX

On Wed, Sep 20, 2017 at 2:34 PM, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Sep 20, 2017 at 08:31:26PM +0000, Anuj Phogat wrote:
>> See Mesa commit 9c588ff
>>
>> Cc: Matt Turner <mattst88@gmail.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
Thanks Rodrigo. Can you push it for me?
>> ---
>>  include/drm/i915_pciids.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
>> index 1257e15c1a03..972a25633525 100644
>> --- a/include/drm/i915_pciids.h
>> +++ b/include/drm/i915_pciids.h
>> @@ -339,7 +339,6 @@
>>  #define INTEL_KBL_GT1_IDS(info)      \
>>       INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
>>       INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
>> -     INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
>>       INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
>>       INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
>>       INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
>> @@ -349,6 +348,7 @@
>>
>>  #define INTEL_KBL_GT2_IDS(info)      \
>>       INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
>> +     INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
>>       INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
>>       INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
>>       INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
>> --
>> 2.13.5
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5
  2017-09-20 21:43       ` Anuj Phogat
@ 2017-09-21 13:23         ` Rodrigo Vivi
  0 siblings, 0 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2017-09-21 13:23 UTC (permalink / raw)
  To: Anuj Phogat; +Cc: Intel GFX

On Wed, Sep 20, 2017 at 09:43:38PM +0000, Anuj Phogat wrote:
> On Wed, Sep 20, 2017 at 2:34 PM, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > On Wed, Sep 20, 2017 at 08:31:26PM +0000, Anuj Phogat wrote:
> >> See Mesa commit 9c588ff
> >>
> >> Cc: Matt Turner <mattst88@gmail.com>
> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
> >
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >
> Thanks Rodrigo. Can you push it for me?

merged to dinq. Thanks for the patch and for organizing the ids acros the stack.

> >> ---
> >>  include/drm/i915_pciids.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> >> index 1257e15c1a03..972a25633525 100644
> >> --- a/include/drm/i915_pciids.h
> >> +++ b/include/drm/i915_pciids.h
> >> @@ -339,7 +339,6 @@
> >>  #define INTEL_KBL_GT1_IDS(info)      \
> >>       INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
> >>       INTEL_VGA_DEVICE(0x5915, info), /* ULX GT1.5 */ \
> >> -     INTEL_VGA_DEVICE(0x5917, info), /* DT  GT1.5 */ \
> >>       INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
> >>       INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
> >>       INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
> >> @@ -349,6 +348,7 @@
> >>
> >>  #define INTEL_KBL_GT2_IDS(info)      \
> >>       INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
> >> +     INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
> >>       INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
> >>       INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
> >>       INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
> >> --
> >> 2.13.5
> >>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-09-21 13:23 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-11 16:11 [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids Anuj Phogat
2017-09-11 16:11 ` [PATCH 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5 Anuj Phogat
2017-09-20 20:31   ` [PATCH v2 " Anuj Phogat
2017-09-20 21:34     ` Rodrigo Vivi
2017-09-20 21:43       ` Anuj Phogat
2017-09-21 13:23         ` Rodrigo Vivi
2017-09-11 16:31 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids Patchwork
2017-09-11 17:10 ` [Intel-gfx] [PATCH 1/2] " Rodrigo Vivi
2017-09-12 17:24   ` Anuj Phogat
2017-09-12 20:30   ` Paulo Zanoni
2017-09-13  0:31     ` Rodrigo Vivi
2017-09-20 19:08       ` Anuj Phogat
2017-09-11 19:31 ` ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
2017-09-20 20:39 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/kbl: Remove unused Kabylake pci ids (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.