* [merged] rbtree-add-some-additional-comments-for-rebalancing-cases.patch removed from -mm tree
@ 2017-09-11 19:41 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2017-09-11 19:41 UTC (permalink / raw)
To: dave, dbueso, mm-commits
The patch titled
Subject: rbtree: add some additional comments for rebalancing cases
has been removed from the -mm tree. Its filename was
rbtree-add-some-additional-comments-for-rebalancing-cases.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Davidlohr Bueso <dave@stgolabs.net>
Subject: rbtree: add some additional comments for rebalancing cases
While overall the code is very nicely commented, it might not be
immediately obvious from the diagrams what is going on. Add a very brief
summary of each case. Opposite cases where the node is the left child are
left untouched.
Link: http://lkml.kernel.org/r/20170719014603.19029-4-dave@stgolabs.net
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/rbtree.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff -puN lib/rbtree.c~rbtree-add-some-additional-comments-for-rebalancing-cases lib/rbtree.c
--- a/lib/rbtree.c~rbtree-add-some-additional-comments-for-rebalancing-cases
+++ a/lib/rbtree.c
@@ -132,7 +132,7 @@ __rb_insert(struct rb_node *node, struct
if (parent != tmp) { /* parent == gparent->rb_left */
if (tmp && rb_is_red(tmp)) {
/*
- * Case 1 - color flips
+ * Case 1 - node's uncle is red (color flips).
*
* G g
* / \ / \
@@ -155,7 +155,8 @@ __rb_insert(struct rb_node *node, struct
tmp = parent->rb_right;
if (node == tmp) {
/*
- * Case 2 - left rotate at parent
+ * Case 2 - node's uncle is black and node is
+ * the parent's right child (left rotate at parent).
*
* G G
* / \ / \
@@ -179,7 +180,8 @@ __rb_insert(struct rb_node *node, struct
}
/*
- * Case 3 - right rotate at gparent
+ * Case 3 - node's uncle is black and node is
+ * the parent's left child (right rotate at gparent).
*
* G P
* / \ / \
_
Patches currently in -mm which might be from dave@stgolabs.net are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-09-11 19:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-11 19:41 [merged] rbtree-add-some-additional-comments-for-rebalancing-cases.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.