* [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot
@ 2017-09-11 10:33 Viktor Mihajlovski
2017-09-11 10:53 ` Christian Borntraeger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Viktor Mihajlovski @ 2017-09-11 10:33 UTC (permalink / raw)
To: qemu-devel; +Cc: borntraeger, thuth
Setting the client architecture DHCP option to 0x001f (s390 Basic) [1]
allows the DHCP server to return a s390-specific bootfile if wanted.
DHCP servers not configured for the option (or not yet recognizing the
option value) will continue to work as they have done before.
[1] https://www.iana.org/assignments/dhcpv6-parameters
Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
---
pc-bios/s390-ccw/netboot.mak | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/netboot.mak b/pc-bios/s390-ccw/netboot.mak
index a9e1374..a25d238 100644
--- a/pc-bios/s390-ccw/netboot.mak
+++ b/pc-bios/s390-ccw/netboot.mak
@@ -50,7 +50,7 @@ libc.a: $(LIBCOBJS)
LIBNETOBJS := args.o dhcp.o dns.o icmpv6.o ipv6.o tcp.o udp.o bootp.o \
dhcpv6.o ethernet.o ipv4.o ndp.o tftp.o
-LIBNETCFLAGS := $(QEMU_CFLAGS) $(LIBC_INC) $(LIBNET_INC)
+LIBNETCFLAGS := $(QEMU_CFLAGS) -DDHCPARCH=0x1F $(LIBC_INC) $(LIBNET_INC)
%.o : $(SLOF_DIR)/lib/libnet/%.c
$(call quiet-command,$(CC) $(LIBNETCFLAGS) -c -o $@ $<,"CC","$(TARGET_DIR)$@")
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot
2017-09-11 10:33 [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot Viktor Mihajlovski
@ 2017-09-11 10:53 ` Christian Borntraeger
2017-09-11 13:58 ` Thomas Huth
2017-09-12 11:31 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Christian Borntraeger @ 2017-09-11 10:53 UTC (permalink / raw)
To: Viktor Mihajlovski, qemu-devel; +Cc: thuth, Cornelia Huck
On 09/11/2017 12:33 PM, Viktor Mihajlovski wrote:
> Setting the client architecture DHCP option to 0x001f (s390 Basic) [1]
> allows the DHCP server to return a s390-specific bootfile if wanted.
> DHCP servers not configured for the option (or not yet recognizing the
> option value) will continue to work as they have done before.
>
> [1] https://www.iana.org/assignments/dhcpv6-parameters
>
> Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Adding Cornelia. Conny as you have pending patches anyway, I assume
you can pick this up. Would be good if Thomas could give his Ack, though.
> ---
> pc-bios/s390-ccw/netboot.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/netboot.mak b/pc-bios/s390-ccw/netboot.mak
> index a9e1374..a25d238 100644
> --- a/pc-bios/s390-ccw/netboot.mak
> +++ b/pc-bios/s390-ccw/netboot.mak
> @@ -50,7 +50,7 @@ libc.a: $(LIBCOBJS)
>
> LIBNETOBJS := args.o dhcp.o dns.o icmpv6.o ipv6.o tcp.o udp.o bootp.o \
> dhcpv6.o ethernet.o ipv4.o ndp.o tftp.o
> -LIBNETCFLAGS := $(QEMU_CFLAGS) $(LIBC_INC) $(LIBNET_INC)
> +LIBNETCFLAGS := $(QEMU_CFLAGS) -DDHCPARCH=0x1F $(LIBC_INC) $(LIBNET_INC)
>
> %.o : $(SLOF_DIR)/lib/libnet/%.c
> $(call quiet-command,$(CC) $(LIBNETCFLAGS) -c -o $@ $<,"CC","$(TARGET_DIR)$@")
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot
2017-09-11 10:33 [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot Viktor Mihajlovski
2017-09-11 10:53 ` Christian Borntraeger
@ 2017-09-11 13:58 ` Thomas Huth
2017-09-11 14:44 ` Viktor Mihajlovski
2017-09-12 11:31 ` Cornelia Huck
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2017-09-11 13:58 UTC (permalink / raw)
To: Viktor Mihajlovski, qemu-devel; +Cc: borntraeger
On 11.09.2017 12:33, Viktor Mihajlovski wrote:
> Setting the client architecture DHCP option to 0x001f (s390 Basic) [1]
> allows the DHCP server to return a s390-specific bootfile if wanted.
> DHCP servers not configured for the option (or not yet recognizing the
> option value) will continue to work as they have done before.
>
> [1] https://www.iana.org/assignments/dhcpv6-parameters
Ah, nice, you already registered a value for s390x :-)
May I ask what's the difference between "Basic" and "Extended" there?
> Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
> ---
> pc-bios/s390-ccw/netboot.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/netboot.mak b/pc-bios/s390-ccw/netboot.mak
> index a9e1374..a25d238 100644
> --- a/pc-bios/s390-ccw/netboot.mak
> +++ b/pc-bios/s390-ccw/netboot.mak
> @@ -50,7 +50,7 @@ libc.a: $(LIBCOBJS)
>
> LIBNETOBJS := args.o dhcp.o dns.o icmpv6.o ipv6.o tcp.o udp.o bootp.o \
> dhcpv6.o ethernet.o ipv4.o ndp.o tftp.o
> -LIBNETCFLAGS := $(QEMU_CFLAGS) $(LIBC_INC) $(LIBNET_INC)
> +LIBNETCFLAGS := $(QEMU_CFLAGS) -DDHCPARCH=0x1F $(LIBC_INC) $(LIBNET_INC)
>
> %.o : $(SLOF_DIR)/lib/libnet/%.c
> $(call quiet-command,$(CC) $(LIBNETCFLAGS) -c -o $@ $<,"CC","$(TARGET_DIR)$@")
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot
2017-09-11 13:58 ` Thomas Huth
@ 2017-09-11 14:44 ` Viktor Mihajlovski
0 siblings, 0 replies; 5+ messages in thread
From: Viktor Mihajlovski @ 2017-09-11 14:44 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: borntraeger
On 11.09.2017 15:58, Thomas Huth wrote:
> On 11.09.2017 12:33, Viktor Mihajlovski wrote:
>> Setting the client architecture DHCP option to 0x001f (s390 Basic) [1]
>> allows the DHCP server to return a s390-specific bootfile if wanted.
>> DHCP servers not configured for the option (or not yet recognizing the
>> option value) will continue to work as they have done before.
>>
>> [1] https://www.iana.org/assignments/dhcpv6-parameters
>
> Ah, nice, you already registered a value for s390x :-)
> May I ask what's the difference between "Basic" and "Extended" there?
>
sure, "Basic" stands for the "classic netboot", i.e. a single binary
file is designated by the bootfile in the DHCP reply.
"Extended" is the mode implemented by Dynamic Partition Manager, where
the bootfile is some sort of configuration file.
[...]
--
Mit freundlichen Grüßen/Kind Regards
Viktor Mihajlovski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot
2017-09-11 10:33 [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot Viktor Mihajlovski
2017-09-11 10:53 ` Christian Borntraeger
2017-09-11 13:58 ` Thomas Huth
@ 2017-09-12 11:31 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2017-09-12 11:31 UTC (permalink / raw)
To: Viktor Mihajlovski; +Cc: qemu-devel, borntraeger, thuth
On Mon, 11 Sep 2017 12:33:47 +0200
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> wrote:
> Setting the client architecture DHCP option to 0x001f (s390 Basic) [1]
> allows the DHCP server to return a s390-specific bootfile if wanted.
> DHCP servers not configured for the option (or not yet recognizing the
> option value) will continue to work as they have done before.
>
> [1] https://www.iana.org/assignments/dhcpv6-parameters
>
> Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
> ---
> pc-bios/s390-ccw/netboot.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/netboot.mak b/pc-bios/s390-ccw/netboot.mak
> index a9e1374..a25d238 100644
> --- a/pc-bios/s390-ccw/netboot.mak
> +++ b/pc-bios/s390-ccw/netboot.mak
> @@ -50,7 +50,7 @@ libc.a: $(LIBCOBJS)
>
> LIBNETOBJS := args.o dhcp.o dns.o icmpv6.o ipv6.o tcp.o udp.o bootp.o \
> dhcpv6.o ethernet.o ipv4.o ndp.o tftp.o
> -LIBNETCFLAGS := $(QEMU_CFLAGS) $(LIBC_INC) $(LIBNET_INC)
> +LIBNETCFLAGS := $(QEMU_CFLAGS) -DDHCPARCH=0x1F $(LIBC_INC) $(LIBNET_INC)
>
> %.o : $(SLOF_DIR)/lib/libnet/%.c
> $(call quiet-command,$(CC) $(LIBNETCFLAGS) -c -o $@ $<,"CC","$(TARGET_DIR)$@")
Thanks, applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-12 11:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-11 10:33 [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot Viktor Mihajlovski
2017-09-11 10:53 ` Christian Borntraeger
2017-09-11 13:58 ` Thomas Huth
2017-09-11 14:44 ` Viktor Mihajlovski
2017-09-12 11:31 ` Cornelia Huck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.