* [CI] drm/i915: Squelch smatch warning for statement with no effect @ 2017-09-13 10:57 Chris Wilson 2017-09-13 11:39 ` ✓ Fi.CI.BAT: success for " Patchwork 2017-09-13 17:30 ` ✓ Fi.CI.IGT: " Patchwork 0 siblings, 2 replies; 4+ messages in thread From: Chris Wilson @ 2017-09-13 10:57 UTC (permalink / raw) To: intel-gfx The sgt iterators cause an drivers/gpu/drm/i915/i915_gpu_error.c:846 i915_error_object_create() warn: statement has no effect 7 everywhere they are used. If we change the code slightly, we can achieve the same increment without altering the output or raising a warning. text data bss dec hex filename 1267906 20587 3168 1291661 13b58d before 1267906 20587 3168 1291661 13b58d after Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 1cc31a5b049f..068c35e49d99 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -2834,8 +2834,8 @@ static inline struct scatterlist *__sg_next(struct scatterlist *sg) #define for_each_sgt_dma(__dmap, __iter, __sgt) \ for ((__iter) = __sgt_iter((__sgt)->sgl, true); \ ((__dmap) = (__iter).dma + (__iter).curr); \ - (((__iter).curr += PAGE_SIZE) < (__iter).max) || \ - ((__iter) = __sgt_iter(__sg_next((__iter).sgp), true), 0)) + (((__iter).curr += PAGE_SIZE) >= (__iter).max) ? \ + (__iter) = __sgt_iter(__sg_next((__iter).sgp), true), 0 : 0) /** * for_each_sgt_page - iterate over the pages of the given sg_table @@ -2847,8 +2847,8 @@ static inline struct scatterlist *__sg_next(struct scatterlist *sg) for ((__iter) = __sgt_iter((__sgt)->sgl, false); \ ((__pp) = (__iter).pfn == 0 ? NULL : \ pfn_to_page((__iter).pfn + ((__iter).curr >> PAGE_SHIFT))); \ - (((__iter).curr += PAGE_SIZE) < (__iter).max) || \ - ((__iter) = __sgt_iter(__sg_next((__iter).sgp), false), 0)) + (((__iter).curr += PAGE_SIZE) >= (__iter).max) ? \ + (__iter) = __sgt_iter(__sg_next((__iter).sgp), false), 0 : 0) static inline unsigned int i915_sg_segment_size(void) { -- 2.14.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Squelch smatch warning for statement with no effect 2017-09-13 10:57 [CI] drm/i915: Squelch smatch warning for statement with no effect Chris Wilson @ 2017-09-13 11:39 ` Patchwork 2017-09-13 13:01 ` Chris Wilson 2017-09-13 17:30 ` ✓ Fi.CI.IGT: " Patchwork 1 sibling, 1 reply; 4+ messages in thread From: Patchwork @ 2017-09-13 11:39 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Squelch smatch warning for statement with no effect URL : https://patchwork.freedesktop.org/series/30280/ State : success == Summary == Series 30280v1 drm/i915: Squelch smatch warning for statement with no effect https://patchwork.freedesktop.org/api/1.0/series/30280/revisions/1/mbox/ Test kms_cursor_legacy: Subgroup basic-busy-flip-before-cursor-atomic: fail -> PASS (fi-snb-2600) fdo#100215 Test kms_flip: Subgroup basic-flip-vs-modeset: skip -> PASS (fi-skl-x1585l) fdo#101781 Subgroup basic-flip-vs-wf_vblank: fail -> PASS (fi-ivb-3520m) fdo#102699 fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215 fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781 fdo#102699 https://bugs.freedesktop.org/show_bug.cgi?id=102699 fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:443s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:464s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:375s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:534s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:269s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:506s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:504s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:489s fi-cfl-s total:289 pass:223 dwarn:34 dfail:0 fail:0 skip:32 time:544s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:451s fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:591s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:426s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:410s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:442s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:494s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:463s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:490s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:575s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:583s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:556s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:456s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:520s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:504s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:463s fi-skl-x1585l total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:502s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:570s fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:428s 29603d09af9af9882a230162fd50674ff94aa05c drm-tip: 2017y-09m-13d-09h-38m-49s UTC integration manifest e25fd662cd69 drm/i915: Squelch smatch warning for statement with no effect == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5680/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm/i915: Squelch smatch warning for statement with no effect 2017-09-13 11:39 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2017-09-13 13:01 ` Chris Wilson 0 siblings, 0 replies; 4+ messages in thread From: Chris Wilson @ 2017-09-13 13:01 UTC (permalink / raw) To: Patchwork; +Cc: intel-gfx Quoting Patchwork (2017-09-13 12:39:46) > == Series Details == > > Series: drm/i915: Squelch smatch warning for statement with no effect > URL : https://patchwork.freedesktop.org/series/30280/ > State : success > > == Summary == > > Series 30280v1 drm/i915: Squelch smatch warning for statement with no effect > https://patchwork.freedesktop.org/api/1.0/series/30280/revisions/1/mbox/ > > Test kms_cursor_legacy: > Subgroup basic-busy-flip-before-cursor-atomic: > fail -> PASS (fi-snb-2600) fdo#100215 > Test kms_flip: > Subgroup basic-flip-vs-modeset: > skip -> PASS (fi-skl-x1585l) fdo#101781 > Subgroup basic-flip-vs-wf_vblank: > fail -> PASS (fi-ivb-3520m) fdo#102699 > > fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215 > fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781 > fdo#102699 https://bugs.freedesktop.org/show_bug.cgi?id=102699 Applied. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Squelch smatch warning for statement with no effect 2017-09-13 10:57 [CI] drm/i915: Squelch smatch warning for statement with no effect Chris Wilson 2017-09-13 11:39 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2017-09-13 17:30 ` Patchwork 1 sibling, 0 replies; 4+ messages in thread From: Patchwork @ 2017-09-13 17:30 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Squelch smatch warning for statement with no effect URL : https://patchwork.freedesktop.org/series/30280/ State : success == Summary == Test kms_plane: Subgroup plane-panning-bottom-right-suspend-pipe-C-planes: skip -> PASS (shard-hsw) Test perf: Subgroup polling: pass -> FAIL (shard-hsw) fdo#102252 Test prime_self_import: Subgroup reimport-vs-gem_close-race: pass -> FAIL (shard-hsw) fdo#102696 fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252 fdo#102696 https://bugs.freedesktop.org/show_bug.cgi?id=102696 shard-hsw total:2419 pass:1321 dwarn:2 dfail:0 fail:15 skip:1081 time:9692s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5680/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-13 17:30 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-13 10:57 [CI] drm/i915: Squelch smatch warning for statement with no effect Chris Wilson 2017-09-13 11:39 ` ✓ Fi.CI.BAT: success for " Patchwork 2017-09-13 13:01 ` Chris Wilson 2017-09-13 17:30 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.