* [PATCH igt] igt/gem_linear_blits: Compute GTT size using 4G limit
@ 2017-09-12 15:14 Chris Wilson
2017-09-12 16:56 ` ✓ Fi.CI.BAT: success for " Patchwork
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Chris Wilson @ 2017-09-12 15:14 UTC (permalink / raw)
To: intel-gfx
Both gem_linear_blits and gem_tiled_blit do not request the full 48b
GTT layout for their objects, restricting themselves to 4G. The
underlying test that they trigger eviction is unaffected by this
restriction, so we can simply reduce their memory requirements to fill
the low 4G GTT space and so allow them to run on 48b machines.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/gem_linear_blits.c | 18 ++++++++++++++----
tests/gem_tiled_blits.c | 16 ++++++++++++----
2 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/tests/gem_linear_blits.c b/tests/gem_linear_blits.c
index eccfbcdd..8297416c 100644
--- a/tests/gem_linear_blits.c
+++ b/tests/gem_linear_blits.c
@@ -215,6 +215,8 @@ static void run_test(int fd, int count)
free(handle);
}
+#define MAX_32b ((1ull << 32) - 4096)
+
int main(int argc, char **argv)
{
int fd = 0;
@@ -230,20 +232,28 @@ int main(int argc, char **argv)
run_test(fd, 2);
igt_subtest("normal") {
- int count;
+ uint64_t count;
- count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
+ count = gem_aperture_size(fd);
+ if (count >> 32)
+ count = MAX_32b;
+ count = 3 * count / (1024*1024) / 2;
igt_require(count > 1);
intel_require_memory(count, sizeof(linear), CHECK_RAM);
+
run_test(fd, count);
}
igt_subtest("interruptible") {
- int count;
+ uint64_t count;
- count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
+ count = gem_aperture_size(fd);
+ if (count >> 32)
+ count = MAX_32b;
+ count = 3 * count / (1024*1024) / 2;
igt_require(count > 1);
intel_require_memory(count, sizeof(linear), CHECK_RAM);
+
igt_fork_signal_helper();
run_test(fd, count);
igt_stop_signal_helper();
diff --git a/tests/gem_tiled_blits.c b/tests/gem_tiled_blits.c
index 7dcfc962..a81226a1 100644
--- a/tests/gem_tiled_blits.c
+++ b/tests/gem_tiled_blits.c
@@ -192,6 +192,8 @@ static void run_test(int count)
free(bo);
}
+#define MAX_32b ((1ull << 32) - 4096)
+
int fd;
int main(int argc, char **argv)
@@ -212,9 +214,12 @@ int main(int argc, char **argv)
run_test(2);
igt_subtest("normal") {
- int count;
+ uint64_t count;
- count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
+ count = gem_aperture_size(fd);
+ if (count >> 32)
+ count = MAX_32b;
+ count = 3 * count / (1024*1024) / 2;
count += (count & 1) == 0;
intel_require_memory(count, 1024*1024, CHECK_RAM);
@@ -222,9 +227,12 @@ int main(int argc, char **argv)
}
igt_subtest("interruptible") {
- int count;
+ uint64_t count;
- count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
+ count = gem_aperture_size(fd);
+ if (count >> 32)
+ count = MAX_32b;
+ count = 3 * count / (1024*1024) / 2;
count += (count & 1) == 0;
intel_require_memory(count, 1024*1024, CHECK_RAM);
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for igt/gem_linear_blits: Compute GTT size using 4G limit
2017-09-12 15:14 [PATCH igt] igt/gem_linear_blits: Compute GTT size using 4G limit Chris Wilson
@ 2017-09-12 16:56 ` Patchwork
2017-09-12 22:09 ` ✗ Fi.CI.IGT: warning " Patchwork
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2017-09-12 16:56 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_linear_blits: Compute GTT size using 4G limit
URL : https://patchwork.freedesktop.org/series/30216/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
c7e116007e907f32c18cc2669e2dc4046553c8e6 igt/sw_sync: Fix up close(timeline) tests for unsignaled fences
with latest DRM-Tip kernel build CI_DRM_3077
694f07d3df18 drm-tip: 2017y-09m-12d-09h-59m-00s UTC integration manifest
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
pass -> FAIL (fi-snb-2600) fdo#100215
Test kms_flip:
Subgroup basic-flip-vs-modeset:
skip -> PASS (fi-skl-x1585l) fdo#101781
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:449s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:460s
fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:377s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:531s
fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:270s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:510s
fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:503s
fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:506s
fi-cfl-s total:289 pass:250 dwarn:4 dfail:0 fail:0 skip:35 time:459s
fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:458s
fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:603s
fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:434s
fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:413s
fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:441s
fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:484s
fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:469s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:493s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:584s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:588s
fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:550s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:461s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:524s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:499s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:455s
fi-skl-x1585l total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:504s
fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:579s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:1 skip:39 time:430s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_177/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.IGT: warning for igt/gem_linear_blits: Compute GTT size using 4G limit
2017-09-12 15:14 [PATCH igt] igt/gem_linear_blits: Compute GTT size using 4G limit Chris Wilson
2017-09-12 16:56 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-09-12 22:09 ` Patchwork
2017-09-13 10:39 ` [PATCH igt v2] " Chris Wilson
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2017-09-12 22:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_linear_blits: Compute GTT size using 4G limit
URL : https://patchwork.freedesktop.org/series/30216/
State : warning
== Summary ==
Test perf:
Subgroup blocking:
pass -> FAIL (shard-hsw) fdo#102252
Test sw_sync:
Subgroup timeline_closed:
fail -> PASS (shard-hsw) fdo#102650
Test kms_chv_cursor_fail:
Subgroup pipe-A-128x128-bottom-edge:
pass -> SKIP (shard-hsw)
Subgroup pipe-B-128x128-top-edge:
pass -> SKIP (shard-hsw)
Subgroup pipe-A-64x64-left-edge:
pass -> SKIP (shard-hsw)
Test kms_draw_crc:
Subgroup draw-method-xrgb2101010-blt-xtiled:
pass -> SKIP (shard-hsw)
Subgroup draw-method-xrgb8888-blt-xtiled:
pass -> SKIP (shard-hsw)
Test kms_fbc_crc:
Subgroup blt:
pass -> SKIP (shard-hsw)
Test kms_atomic_transition:
Subgroup plane-all-transition-fencing:
pass -> SKIP (shard-hsw)
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102650 https://bugs.freedesktop.org/show_bug.cgi?id=102650
shard-hsw total:2419 pass:1319 dwarn:0 dfail:0 fail:12 skip:1088 time:9583s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_177/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH igt v2] igt/gem_linear_blits: Compute GTT size using 4G limit
2017-09-12 15:14 [PATCH igt] igt/gem_linear_blits: Compute GTT size using 4G limit Chris Wilson
2017-09-12 16:56 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-12 22:09 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-09-13 10:39 ` Chris Wilson
2017-12-15 12:22 ` Chris Wilson
2017-09-13 11:04 ` ✓ Fi.CI.BAT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2) Patchwork
` (3 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2017-09-13 10:39 UTC (permalink / raw)
To: intel-gfx
Both gem_linear_blits and gem_tiled_blit do not request the full 48b
GTT layout for their objects, restricting themselves to 4G. The
underlying test that they trigger eviction is unaffected by this
restriction, so we can simply reduce their memory requirements to fill
the low 4G GTT space and so allow them to run on 48b machines.
v2: gem_tiled_fenced_blits as well
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/gem_linear_blits.c | 18 ++++++++++++++----
tests/gem_tiled_blits.c | 16 ++++++++++++----
tests/gem_tiled_fence_blits.c | 11 +++++++++--
3 files changed, 35 insertions(+), 10 deletions(-)
diff --git a/tests/gem_linear_blits.c b/tests/gem_linear_blits.c
index eccfbcdd..8297416c 100644
--- a/tests/gem_linear_blits.c
+++ b/tests/gem_linear_blits.c
@@ -215,6 +215,8 @@ static void run_test(int fd, int count)
free(handle);
}
+#define MAX_32b ((1ull << 32) - 4096)
+
int main(int argc, char **argv)
{
int fd = 0;
@@ -230,20 +232,28 @@ int main(int argc, char **argv)
run_test(fd, 2);
igt_subtest("normal") {
- int count;
+ uint64_t count;
- count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
+ count = gem_aperture_size(fd);
+ if (count >> 32)
+ count = MAX_32b;
+ count = 3 * count / (1024*1024) / 2;
igt_require(count > 1);
intel_require_memory(count, sizeof(linear), CHECK_RAM);
+
run_test(fd, count);
}
igt_subtest("interruptible") {
- int count;
+ uint64_t count;
- count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
+ count = gem_aperture_size(fd);
+ if (count >> 32)
+ count = MAX_32b;
+ count = 3 * count / (1024*1024) / 2;
igt_require(count > 1);
intel_require_memory(count, sizeof(linear), CHECK_RAM);
+
igt_fork_signal_helper();
run_test(fd, count);
igt_stop_signal_helper();
diff --git a/tests/gem_tiled_blits.c b/tests/gem_tiled_blits.c
index 7dcfc962..a81226a1 100644
--- a/tests/gem_tiled_blits.c
+++ b/tests/gem_tiled_blits.c
@@ -192,6 +192,8 @@ static void run_test(int count)
free(bo);
}
+#define MAX_32b ((1ull << 32) - 4096)
+
int fd;
int main(int argc, char **argv)
@@ -212,9 +214,12 @@ int main(int argc, char **argv)
run_test(2);
igt_subtest("normal") {
- int count;
+ uint64_t count;
- count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
+ count = gem_aperture_size(fd);
+ if (count >> 32)
+ count = MAX_32b;
+ count = 3 * count / (1024*1024) / 2;
count += (count & 1) == 0;
intel_require_memory(count, 1024*1024, CHECK_RAM);
@@ -222,9 +227,12 @@ int main(int argc, char **argv)
}
igt_subtest("interruptible") {
- int count;
+ uint64_t count;
- count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
+ count = gem_aperture_size(fd);
+ if (count >> 32)
+ count = MAX_32b;
+ count = 3 * count / (1024*1024) / 2;
count += (count & 1) == 0;
intel_require_memory(count, 1024*1024, CHECK_RAM);
diff --git a/tests/gem_tiled_fence_blits.c b/tests/gem_tiled_fence_blits.c
index eb6473bc..51f672fd 100644
--- a/tests/gem_tiled_fence_blits.c
+++ b/tests/gem_tiled_fence_blits.c
@@ -160,9 +160,11 @@ static void run_test (int fd, int count)
drm_intel_bufmgr_destroy(bufmgr);
}
+#define MAX_32b ((1ull << 32) - 4096)
+
igt_main
{
- int fd, count;
+ int fd;
igt_fixture {
fd = drm_open_driver(DRIVER_INTEL);
@@ -177,7 +179,12 @@ igt_main
igt_skip_on_simulation();
igt_subtest("normal") {
- count = 3 * gem_aperture_size(fd) / (bo_size) / 2;
+ uint64_t count;
+
+ count = gem_aperture_size(fd);
+ if (count >> 32)
+ count = MAX_32b;
+ count = 3 * count / bo_size / 2;
intel_require_memory(count, bo_size, CHECK_RAM);
run_test(fd, count);
}
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)
2017-09-12 15:14 [PATCH igt] igt/gem_linear_blits: Compute GTT size using 4G limit Chris Wilson
` (2 preceding siblings ...)
2017-09-13 10:39 ` [PATCH igt v2] " Chris Wilson
@ 2017-09-13 11:04 ` Patchwork
2017-09-13 16:29 ` ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2017-09-13 11:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)
URL : https://patchwork.freedesktop.org/series/30216/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
b6ea8b204c8a18af7098326522e8acaffb19dd7a tests/tools_test: Make sure l3_parity is supported
with latest DRM-Tip kernel build CI_DRM_3083
29603d09af9a drm-tip: 2017y-09m-13d-09h-38m-49s UTC integration manifest
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
fail -> PASS (fi-snb-2600) fdo#100215
Test kms_flip:
Subgroup basic-flip-vs-modeset:
skip -> PASS (fi-skl-x1585l) fdo#101781
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (fi-ivb-3520m) fdo#102699
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#102699 https://bugs.freedesktop.org/show_bug.cgi?id=102699
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:448s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:451s
fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:377s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:540s
fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:267s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:506s
fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:512s
fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:499s
fi-cfl-s total:289 pass:223 dwarn:34 dfail:0 fail:0 skip:32 time:552s
fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:453s
fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:600s
fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:435s
fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:408s
fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:442s
fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:493s
fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:461s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:498s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:579s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:592s
fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:552s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:459s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:524s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:496s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:466s
fi-skl-x1585l total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:507s
fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:581s
fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:428s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_181/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.IGT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)
2017-09-12 15:14 [PATCH igt] igt/gem_linear_blits: Compute GTT size using 4G limit Chris Wilson
` (3 preceding siblings ...)
2017-09-13 11:04 ` ✓ Fi.CI.BAT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2) Patchwork
@ 2017-09-13 16:29 ` Patchwork
2017-12-19 11:20 ` ✓ Fi.CI.BAT: " Patchwork
2017-12-19 12:54 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2017-09-13 16:29 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)
URL : https://patchwork.freedesktop.org/series/30216/
State : success
== Summary ==
Test kms_plane:
Subgroup plane-panning-bottom-right-suspend-pipe-C-planes:
skip -> PASS (shard-hsw)
Test drv_module_reload:
Subgroup basic-reload-inject:
dmesg-warn -> PASS (shard-hsw) fdo#102707
Test perf:
Subgroup polling:
pass -> FAIL (shard-hsw) fdo#102252
Test gem_flink_race:
Subgroup flink_close:
pass -> FAIL (shard-hsw) fdo#102655
Test kms_busy:
Subgroup extended-modeset-hang-oldfb-with-reset-render-B:
dmesg-warn -> PASS (shard-hsw) fdo#102692
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102655 https://bugs.freedesktop.org/show_bug.cgi?id=102655
fdo#102692 https://bugs.freedesktop.org/show_bug.cgi?id=102692
shard-hsw total:2313 pass:1243 dwarn:0 dfail:0 fail:15 skip:1055 time:9453s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_181/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH igt v2] igt/gem_linear_blits: Compute GTT size using 4G limit
2017-09-13 10:39 ` [PATCH igt v2] " Chris Wilson
@ 2017-12-15 12:22 ` Chris Wilson
2017-12-19 10:59 ` Arkadiusz Hiler
0 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2017-12-15 12:22 UTC (permalink / raw)
To: intel-gfx
Quoting Chris Wilson (2017-09-13 11:39:14)
> Both gem_linear_blits and gem_tiled_blit do not request the full 48b
> GTT layout for their objects, restricting themselves to 4G. The
> underlying test that they trigger eviction is unaffected by this
> restriction, so we can simply reduce their memory requirements to fill
> the low 4G GTT space and so allow them to run on 48b machines.
>
> v2: gem_tiled_fenced_blits as well
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Ping ?
> ---
> tests/gem_linear_blits.c | 18 ++++++++++++++----
> tests/gem_tiled_blits.c | 16 ++++++++++++----
> tests/gem_tiled_fence_blits.c | 11 +++++++++--
> 3 files changed, 35 insertions(+), 10 deletions(-)
>
> diff --git a/tests/gem_linear_blits.c b/tests/gem_linear_blits.c
> index eccfbcdd..8297416c 100644
> --- a/tests/gem_linear_blits.c
> +++ b/tests/gem_linear_blits.c
> @@ -215,6 +215,8 @@ static void run_test(int fd, int count)
> free(handle);
> }
>
> +#define MAX_32b ((1ull << 32) - 4096)
> +
> int main(int argc, char **argv)
> {
> int fd = 0;
> @@ -230,20 +232,28 @@ int main(int argc, char **argv)
> run_test(fd, 2);
>
> igt_subtest("normal") {
> - int count;
> + uint64_t count;
>
> - count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
> + count = gem_aperture_size(fd);
> + if (count >> 32)
> + count = MAX_32b;
> + count = 3 * count / (1024*1024) / 2;
> igt_require(count > 1);
> intel_require_memory(count, sizeof(linear), CHECK_RAM);
> +
> run_test(fd, count);
> }
>
> igt_subtest("interruptible") {
> - int count;
> + uint64_t count;
>
> - count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
> + count = gem_aperture_size(fd);
> + if (count >> 32)
> + count = MAX_32b;
> + count = 3 * count / (1024*1024) / 2;
> igt_require(count > 1);
> intel_require_memory(count, sizeof(linear), CHECK_RAM);
> +
> igt_fork_signal_helper();
> run_test(fd, count);
> igt_stop_signal_helper();
> diff --git a/tests/gem_tiled_blits.c b/tests/gem_tiled_blits.c
> index 7dcfc962..a81226a1 100644
> --- a/tests/gem_tiled_blits.c
> +++ b/tests/gem_tiled_blits.c
> @@ -192,6 +192,8 @@ static void run_test(int count)
> free(bo);
> }
>
> +#define MAX_32b ((1ull << 32) - 4096)
> +
> int fd;
>
> int main(int argc, char **argv)
> @@ -212,9 +214,12 @@ int main(int argc, char **argv)
> run_test(2);
>
> igt_subtest("normal") {
> - int count;
> + uint64_t count;
>
> - count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
> + count = gem_aperture_size(fd);
> + if (count >> 32)
> + count = MAX_32b;
> + count = 3 * count / (1024*1024) / 2;
> count += (count & 1) == 0;
> intel_require_memory(count, 1024*1024, CHECK_RAM);
>
> @@ -222,9 +227,12 @@ int main(int argc, char **argv)
> }
>
> igt_subtest("interruptible") {
> - int count;
> + uint64_t count;
>
> - count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
> + count = gem_aperture_size(fd);
> + if (count >> 32)
> + count = MAX_32b;
> + count = 3 * count / (1024*1024) / 2;
> count += (count & 1) == 0;
> intel_require_memory(count, 1024*1024, CHECK_RAM);
>
> diff --git a/tests/gem_tiled_fence_blits.c b/tests/gem_tiled_fence_blits.c
> index eb6473bc..51f672fd 100644
> --- a/tests/gem_tiled_fence_blits.c
> +++ b/tests/gem_tiled_fence_blits.c
> @@ -160,9 +160,11 @@ static void run_test (int fd, int count)
> drm_intel_bufmgr_destroy(bufmgr);
> }
>
> +#define MAX_32b ((1ull << 32) - 4096)
> +
> igt_main
> {
> - int fd, count;
> + int fd;
>
> igt_fixture {
> fd = drm_open_driver(DRIVER_INTEL);
> @@ -177,7 +179,12 @@ igt_main
> igt_skip_on_simulation();
>
> igt_subtest("normal") {
> - count = 3 * gem_aperture_size(fd) / (bo_size) / 2;
> + uint64_t count;
> +
> + count = gem_aperture_size(fd);
> + if (count >> 32)
> + count = MAX_32b;
> + count = 3 * count / bo_size / 2;
> intel_require_memory(count, bo_size, CHECK_RAM);
> run_test(fd, count);
> }
> --
> 2.14.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH igt v2] igt/gem_linear_blits: Compute GTT size using 4G limit
2017-12-15 12:22 ` Chris Wilson
@ 2017-12-19 10:59 ` Arkadiusz Hiler
0 siblings, 0 replies; 10+ messages in thread
From: Arkadiusz Hiler @ 2017-12-19 10:59 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Dec 15, 2017 at 12:22:01PM +0000, Chris Wilson wrote:
> Quoting Chris Wilson (2017-09-13 11:39:14)
> > Both gem_linear_blits and gem_tiled_blit do not request the full 48b
> > GTT layout for their objects, restricting themselves to 4G. The
> > underlying test that they trigger eviction is unaffected by this
> > restriction, so we can simply reduce their memory requirements to fill
> > the low 4G GTT space and so allow them to run on 48b machines.
> >
> > v2: gem_tiled_fenced_blits as well
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Ping ?
Pong.
Requeued this for testing, as the old results seem to be lost in time
and space.
> > ---
> > tests/gem_linear_blits.c | 18 ++++++++++++++----
> > tests/gem_tiled_blits.c | 16 ++++++++++++----
> > tests/gem_tiled_fence_blits.c | 11 +++++++++--
> > 3 files changed, 35 insertions(+), 10 deletions(-)
> >
> > diff --git a/tests/gem_linear_blits.c b/tests/gem_linear_blits.c
> > index eccfbcdd..8297416c 100644
> > --- a/tests/gem_linear_blits.c
> > +++ b/tests/gem_linear_blits.c
> > @@ -215,6 +215,8 @@ static void run_test(int fd, int count)
> > free(handle);
> > }
> >
> > +#define MAX_32b ((1ull << 32) - 4096)
> > +
> > int main(int argc, char **argv)
> > {
> > int fd = 0;
> > @@ -230,20 +232,28 @@ int main(int argc, char **argv)
> > run_test(fd, 2);
> >
> > igt_subtest("normal") {
> > - int count;
> > + uint64_t count;
> >
> > - count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
> > + count = gem_aperture_size(fd);
> > + if (count >> 32)
> > + count = MAX_32b;
> > + count = 3 * count / (1024*1024) / 2;
Having that in 4 places may justify an introduction of a helper.
Nonetheless,
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
- Arek
> > igt_require(count > 1);
> > intel_require_memory(count, sizeof(linear), CHECK_RAM);
> > +
> > run_test(fd, count);
> > }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)
2017-09-12 15:14 [PATCH igt] igt/gem_linear_blits: Compute GTT size using 4G limit Chris Wilson
` (4 preceding siblings ...)
2017-09-13 16:29 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-12-19 11:20 ` Patchwork
2017-12-19 12:54 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2017-12-19 11:20 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)
URL : https://patchwork.freedesktop.org/series/30216/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
d3d04e5f74f05850f595c729fb0c00eb7dd9c688 scripts/trace.pl: Fix ring ignore
with latest DRM-Tip kernel build CI_DRM_3545
3e151c0e41e6 drm-tip: 2017y-12m-18d-22h-45m-04s UTC integration manifest
No testlist changes.
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> FAIL (fi-elk-e7500) fdo#103989 +1
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:441s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:436s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:387s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:495s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:277s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:495s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:498s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:477s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:482s
fi-elk-e7500 total:224 pass:162 dwarn:15 dfail:0 fail:1 skip:45
fi-gdg-551 total:288 pass:179 dwarn:1 dfail:0 fail:0 skip:108 time:265s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:528s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:405s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:413s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:385s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:486s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:428s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:480s
fi-kbl-7560u total:288 pass:268 dwarn:1 dfail:0 fail:0 skip:19 time:522s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:468s
fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:521s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:582s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:443s
fi-skl-6600u total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:527s
fi-skl-6700hq total:288 pass:261 dwarn:1 dfail:0 fail:0 skip:26 time:557s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:508s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:508s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:448s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:554s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:420s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:592s
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:486s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_700/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.IGT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)
2017-09-12 15:14 [PATCH igt] igt/gem_linear_blits: Compute GTT size using 4G limit Chris Wilson
` (5 preceding siblings ...)
2017-12-19 11:20 ` ✓ Fi.CI.BAT: " Patchwork
@ 2017-12-19 12:54 ` Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2017-12-19 12:54 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)
URL : https://patchwork.freedesktop.org/series/30216/
State : success
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS (shard-snb) fdo#101623 +1
Test kms_cursor_crc:
Subgroup cursor-256x85-sliding:
skip -> PASS (shard-hsw)
Test pm_rpm:
Subgroup universal-planes:
skip -> PASS (shard-hsw)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
skip -> PASS (shard-hsw)
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
shard-hsw total:2712 pass:1537 dwarn:1 dfail:0 fail:10 skip:1164 time:9427s
shard-snb total:2712 pass:1309 dwarn:1 dfail:0 fail:11 skip:1391 time:8003s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_700/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-12-19 12:54 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-12 15:14 [PATCH igt] igt/gem_linear_blits: Compute GTT size using 4G limit Chris Wilson
2017-09-12 16:56 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-12 22:09 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-09-13 10:39 ` [PATCH igt v2] " Chris Wilson
2017-12-15 12:22 ` Chris Wilson
2017-12-19 10:59 ` Arkadiusz Hiler
2017-09-13 11:04 ` ✓ Fi.CI.BAT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2) Patchwork
2017-09-13 16:29 ` ✓ Fi.CI.IGT: " Patchwork
2017-12-19 11:20 ` ✓ Fi.CI.BAT: " Patchwork
2017-12-19 12:54 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.