All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-initramfs][PATCH V3] klibc.bbclass: Add -mfloat-abi on arm
@ 2017-09-13 17:44 Khem Raj
  2017-09-13 18:24 ` Andre McCurdy
  0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2017-09-13 17:44 UTC (permalink / raw)
  To: openembedded-devel

Default toolchain is not configured for hard float
therefore we need to pass the right -mfloat-abi option

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
Changes in V3: Append -mfloat-abi only on armv6

 meta-initramfs/classes/klibc.bbclass                         | 2 ++
 meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass
index c9de58cec..1ec7b2b05 100644
--- a/meta-initramfs/classes/klibc.bbclass
+++ b/meta-initramfs/classes/klibc.bbclass
@@ -5,6 +5,8 @@ DEPENDS =+ "klcc-cross"
 # Set CC = "${TARGET_PREFIX}klcc -shared" to build the dynamic version.
 CC_forcevariable = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS}"
 CC_forcevariable_armv4_linux-gnueabi = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS} -march=armv4 -mthumb-interwork"
+CC_append_armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
+CC_append_armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
 
 CPP_forcevariable = "${CC} -E"
 
diff --git a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb
index 867407723..8ca1ca727 100644
--- a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb
+++ b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb
@@ -21,7 +21,6 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;tag=b7455d847ab4f9eeeb6a729efc3
 S = "${WORKDIR}/git/"
 
 EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
-CFLAGS += "${TUNE_CCARGS}"
 
 do_install () {
 
-- 
2.14.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [meta-initramfs][PATCH V3] klibc.bbclass: Add -mfloat-abi on arm
  2017-09-13 17:44 [meta-initramfs][PATCH V3] klibc.bbclass: Add -mfloat-abi on arm Khem Raj
@ 2017-09-13 18:24 ` Andre McCurdy
  2017-09-13 18:56   ` Khem Raj
  0 siblings, 1 reply; 3+ messages in thread
From: Andre McCurdy @ 2017-09-13 18:24 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

On Wed, Sep 13, 2017 at 10:44 AM, Khem Raj <raj.khem@gmail.com> wrote:
> Default toolchain is not configured for hard float
> therefore we need to pass the right -mfloat-abi option
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> Changes in V3: Append -mfloat-abi only on armv6

The change seems to be for armv7a and armv7ve, not armv6 ?

>  meta-initramfs/classes/klibc.bbclass                         | 2 ++
>  meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass
> index c9de58cec..1ec7b2b05 100644
> --- a/meta-initramfs/classes/klibc.bbclass
> +++ b/meta-initramfs/classes/klibc.bbclass
> @@ -5,6 +5,8 @@ DEPENDS =+ "klcc-cross"
>  # Set CC = "${TARGET_PREFIX}klcc -shared" to build the dynamic version.
>  CC_forcevariable = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS}"
>  CC_forcevariable_armv4_linux-gnueabi = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS} -march=armv4 -mthumb-interwork"
> +CC_append_armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
> +CC_append_armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
>
>  CPP_forcevariable = "${CC} -E"
>
> diff --git a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb
> index 867407723..8ca1ca727 100644
> --- a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb
> +++ b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb
> @@ -21,7 +21,6 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;tag=b7455d847ab4f9eeeb6a729efc3
>  S = "${WORKDIR}/git/"
>
>  EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
> -CFLAGS += "${TUNE_CCARGS}"
>
>  do_install () {
>
> --
> 2.14.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [meta-initramfs][PATCH V3] klibc.bbclass: Add -mfloat-abi on arm
  2017-09-13 18:24 ` Andre McCurdy
@ 2017-09-13 18:56   ` Khem Raj
  0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2017-09-13 18:56 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: openembeded-devel

On Wed, Sep 13, 2017 at 11:24 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Wed, Sep 13, 2017 at 10:44 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> Default toolchain is not configured for hard float
>> therefore we need to pass the right -mfloat-abi option
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> Changes in V3: Append -mfloat-abi only on armv6
>
> The change seems to be for armv7a and armv7ve, not armv6 ?

yes. its a typo in the comment I should have said arm7, I dont build for v6

>
>>  meta-initramfs/classes/klibc.bbclass                         | 2 ++
>>  meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb | 1 -
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-initramfs/classes/klibc.bbclass b/meta-initramfs/classes/klibc.bbclass
>> index c9de58cec..1ec7b2b05 100644
>> --- a/meta-initramfs/classes/klibc.bbclass
>> +++ b/meta-initramfs/classes/klibc.bbclass
>> @@ -5,6 +5,8 @@ DEPENDS =+ "klcc-cross"
>>  # Set CC = "${TARGET_PREFIX}klcc -shared" to build the dynamic version.
>>  CC_forcevariable = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS}"
>>  CC_forcevariable_armv4_linux-gnueabi = "${TARGET_PREFIX}klcc ${TOOLCHAIN_OPTIONS} -march=armv4 -mthumb-interwork"
>> +CC_append_armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
>> +CC_append_armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
>>
>>  CPP_forcevariable = "${CC} -E"
>>
>> diff --git a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb
>> index 867407723..8ca1ca727 100644
>> --- a/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb
>> +++ b/meta-initramfs/recipes-devtools/mtd/ubi-utils-klibc_1.5.1.bb
>> @@ -21,7 +21,6 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;tag=b7455d847ab4f9eeeb6a729efc3
>>  S = "${WORKDIR}/git/"
>>
>>  EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>> -CFLAGS += "${TUNE_CCARGS}"
>>
>>  do_install () {
>>
>> --
>> 2.14.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-13 18:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-13 17:44 [meta-initramfs][PATCH V3] klibc.bbclass: Add -mfloat-abi on arm Khem Raj
2017-09-13 18:24 ` Andre McCurdy
2017-09-13 18:56   ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.