* [PATCH] ALSA: hwdep: prevent a harmless shift wrapping bug
@ 2017-09-13 23:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-09-13 23:01 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: alsa-devel, kernel-janitors, Takashi Iwai
The "info.index" variable represents a bit in hw->dsp_loaded which is
an unsigned int. If it's higher than 31 we hit a shift wrapping bug.
This seems harmless, but I wanted to silence the static checker warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
index a73baa1242be..8faae3d1455d 100644
--- a/sound/core/hwdep.c
+++ b/sound/core/hwdep.c
@@ -228,6 +228,8 @@ static int snd_hwdep_dsp_load(struct snd_hwdep *hw,
memset(&info, 0, sizeof(info));
if (copy_from_user(&info, _info, sizeof(info)))
return -EFAULT;
+ if (info.index >= 32)
+ return -EINVAL;
/* check whether the dsp was already loaded */
if (hw->dsp_loaded & (1 << info.index))
return -EBUSY;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ALSA: hwdep: prevent a harmless shift wrapping bug
@ 2017-09-13 23:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-09-13 23:01 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: alsa-devel, kernel-janitors, Takashi Iwai
The "info.index" variable represents a bit in hw->dsp_loaded which is
an unsigned int. If it's higher than 31 we hit a shift wrapping bug.
This seems harmless, but I wanted to silence the static checker warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
index a73baa1242be..8faae3d1455d 100644
--- a/sound/core/hwdep.c
+++ b/sound/core/hwdep.c
@@ -228,6 +228,8 @@ static int snd_hwdep_dsp_load(struct snd_hwdep *hw,
memset(&info, 0, sizeof(info));
if (copy_from_user(&info, _info, sizeof(info)))
return -EFAULT;
+ if (info.index >= 32)
+ return -EINVAL;
/* check whether the dsp was already loaded */
if (hw->dsp_loaded & (1 << info.index))
return -EBUSY;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hwdep: prevent a harmless shift wrapping bug
2017-09-13 23:01 ` Dan Carpenter
@ 2017-09-18 13:39 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2017-09-18 13:39 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jaroslav Kysela, alsa-devel, kernel-janitors
On Thu, 14 Sep 2017 01:01:16 +0200,
Dan Carpenter wrote:
>
> The "info.index" variable represents a bit in hw->dsp_loaded which is
> an unsigned int. If it's higher than 31 we hit a shift wrapping bug.
> This seems harmless, but I wanted to silence the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hwdep: prevent a harmless shift wrapping bug
@ 2017-09-18 13:39 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2017-09-18 13:39 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jaroslav Kysela, alsa-devel, kernel-janitors
On Thu, 14 Sep 2017 01:01:16 +0200,
Dan Carpenter wrote:
>
> The "info.index" variable represents a bit in hw->dsp_loaded which is
> an unsigned int. If it's higher than 31 we hit a shift wrapping bug.
> This seems harmless, but I wanted to silence the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-18 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-13 23:01 [PATCH] ALSA: hwdep: prevent a harmless shift wrapping bug Dan Carpenter
2017-09-13 23:01 ` Dan Carpenter
2017-09-18 13:39 ` Takashi Iwai
2017-09-18 13:39 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.