* [U-Boot] [PATCH] Fix s25fl256s position in spi_flash_ids list
@ 2017-09-15 14:21 Vsevolod Gribov
2017-09-25 7:34 ` Jagan Teki
0 siblings, 1 reply; 2+ messages in thread
From: Vsevolod Gribov @ 2017-09-15 14:21 UTC (permalink / raw)
To: u-boot
Spansion S25FS256S and S25FL256S flashes have equal JEDEC ID and ext ID.
As far as S25FL256S occures in spi_flash_ids before S25FS256S, U-Boot
incorrectly detects FS flash as FL. Thus its better to compare with
S25FS256S first.
---
drivers/mtd/spi/spi_flash_ids.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi/spi_flash_ids.c b/drivers/mtd/spi/spi_flash_ids.c
index c4ccf48..906cc7b 100644
--- a/drivers/mtd/spi/spi_flash_ids.c
+++ b/drivers/mtd/spi/spi_flash_ids.c
@@ -100,8 +100,8 @@ const struct spi_flash_info spi_flash_ids[] = {
{"s25fl128s_256k", INFO(0x012018, 0x4d00, 256 * 1024, 64, RD_FULL | WR_QPP) },
{"s25fl128s_64k", INFO(0x012018, 0x4d01, 64 * 1024, 256, RD_FULL | WR_QPP) },
{"s25fl256s_256k", INFO(0x010219, 0x4d00, 256 * 1024, 128, RD_FULL | WR_QPP) },
- {"s25fl256s_64k", INFO(0x010219, 0x4d01, 64 * 1024, 512, RD_FULL | WR_QPP) },
{"s25fs256s_64k", INFO6(0x010219, 0x4d0181, 64 * 1024, 512, RD_FULL | WR_QPP | SECT_4K) },
+ {"s25fl256s_64k", INFO(0x010219, 0x4d01, 64 * 1024, 512, RD_FULL | WR_QPP) },
{"s25fs512s", INFO6(0x010220, 0x4d0081, 128 * 1024, 512, RD_FULL | WR_QPP | SECT_4K) },
{"s25fl512s_256k", INFO(0x010220, 0x4d00, 256 * 1024, 256, RD_FULL | WR_QPP) },
{"s25fl512s_64k", INFO(0x010220, 0x4d01, 64 * 1024, 1024, RD_FULL | WR_QPP) },
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] Fix s25fl256s position in spi_flash_ids list
2017-09-15 14:21 [U-Boot] [PATCH] Fix s25fl256s position in spi_flash_ids list Vsevolod Gribov
@ 2017-09-25 7:34 ` Jagan Teki
0 siblings, 0 replies; 2+ messages in thread
From: Jagan Teki @ 2017-09-25 7:34 UTC (permalink / raw)
To: u-boot
On Fri, Sep 15, 2017 at 7:51 PM, Vsevolod Gribov
<vgribov@larch-networks.com> wrote:
> Spansion S25FS256S and S25FL256S flashes have equal JEDEC ID and ext ID.
> As far as S25FL256S occures in spi_flash_ids before S25FS256S, U-Boot
> incorrectly detects FS flash as FL. Thus its better to compare with
> S25FS256S first.
> ---
Applied to u-boot-spi/master
thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-25 7:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-15 14:21 [U-Boot] [PATCH] Fix s25fl256s position in spi_flash_ids list Vsevolod Gribov
2017-09-25 7:34 ` Jagan Teki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.