* [net PATCH] bnxt_en: check for ingress qdisc in flower offload
@ 2017-09-18 11:35 Sathya Perla
2017-09-18 11:56 ` Jiri Pirko
2017-09-18 23:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sathya Perla @ 2017-09-18 11:35 UTC (permalink / raw)
To: netdev; +Cc: michael.chan
Check for ingress-only qdisc for flower offload, as other qdiscs
are not supported for flower offload.
Suggested-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Sathya Perla <sathya.perla@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
index ccd699f..7dd3d13 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
@@ -750,6 +750,10 @@ int bnxt_tc_setup_flower(struct bnxt *bp, u16 src_fid,
{
int rc = 0;
+ if (!is_classid_clsact_ingress(cls_flower->common.classid) ||
+ cls_flower->common.chain_index)
+ return -EOPNOTSUPP;
+
switch (cls_flower->command) {
case TC_CLSFLOWER_REPLACE:
rc = bnxt_tc_add_flow(bp, src_fid, cls_flower);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net PATCH] bnxt_en: check for ingress qdisc in flower offload
2017-09-18 11:35 [net PATCH] bnxt_en: check for ingress qdisc in flower offload Sathya Perla
@ 2017-09-18 11:56 ` Jiri Pirko
2017-09-18 23:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2017-09-18 11:56 UTC (permalink / raw)
To: Sathya Perla; +Cc: netdev, michael.chan
Mon, Sep 18, 2017 at 01:35:37PM CEST, sathya.perla@broadcom.com wrote:
>Check for ingress-only qdisc for flower offload, as other qdiscs
>are not supported for flower offload.
>
>Suggested-by: Jiri Pirko <jiri@resnulli.us>
>Signed-off-by: Sathya Perla <sathya.perla@broadcom.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net PATCH] bnxt_en: check for ingress qdisc in flower offload
2017-09-18 11:35 [net PATCH] bnxt_en: check for ingress qdisc in flower offload Sathya Perla
2017-09-18 11:56 ` Jiri Pirko
@ 2017-09-18 23:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-09-18 23:52 UTC (permalink / raw)
To: sathya.perla; +Cc: netdev, michael.chan
From: Sathya Perla <sathya.perla@broadcom.com>
Date: Mon, 18 Sep 2017 17:05:37 +0530
> Check for ingress-only qdisc for flower offload, as other qdiscs
> are not supported for flower offload.
>
> Suggested-by: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: Sathya Perla <sathya.perla@broadcom.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-18 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-18 11:35 [net PATCH] bnxt_en: check for ingress qdisc in flower offload Sathya Perla
2017-09-18 11:56 ` Jiri Pirko
2017-09-18 23:52 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.