All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] test-lib: use more compact expression in PIPE prerequisite
@ 2017-09-17 22:56 Ramsay Jones
  2017-09-19  2:50 ` Jonathan Nieder
  0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2017-09-17 22:56 UTC (permalink / raw)
  To: Junio C Hamano
  Cc: Michael J Gruber, Adam Dinwoodie, Jeff King, GIT Mailing-list


Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
 t/test-lib.sh | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 32f9b2001..9b61f16f7 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -1067,14 +1067,8 @@ test_i18ngrep () {
 
 test_lazy_prereq PIPE '
 	# test whether the filesystem supports FIFOs
-	case $(uname -s) in
-	CYGWIN*|MINGW*)
-		false
-		;;
-	*)
-		rm -f testfifo && mkfifo testfifo
-		;;
-	esac
+	test_have_prereq !MINGW,!CYGWIN &&
+	rm -f testfifo && mkfifo testfifo
 '
 
 test_lazy_prereq SYMLINKS '
-- 
2.14.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] test-lib: use more compact expression in PIPE prerequisite
  2017-09-17 22:56 [PATCH 1/2] test-lib: use more compact expression in PIPE prerequisite Ramsay Jones
@ 2017-09-19  2:50 ` Jonathan Nieder
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2017-09-19  2:50 UTC (permalink / raw)
  To: Ramsay Jones
  Cc: Junio C Hamano, Michael J Gruber, Adam Dinwoodie, Jeff King,
	GIT Mailing-list

Ramsay Jones wrote:

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  t/test-lib.sh | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-19  2:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-17 22:56 [PATCH 1/2] test-lib: use more compact expression in PIPE prerequisite Ramsay Jones
2017-09-19  2:50 ` Jonathan Nieder

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.