* [PATCH 1/2] sanity: correct Python version sanity check
@ 2017-09-20 12:59 Ross Burton
2017-09-20 12:59 ` [PATCH 2/2] sanity: check that path variables don't use ~ Ross Burton
0 siblings, 1 reply; 2+ messages in thread
From: Ross Burton @ 2017-09-20 12:59 UTC (permalink / raw)
To: openembedded-core
We now require Python 3.4, not 2.7.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/classes/sanity.bbclass | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 5699287a4a2..91b92ec28a8 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -702,10 +702,10 @@ def check_sanity_everybuild(status, d):
if 0 == os.getuid():
raise_sanity_error("Do not use Bitbake as root.", d)
- # Check the Python version, we now have a minimum of Python 2.7.3
+ # Check the Python version, we now have a minimum of Python 3.4
import sys
- if sys.hexversion < 0x020703F0:
- status.addresult('The system requires at least Python 2.7.3 to run. Please update your Python interpreter.\n')
+ if sys.hexversion < 0x03040000:
+ status.addresult('The system requires at least Python 3.4 to run. Please update your Python interpreter.\n')
# Check the bitbake version meets minimum requirements
from distutils.version import LooseVersion
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] sanity: check that path variables don't use ~
2017-09-20 12:59 [PATCH 1/2] sanity: correct Python version sanity check Ross Burton
@ 2017-09-20 12:59 ` Ross Burton
0 siblings, 0 replies; 2+ messages in thread
From: Ross Burton @ 2017-09-20 12:59 UTC (permalink / raw)
To: openembedded-core
The core path variables (TMPDIR, DL_DIR, SSTATE_DIR) don't use tilde expansion
but if the user does then the errors are very mysterious, so check on startup.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/classes/sanity.bbclass | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 91b92ec28a8..1feb7949daa 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -726,6 +726,11 @@ def check_sanity_everybuild(status, d):
if not ( check_conf_exists("conf/distro/${DISTRO}.conf", d) or check_conf_exists("conf/distro/include/${DISTRO}.inc", d) ):
status.addresult("DISTRO '%s' not found. Please set a valid DISTRO in your local.conf\n" % d.getVar("DISTRO"))
+ # Check that these variables don't use tilde-expansion as we don't do that
+ for v in ("TMPDIR", "DL_DIR", "SSTATE_DIR"):
+ if d.getVar(v).startswith("~"):
+ status.addresult("%s uses ~ but Bitbake will not expand this, use an absolute path or variables." % v)
+
# Check that DL_DIR is set, exists and is writable. In theory, we should never even hit the check if DL_DIR isn't
# set, since so much relies on it being set.
dldir = d.getVar('DL_DIR')
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-20 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-20 12:59 [PATCH 1/2] sanity: correct Python version sanity check Ross Burton
2017-09-20 12:59 ` [PATCH 2/2] sanity: check that path variables don't use ~ Ross Burton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.