All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <keith.busch@intel.com>,
	Hannes Reinecke <hare@suse.de>,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable
Date: Thu, 21 Sep 2017 16:10:33 +0200	[thread overview]
Message-ID: <20170921141033.GA17575@lst.de> (raw)
In-Reply-To: <20170921051915.cfj2j5vu4bjqn5za@linux-x5ow.site>

On Thu, Sep 21, 2017 at 07:19:15AM +0200, Johannes Thumshirn wrote:
> So why exposing it then in the first time?

It is a really nice debug aid, but the states really are an internal
detail of the implementation, and can (and probably will soon, see the
fc states discussion) change.

Maybe we need to move things like this to debugfs, but yet another
interface seems a little annoying.

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: make controller 'state' sysfs attribute pollable
Date: Thu, 21 Sep 2017 16:10:33 +0200	[thread overview]
Message-ID: <20170921141033.GA17575@lst.de> (raw)
In-Reply-To: <20170921051915.cfj2j5vu4bjqn5za@linux-x5ow.site>

On Thu, Sep 21, 2017@07:19:15AM +0200, Johannes Thumshirn wrote:
> So why exposing it then in the first time?

It is a really nice debug aid, but the states really are an internal
detail of the implementation, and can (and probably will soon, see the
fc states discussion) change.

Maybe we need to move things like this to debugfs, but yet another
interface seems a little annoying.

  reply	other threads:[~2017-09-21 14:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20 10:40 [PATCH] nvme: make controller 'state' sysfs attribute pollable Johannes Thumshirn
2017-09-20 10:40 ` Johannes Thumshirn
2017-09-20 10:49 ` Sagi Grimberg
2017-09-20 10:49   ` Sagi Grimberg
2017-09-20 14:59 ` Christoph Hellwig
2017-09-20 14:59   ` Christoph Hellwig
2017-09-21  5:19   ` Johannes Thumshirn
2017-09-21  5:19     ` Johannes Thumshirn
2017-09-21 14:10     ` Christoph Hellwig [this message]
2017-09-21 14:10       ` Christoph Hellwig
2017-09-25  5:37     ` Sagi Grimberg
2017-09-25  5:37       ` Sagi Grimberg
2017-09-25  5:59       ` Hannes Reinecke
2017-09-25  5:59         ` Hannes Reinecke
2017-09-25  7:09         ` Sagi Grimberg
2017-09-25  7:09           ` Sagi Grimberg
2017-09-25  8:23           ` Hannes Reinecke
2017-09-25  8:23             ` Hannes Reinecke
2017-09-25 12:52             ` Christoph Hellwig
2017-09-25 12:52               ` Christoph Hellwig
2017-09-21 12:47   ` Guan Junxiong
2017-09-21 12:47     ` Guan Junxiong
2017-09-25  5:36     ` Sagi Grimberg
2017-09-25  5:36       ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170921141033.GA17575@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.