* [PATCH] x86/hvm: Remove unnecessary is_hvm_domain() test in construct_vmcs()
@ 2017-09-20 19:50 Boris Ostrovsky
2017-09-21 14:37 ` Roger Pau Monné
2017-10-11 12:55 ` Jan Beulich
0 siblings, 2 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2017-09-20 19:50 UTC (permalink / raw)
To: xen-devel
Cc: kevin.tian, jbeulich, andrew.cooper3, jun.nakajima,
Boris Ostrovsky, roger.pau
It's a leftover from PVHv1 days.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
xen/arch/x86/hvm/vmx/vmcs.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index f62fe7e..b5100b5 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1271,14 +1271,10 @@ static int construct_vmcs(struct vcpu *v)
vmx_vmcs_exit(v);
- /* PVH: paging mode is updated by arch_set_info_guest(). */
- if ( is_hvm_domain(d) )
- {
- /* will update HOST & GUEST_CR3 as reqd */
- paging_update_paging_modes(v);
+ /* will update HOST & GUEST_CR3 as reqd */
+ paging_update_paging_modes(v);
- vmx_vlapic_msr_changed(v);
- }
+ vmx_vlapic_msr_changed(v);
return 0;
}
--
1.8.3.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/hvm: Remove unnecessary is_hvm_domain() test in construct_vmcs()
2017-09-20 19:50 [PATCH] x86/hvm: Remove unnecessary is_hvm_domain() test in construct_vmcs() Boris Ostrovsky
@ 2017-09-21 14:37 ` Roger Pau Monné
2017-10-11 12:55 ` Jan Beulich
1 sibling, 0 replies; 3+ messages in thread
From: Roger Pau Monné @ 2017-09-21 14:37 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: andrew.cooper3, kevin.tian, jun.nakajima, jbeulich, xen-devel
On Wed, Sep 20, 2017 at 03:50:27PM -0400, Boris Ostrovsky wrote:
> It's a leftover from PVHv1 days.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/hvm: Remove unnecessary is_hvm_domain() test in construct_vmcs()
2017-09-20 19:50 [PATCH] x86/hvm: Remove unnecessary is_hvm_domain() test in construct_vmcs() Boris Ostrovsky
2017-09-21 14:37 ` Roger Pau Monné
@ 2017-10-11 12:55 ` Jan Beulich
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2017-10-11 12:55 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: andrew.cooper3, kevin.tian, xen-devel, jun.nakajima, roger.pau
>>> On 20.09.17 at 21:50, <boris.ostrovsky@oracle.com> wrote:
> It's a leftover from PVHv1 days.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
I've applied this despite the still missing VMX maintainer ack,
for it being simple enough. But in general it should be you to
chase missing acks.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-20 19:50 [PATCH] x86/hvm: Remove unnecessary is_hvm_domain() test in construct_vmcs() Boris Ostrovsky
2017-09-21 14:37 ` Roger Pau Monné
2017-10-11 12:55 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.