* [PATCH] Btrfs: use btrfs_op instead of bio_op in __btrfs_map_block
@ 2017-09-19 23:50 Liu Bo
2017-09-23 0:49 ` Satoru Takeuchi
0 siblings, 1 reply; 3+ messages in thread
From: Liu Bo @ 2017-09-19 23:50 UTC (permalink / raw)
To: linux-btrfs
This seems to be a leftover of commit cf8cddd38bab ("btrfs: don't
abuse REQ_OP_* flags for btrfs_map_block").
It should use btrfs_op() helper to provide one of 'enum btrfs_map_op'
types.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
fs/btrfs/volumes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index bd679bc..bd7b75d3 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -6229,7 +6229,7 @@ blk_status_t btrfs_map_bio(struct btrfs_fs_info *fs_info, struct bio *bio,
map_length = length;
btrfs_bio_counter_inc_blocked(fs_info);
- ret = __btrfs_map_block(fs_info, bio_op(bio), logical,
+ ret = __btrfs_map_block(fs_info, btrfs_op(bio), logical,
&map_length, &bbio, mirror_num, 1);
if (ret) {
btrfs_bio_counter_dec(fs_info);
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Btrfs: use btrfs_op instead of bio_op in __btrfs_map_block
2017-09-19 23:50 [PATCH] Btrfs: use btrfs_op instead of bio_op in __btrfs_map_block Liu Bo
@ 2017-09-23 0:49 ` Satoru Takeuchi
2017-09-23 0:49 ` Liu Bo
0 siblings, 1 reply; 3+ messages in thread
From: Satoru Takeuchi @ 2017-09-23 0:49 UTC (permalink / raw)
To: Liu Bo; +Cc: linux-btrfs
At Tue, 19 Sep 2017 17:50:09 -0600,
Liu Bo wrote:
>
> This seems to be a leftover of commit cf8cddd38bab ("btrfs: don't
> abuse REQ_OP_* flags for btrfs_map_block").
>
> It should use btrfs_op() helper to provide one of 'enum btrfs_map_op'
> types.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
I checked all callers of the following functions and there is no leftover.
- btrfs_map_block
- btrfs_map_sblock
- __btrfs_map_block
Thanks,
Satoru
> ---
> fs/btrfs/volumes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index bd679bc..bd7b75d3 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -6229,7 +6229,7 @@ blk_status_t btrfs_map_bio(struct btrfs_fs_info *fs_info, struct bio *bio,
> map_length = length;
>
> btrfs_bio_counter_inc_blocked(fs_info);
> - ret = __btrfs_map_block(fs_info, bio_op(bio), logical,
> + ret = __btrfs_map_block(fs_info, btrfs_op(bio), logical,
> &map_length, &bbio, mirror_num, 1);
> if (ret) {
> btrfs_bio_counter_dec(fs_info);
> --
> 2.9.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Btrfs: use btrfs_op instead of bio_op in __btrfs_map_block
2017-09-23 0:49 ` Satoru Takeuchi
@ 2017-09-23 0:49 ` Liu Bo
0 siblings, 0 replies; 3+ messages in thread
From: Liu Bo @ 2017-09-23 0:49 UTC (permalink / raw)
To: Satoru Takeuchi; +Cc: linux-btrfs
On Sat, Sep 23, 2017 at 09:49:38AM +0900, Satoru Takeuchi wrote:
> At Tue, 19 Sep 2017 17:50:09 -0600,
> Liu Bo wrote:
> >
> > This seems to be a leftover of commit cf8cddd38bab ("btrfs: don't
> > abuse REQ_OP_* flags for btrfs_map_block").
> >
> > It should use btrfs_op() helper to provide one of 'enum btrfs_map_op'
> > types.
> >
> > Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
>
> Reviewed-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
>
> I checked all callers of the following functions and there is no leftover.
>
> - btrfs_map_block
> - btrfs_map_sblock
> - __btrfs_map_block
I did check them, but thanks a lot for double checking.
thanks,
-liubo
>
> Thanks,
> Satoru
>
> > ---
> > fs/btrfs/volumes.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> > index bd679bc..bd7b75d3 100644
> > --- a/fs/btrfs/volumes.c
> > +++ b/fs/btrfs/volumes.c
> > @@ -6229,7 +6229,7 @@ blk_status_t btrfs_map_bio(struct btrfs_fs_info *fs_info, struct bio *bio,
> > map_length = length;
> >
> > btrfs_bio_counter_inc_blocked(fs_info);
> > - ret = __btrfs_map_block(fs_info, bio_op(bio), logical,
> > + ret = __btrfs_map_block(fs_info, btrfs_op(bio), logical,
> > &map_length, &bbio, mirror_num, 1);
> > if (ret) {
> > btrfs_bio_counter_dec(fs_info);
> > --
> > 2.9.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-23 0:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-19 23:50 [PATCH] Btrfs: use btrfs_op instead of bio_op in __btrfs_map_block Liu Bo
2017-09-23 0:49 ` Satoru Takeuchi
2017-09-23 0:49 ` Liu Bo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.