[Qemu-devel] [PATCH] docker: Fix test-mingw

[Qemu-devel] [PATCH] docker: Fix test-mingw

[Fam Zheng]

Feature "dtc" is explicitly required by test-mingw, but is not detected
by the run script since we switched to archive-source.sh in b7f404201e4.
Since it isn't available in the Fedora image which runs this test on
patchew, the way we get dtc is still from submodule.

archive-source.sh takes care of bundling the submodule files already, so
what we need to do is just checking if files are there. Makefile is
chosen because it is one that is unlikely to get renamed in the future.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/docker/run | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/docker/run b/tests/docker/run
index c8f940de15..0fd2f358ce 100755
--- a/tests/docker/run
+++ b/tests/docker/run
@@ -31,6 +31,9 @@ mkdir -p $TEST_DIR/{src,build,install}
 
 # Extract the source tarballs
 tar -C $TEST_DIR/src -xf $BASE/qemu.tar || prep_fail "Failed to untar source"
+if test -f $TEST_DIR/src/Makefile; then
+    export FEATURES="$FEATURES dtc"
+fi
 
 if test -n "$SHOW_ENV"; then
     if test -f /packages.txt; then
-- 
2.13.5

Re: [Qemu-devel] [PATCH] docker: Fix test-mingw

[Alistair Francis]

On Mon, Sep 25, 2017 at 1:29 AM, Fam Zheng <famz@redhat.com> wrote:
> Feature "dtc" is explicitly required by test-mingw, but is not detected
> by the run script since we switched to archive-source.sh in b7f404201e4.
> Since it isn't available in the Fedora image which runs this test on
> patchew, the way we get dtc is still from submodule.
>
> archive-source.sh takes care of bundling the submodule files already, so
> what we need to do is just checking if files are there. Makefile is
> chosen because it is one that is unlikely to get renamed in the future.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>

Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>

Thanks,
Alistair

> ---
>  tests/docker/run | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/docker/run b/tests/docker/run
> index c8f940de15..0fd2f358ce 100755
> --- a/tests/docker/run
> +++ b/tests/docker/run
> @@ -31,6 +31,9 @@ mkdir -p $TEST_DIR/{src,build,install}
>
>  # Extract the source tarballs
>  tar -C $TEST_DIR/src -xf $BASE/qemu.tar || prep_fail "Failed to untar source"
> +if test -f $TEST_DIR/src/Makefile; then
> +    export FEATURES="$FEATURES dtc"
> +fi
>
>  if test -n "$SHOW_ENV"; then
>      if test -f /packages.txt; then
> --
> 2.13.5
>
>

Re: [Qemu-devel] [PATCH] docker: fix test-mingw

[Peter Maydell]

On Mon, 4 Feb 2019 at 17:14, <no-reply@patchew.org> wrote:
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>    335dbb5de1..773c4a6228  master     -> master
>  * [new tag]               patchew/1549299863-42415-1-git-send-email-pbonzini@redhat.com -> patchew/1549299863-42415-1-git-send-email-pbonzini@redhat.com
> Switched to a new branch 'test'
>
> === OUTPUT BEGIN ===
> checkpatch.pl: no revisions returned for revlist '1'
> === OUTPUT END ===

This is an interesting failure mode -- presumably it's what you
get if you post a patch which ends up without any content when
it's applied to master...

thanks
-- PMM

Re: [Qemu-devel] [PATCH] docker: fix test-mingw

[no-reply]

Patchew URL: https://patchew.org/QEMU/1549299863-42415-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] docker: fix test-mingw
Type: series
Message-id: 1549299863-42415-1-git-send-email-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   335dbb5de1..773c4a6228  master     -> master
 * [new tag]               patchew/1549299863-42415-1-git-send-email-pbonzini@redhat.com -> patchew/1549299863-42415-1-git-send-email-pbonzini@redhat.com
Switched to a new branch 'test'

=== OUTPUT BEGIN ===
checkpatch.pl: no revisions returned for revlist '1'
=== OUTPUT END ===

Test command exited with code: 255


The full log is available at
http://patchew.org/logs/1549299863-42415-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH] docker: fix test-mingw

[Peter Maydell]

On Mon, 4 Feb 2019 at 17:10, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> --with-sdlabi has been removed.  Drop it from the test-mingw docker test.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/test-mingw | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw
> index b078f22..4b84cfe 100755
> --- a/tests/docker/test-mingw
> +++ b/tests/docker/test-mingw
> @@ -27,8 +27,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
>          --enable-curl \
>          --enable-vnc \
>          --enable-bzip2 \
> -        --enable-guest-agent \
> -        --with-sdlabi=2.0
> +        --enable-guest-agent
>      install_qemu
>      make clean

This is already in master, as commit 335dbb5de1e98c4dc7359.

thanks
-- PMM

[Qemu-devel] [PATCH] docker: fix test-mingw

[Paolo Bonzini]

--with-sdlabi has been removed.  Drop it from the test-mingw docker test.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/docker/test-mingw | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw
index b078f22..4b84cfe 100755
--- a/tests/docker/test-mingw
+++ b/tests/docker/test-mingw
@@ -27,8 +27,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
         --enable-curl \
         --enable-vnc \
         --enable-bzip2 \
-        --enable-guest-agent \
-        --with-sdlabi=2.0
+        --enable-guest-agent
     install_qemu
     make clean
 
-- 
1.8.3.1